[JBoss JIRA] (RF-12860) AccordionItem.js with error cause browser crash
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek commented on RF-12860:
-----------------------------------
David: I am not able to reproduce the issue, could you provide more information? Minimized code example which doesn't work would be great for example.
I've tried it with the following code snippet in Google Chrome 25.0.1364.172 and Firefox 19.0.2:
{code}
<rich:extendedDataTable value="#{testBean.people}" var="person" style="width:500px">
<f:facet name="header">
<h:outputText value="People"/>
</f:facet>
<rich:column sortBy="#{person.firstname}" width="250px">
<f:facet name="header">First Name</f:facet>
#{person.firstname}
</rich:column>
<rich:column sortBy="#{person.secondname}" width="250px">
<f:facet name="header">Second Name</f:facet>
#{person.secondname}
</rich:column>
</rich:extendedDataTable>
<rich:accordion switchType="client" width="500px" style="margin-top: 50px">
<rich:accordionItem header="First item">...</rich:accordionItem>
<rich:accordionItem header="Second item">...</rich:accordionItem>
<rich:accordionItem header="Second item">...</rich:accordionItem>
</rich:accordion>
{code}
Whole testing application is available on https://github.com/papousek/richfaces-sanbox/tree/RF-12860.
> AccordionItem.js with error cause browser crash
> -----------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12839) Toggle panels: ajax-related attributes don't work
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-12839?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak commented on RF-12839:
------------------------------------
in 4.2.3.Final
* togglePanelItem and accordionItem don't have these attributes:
** bypassUpdates, data, execute, immediate, limitRender, onbeforedomupdate, onbegin, oncomplete, render, status
* in tab these attributes don't work
** data, onbegin, status
* all three components contain attributes value but IMHO this should be hidden
in 4.3.1.Final
* tab - no attribute work
* accordionItem and togglePanelItem - no ajax attributes
> Toggle panels: ajax-related attributes don't work
> -------------------------------------------------
>
> Key: RF-12839
> URL: https://issues.jboss.org/browse/RF-12839
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.1
> Environment: RichFaces 4.3.2-SNAPSHOT
> Metamer 4.3.2-SNAPSHOT
> JBoss Application Server: Weld Integration 7.1.3.Final-redhat-4
> JBoss AS 7.1.3.Final-redhat-4
> Java(TM) SE Runtime Environment 1.7.0_04-b20 @ Linux
> Chrome 25.0.1364.160 @ Linux x86_64
> Reporter: Pavol Pitonak
> Labels: regression
> Fix For: 4.3.2
>
>
> # deploy Metamer and open http://localhost:8080/metamer/faces/components/richTab/simple.xhtml
> # set oncomplete to "alert('complete')"
> # switch to tab 2 and back to tab 1
> result:
> * alert should be diplayed but isn't
> * tabs are correctly switched
> * worked fine in 4.2.3.Final
> * several attributes don't work - onbegin, onbeforedomupdate, oncomplete, data, execute, immediate, render, limitRender, status
> * affected components: tab, toggle panel item, accordion item
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12841) Tooltip: JavaScript Error with showDelay and partial update
by Ján Jamrich (JIRA)
[ https://issues.jboss.org/browse/RF-12841?page=com.atlassian.jira.plugin.s... ]
Ján Jamrich commented on RF-12841:
----------------------------------
Add simulation to Metamer: http://localhost:8080/metamer/faces/components/richTooltip/rf-12841.xhtml
> Tooltip: JavaScript Error with showDelay and partial update
> -----------------------------------------------------------
>
> Key: RF-12841
> URL: https://issues.jboss.org/browse/RF-12841
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final, 4.3.1
> Environment: Mojarra 2.1.17
> Reporter: Lutz Ulrich
> Assignee: Ján Jamrich
> Priority: Minor
>
> rich:tooltip causes script error when showDelay is used and the tooltip is updated due to a JSF request.
> Console log of Firefox:
> TypeError: tooltip.popup is null
> tooltip.popup.show(tooltip.saveShowEvent); in tooltip.js (line 245)
> The error comes in all browsers I tested with.
> {code}
> <a4j:commandLink action="#{richTabMinimizer.toggle}" render="@this">
> <h:graphicImage library="org.richfaces.images"
> name="#{richTabMinimizer.expanded ? 'triangleUp.png' : 'triangleDown.png'}"/>
>
> <rich:tooltip followMouse="false" showDelay="1000">
> #{richTabMinimizer.expanded ? 'close' : 'expand'}
> </rich:tooltip>
> </a4j:commandLink>
>
> {code}
> (Its a stripped down example. The actual content of my tool-tip holds more text.)
> Note that my 'richTabMinimizer.toggle' bean toggles some GUI stuff and its property 'expanded' is switched from true to false and vice versa.
> You may probably replace it with anything to reproduce the error.
> Probably the tool-tip tries to show after the HTML elements have already been updated.
> It's no serious error. Nevertheless, its ugly.
> I guess it is not unusual to have a tool-tip (with a showDelay) on a command.
> But often, users will click the command just after the mouse entered the command.
> Maybe this issue report is a duplicate of RF-8652, but in contrast to 8652, I do not refer to open tooltips.
> For me, it would be sufficient if the script error is avoided.
> I do not expect the updated tooltip to show after the delay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12841) Tooltip: JavaScript Error with showDelay and partial update
by Ján Jamrich (JIRA)
[ https://issues.jboss.org/browse/RF-12841?page=com.atlassian.jira.plugin.s... ]
Ján Jamrich reassigned RF-12841:
--------------------------------
Assignee: (was: Ján Jamrich)
> Tooltip: JavaScript Error with showDelay and partial update
> -----------------------------------------------------------
>
> Key: RF-12841
> URL: https://issues.jboss.org/browse/RF-12841
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final, 4.3.1
> Environment: Mojarra 2.1.17
> Reporter: Lutz Ulrich
> Priority: Minor
>
> rich:tooltip causes script error when showDelay is used and the tooltip is updated due to a JSF request.
> Console log of Firefox:
> TypeError: tooltip.popup is null
> tooltip.popup.show(tooltip.saveShowEvent); in tooltip.js (line 245)
> The error comes in all browsers I tested with.
> {code}
> <a4j:commandLink action="#{richTabMinimizer.toggle}" render="@this">
> <h:graphicImage library="org.richfaces.images"
> name="#{richTabMinimizer.expanded ? 'triangleUp.png' : 'triangleDown.png'}"/>
>
> <rich:tooltip followMouse="false" showDelay="1000">
> #{richTabMinimizer.expanded ? 'close' : 'expand'}
> </rich:tooltip>
> </a4j:commandLink>
>
> {code}
> (Its a stripped down example. The actual content of my tool-tip holds more text.)
> Note that my 'richTabMinimizer.toggle' bean toggles some GUI stuff and its property 'expanded' is switched from true to false and vice versa.
> You may probably replace it with anything to reproduce the error.
> Probably the tool-tip tries to show after the HTML elements have already been updated.
> It's no serious error. Nevertheless, its ugly.
> I guess it is not unusual to have a tool-tip (with a showDelay) on a command.
> But often, users will click the command just after the mouse entered the command.
> Maybe this issue report is a duplicate of RF-8652, but in contrast to 8652, I do not refer to open tooltips.
> For me, it would be sufficient if the script error is avoided.
> I do not expect the updated tooltip to show after the delay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12831) <rich:validator/> performs ajax validation without updating underlying model field
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-12831?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak reassigned RF-12831:
----------------------------------
Assignee: Juraj Húska (was: Pavol Pitonak)
> <rich:validator/> performs ajax validation without updating underlying model field
> ----------------------------------------------------------------------------------
>
> Key: RF-12831
> URL: https://issues.jboss.org/browse/RF-12831
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.0.Final
> Environment: JBoss eap 6.0.0, Win 7
> Reporter: Kamil Roman
> Assignee: Juraj Húska
> Priority: Minor
>
> Not sure if it's a bug or a feature, but field annotated with {code}<rich:validator/>{code} with a validation method set with {code}validator{code} attribute gets validated without updating the underlying model field. My code is something like this:
> {code:title=Model.java}
> public class Model {
> //...
> public Date getValidFrom() {/*...*/}
> public Date getValidTo() {/*...*/}
> }
> {code}
> {code:title=ModelValidator.java}
> public class ModelValidator{
> private Model model;
> public boolean isValidToAfterValidFrom() {
> return model.getValidTo().after(model.getValidFrom());
> }
> }
> {code}
> {code:title=model_form.xml}
> <c:set var="model" value="#{ModelBean.model}"/>
> <h:outputLabel value="#{labels.getLabel('valid_from')}" for="validFrom" />
> <rich:calendar value="#{model.validFrom}" id="validFrom" >
> <rich:validator/>
> </rich:calendar>
> <rich:message for="validFrom"/>
>
> <h:outputLabel value="#{labels.getLabel('valid_to')}" for="validTo" />
> <rich:calendar value="#{model.validTo}" id="validTo" validator="#{modelBean.validateValidTo}">
> <rich:validator event="inputblur"/>
> </rich:calendar>
> <rich:message for="validTo"/>
> {code}
> {code:title=ModelBean.java}
> public class ModelBean {
> public Model getModel() {/*..*/}
> private ModelValidator validator;
> //...
> public validateValidTo(FacesContext context, UIComponent toValidate, Object value) {
> if(!validator.isValidToAfterValidFrom()) {
> FacesMessage message = new FacesMessage(FacesMessage.SEVERITY_ERROR, labelBean.getLabel("valid.to.not.after.valid.from.error"), null);
> throw new ValidatorException(message);
> }
> }
> {code}
> The getModel() method returns the same Model instance as is used by the ModelValidator in ModelBean.
> Now, the testcase is:
> 1. User selects validTo earlier than ValidFrom (on a valid Model instance)
> 2. Validation passes as the underlying model value is not updated (validator refers to the same Model instance as ModelBean)
> 3. User submits the form.
> 4. System displays error message as server-side validation on submit is performed after applying request values.
> 5. User corrects the value in validTo field.
> 6. System still displays error message as validation fails, because the new value is not applied to the model (model holds the invalid value applied during failed submit).
> If this is not a bug, but a feature, it would be great if you included this behaviour in the docs!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12841) Tooltip: JavaScript Error with showDelay and partial update
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-12841?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak reassigned RF-12841:
----------------------------------
Assignee: Ján Jamrich (was: Pavol Pitonak)
> Tooltip: JavaScript Error with showDelay and partial update
> -----------------------------------------------------------
>
> Key: RF-12841
> URL: https://issues.jboss.org/browse/RF-12841
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final, 4.3.1
> Environment: Mojarra 2.1.17
> Reporter: Lutz Ulrich
> Assignee: Ján Jamrich
> Priority: Minor
>
> rich:tooltip causes script error when showDelay is used and the tooltip is updated due to a JSF request.
> Console log of Firefox:
> TypeError: tooltip.popup is null
> tooltip.popup.show(tooltip.saveShowEvent); in tooltip.js (line 245)
> The error comes in all browsers I tested with.
> {code}
> <a4j:commandLink action="#{richTabMinimizer.toggle}" render="@this">
> <h:graphicImage library="org.richfaces.images"
> name="#{richTabMinimizer.expanded ? 'triangleUp.png' : 'triangleDown.png'}"/>
>
> <rich:tooltip followMouse="false" showDelay="1000">
> #{richTabMinimizer.expanded ? 'close' : 'expand'}
> </rich:tooltip>
> </a4j:commandLink>
>
> {code}
> (Its a stripped down example. The actual content of my tool-tip holds more text.)
> Note that my 'richTabMinimizer.toggle' bean toggles some GUI stuff and its property 'expanded' is switched from true to false and vice versa.
> You may probably replace it with anything to reproduce the error.
> Probably the tool-tip tries to show after the HTML elements have already been updated.
> It's no serious error. Nevertheless, its ugly.
> I guess it is not unusual to have a tool-tip (with a showDelay) on a command.
> But often, users will click the command just after the mouse entered the command.
> Maybe this issue report is a duplicate of RF-8652, but in contrast to 8652, I do not refer to open tooltips.
> For me, it would be sufficient if the script error is avoided.
> I do not expect the updated tooltip to show after the delay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12860) AccordionItem.js with error cause browser crash
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak reassigned RF-12860:
----------------------------------
Assignee: Jan Papousek (was: Pavol Pitonak)
> AccordionItem.js with error cause browser crash
> -----------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months