[JBoss JIRA] (RF-12921) rich:validator: created message is escaped, even if the message component should not be escaped
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12921?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12921:
---------------------------------
Hey Jiri, is this regression?
> rich:validator: created message is escaped, even if the message component should not be escaped
> -----------------------------------------------------------------------------------------------
>
> Key: RF-12921
> URL: https://issues.jboss.org/browse/RF-12921
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Environment: RichFaces 4.3.2-SNAPSHOT
> Metamer 5.0.0-SNAPSHOT
> JBoss AS 7.1.1.Final
> Java(TM) SE Runtime Environment 1.7.0_09-b05 @ Linux
> Firefox 18.0 @ Linux x86_64
> Reporter: Jiří Štefek
> Priority: Minor
> Fix For: 4.3.2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The created message is always escaped, even if the message component has its attribute @escape=false.
> Message components: rich:message, rich:messages, rich:notifyMessage, rich:notifyMessages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12839) Toggle panels: ajax-related attributes don't work
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RF-12839?page=com.atlassian.jira.plugin.s... ]
Jiří Štefek commented on RF-12839:
----------------------------------
With RF 4.2.3.Final, attributes of rich:Tab:
* bypassUpdates, immediate, data, execute, limitRender, render: works fine
* onbeforedomupdate, oncomplete: are triggered twice at first time, then only once (>tab2>tab1 [2 events]>tab2>tab1 [1 event])
* onbegin, status: not working
> Toggle panels: ajax-related attributes don't work
> -------------------------------------------------
>
> Key: RF-12839
> URL: https://issues.jboss.org/browse/RF-12839
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.1
> Environment: RichFaces 4.3.2-SNAPSHOT
> Metamer 4.3.2-SNAPSHOT
> JBoss Application Server: Weld Integration 7.1.3.Final-redhat-4
> JBoss AS 7.1.3.Final-redhat-4
> Java(TM) SE Runtime Environment 1.7.0_04-b20 @ Linux
> Chrome 25.0.1364.160 @ Linux x86_64
> Reporter: Pavol Pitonak
> Assignee: Brian Leathem
> Fix For: 4.3.2
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> # deploy Metamer and open http://localhost:8080/metamer/faces/components/richTab/simple.xhtml
> # set oncomplete to "alert('complete')"
> # switch to tab 2 and back to tab 1
> result:
> * alert should be diplayed but isn't
> * tabs are correctly switched
> * worked fine in 4.2.3.Final
> * several attributes don't work - onbegin, onbeforedomupdate, oncomplete, data, execute, immediate, render, limitRender, status
> * affected components: tab, toggle panel item, accordion item
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12897) ExtendedPartialViewContextImpl swallows exceptions
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12897?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-12897:
----------------------------------
Assignee: (was: Brian Leathem)
> ExtendedPartialViewContextImpl swallows exceptions
> --------------------------------------------------
>
> Key: RF-12897
> URL: https://issues.jboss.org/browse/RF-12897
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.2.2.Final
> Environment: Windows 7, JDK 1.6
> Reporter: Cristian Cerb
> Priority: Critical
> Labels: richfaces
> Fix For: 4.3.2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Method public VisitResult visit(VisitContext context, UIComponent target) of class ExtendedPartialViewContextImpl swallows exceptions. I think exceptions should be wrapped inside a FaceException and propagated. This class http://java.net/projects/mojarra/sources/svn/content/trunk/jsf-ri/src/mai... seems to have served as a model for the RF one, but the RF class inadvertently chose to swallow exceptions instead of propagating them up. This causes unpredictable behaviour, such as system being stuck in the browser.
> I just found an older version of Sun's Mojarra where they had the same issue, but the newer versions seem to have fixed it. See this taken from jsf 2.1.4:
> {code}
> public VisitResult visit(VisitContext context, UIComponent comp) {
> try {
> if (curPhase == PhaseId.APPLY_REQUEST_VALUES) {
> // RELEASE_PENDING handle immediate request(s)
> // If the user requested an immediate request
> // Make sure to set the immediate flag here.
> comp.processDecodes(ctx);
> } else if (curPhase == PhaseId.PROCESS_VALIDATIONS) {
> comp.processValidators(ctx);
> } else if (curPhase == PhaseId.UPDATE_MODEL_VALUES) {
> comp.processUpdates(ctx);
> } else if (curPhase == PhaseId.RENDER_RESPONSE) {
> PartialResponseWriter writer = ctx.getPartialViewContext().getPartialResponseWriter();
> writer.startUpdate(comp.getClientId(ctx));
> try {
> // do the default behavior...
> comp.encodeAll(ctx);
> }
> catch (Exception ce) {
> if (LOGGER.isLoggable(Level.SEVERE)) {
> LOGGER.severe(ce.toString());
> }
> if (LOGGER.isLoggable(Level.FINE)) {
> LOGGER.log(Level.FINE,
> ce.toString(),
> ce);
> }
> }
> writer.endUpdate();
> }
> else {
> throw new IllegalStateException("I18N: Unexpected " +
> "PhaseId passed to " +
> " PhaseAwareContextCallback: " +
> curPhase.toString());
> }
> }
> catch (IOException ex) {
> ex.printStackTrace();
> }
> // Once we visit a component, there is no need to visit
> // its children, since processDecodes/Validators/Updates and
> // encodeAll() already traverse the subtree. We return
> // VisitResult.REJECT to supress the subtree visit.
> return VisitResult.REJECT;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12193) rich:extendedDataTable is blank on show
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12193?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-12193:
----------------------------------
Assignee: Brian Leathem
> rich:extendedDataTable is blank on show
> ---------------------------------------
>
> Key: RF-12193
> URL: https://issues.jboss.org/browse/RF-12193
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.2.1.Final
> Environment: Firefox 11, Internet Explorer 8
> Reporter: Nick Dev
> Assignee: Brian Leathem
> Fix For: 4.3.2, 5-Tracking
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> rich:extendedDataTable is blank when shown after it was hidden.
> Firefox: complete table is blank.
> IE: table header is not displayed.
> Table is shown after resizing the window.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12897) ExtendedPartialViewContextImpl swallows exceptions
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12897?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12897:
-------------------------------
Sprint: RF5 Alpha1 Sprint 4
> ExtendedPartialViewContextImpl swallows exceptions
> --------------------------------------------------
>
> Key: RF-12897
> URL: https://issues.jboss.org/browse/RF-12897
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.2.2.Final
> Environment: Windows 7, JDK 1.6
> Reporter: Cristian Cerb
> Assignee: Brian Leathem
> Priority: Critical
> Labels: richfaces
> Fix For: 4.3.2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Method public VisitResult visit(VisitContext context, UIComponent target) of class ExtendedPartialViewContextImpl swallows exceptions. I think exceptions should be wrapped inside a FaceException and propagated. This class http://java.net/projects/mojarra/sources/svn/content/trunk/jsf-ri/src/mai... seems to have served as a model for the RF one, but the RF class inadvertently chose to swallow exceptions instead of propagating them up. This causes unpredictable behaviour, such as system being stuck in the browser.
> I just found an older version of Sun's Mojarra where they had the same issue, but the newer versions seem to have fixed it. See this taken from jsf 2.1.4:
> {code}
> public VisitResult visit(VisitContext context, UIComponent comp) {
> try {
> if (curPhase == PhaseId.APPLY_REQUEST_VALUES) {
> // RELEASE_PENDING handle immediate request(s)
> // If the user requested an immediate request
> // Make sure to set the immediate flag here.
> comp.processDecodes(ctx);
> } else if (curPhase == PhaseId.PROCESS_VALIDATIONS) {
> comp.processValidators(ctx);
> } else if (curPhase == PhaseId.UPDATE_MODEL_VALUES) {
> comp.processUpdates(ctx);
> } else if (curPhase == PhaseId.RENDER_RESPONSE) {
> PartialResponseWriter writer = ctx.getPartialViewContext().getPartialResponseWriter();
> writer.startUpdate(comp.getClientId(ctx));
> try {
> // do the default behavior...
> comp.encodeAll(ctx);
> }
> catch (Exception ce) {
> if (LOGGER.isLoggable(Level.SEVERE)) {
> LOGGER.severe(ce.toString());
> }
> if (LOGGER.isLoggable(Level.FINE)) {
> LOGGER.log(Level.FINE,
> ce.toString(),
> ce);
> }
> }
> writer.endUpdate();
> }
> else {
> throw new IllegalStateException("I18N: Unexpected " +
> "PhaseId passed to " +
> " PhaseAwareContextCallback: " +
> curPhase.toString());
> }
> }
> catch (IOException ex) {
> ex.printStackTrace();
> }
> // Once we visit a component, there is no need to visit
> // its children, since processDecodes/Validators/Updates and
> // encodeAll() already traverse the subtree. We return
> // VisitResult.REJECT to supress the subtree visit.
> return VisitResult.REJECT;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12897) ExtendedPartialViewContextImpl swallows exceptions
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12897?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12897:
-------------------------------
Sprint: (was: RF5 Alpha1 Sprint 4)
> ExtendedPartialViewContextImpl swallows exceptions
> --------------------------------------------------
>
> Key: RF-12897
> URL: https://issues.jboss.org/browse/RF-12897
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.2.2.Final
> Environment: Windows 7, JDK 1.6
> Reporter: Cristian Cerb
> Assignee: Brian Leathem
> Priority: Critical
> Labels: richfaces
> Fix For: 4.3.2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Method public VisitResult visit(VisitContext context, UIComponent target) of class ExtendedPartialViewContextImpl swallows exceptions. I think exceptions should be wrapped inside a FaceException and propagated. This class http://java.net/projects/mojarra/sources/svn/content/trunk/jsf-ri/src/mai... seems to have served as a model for the RF one, but the RF class inadvertently chose to swallow exceptions instead of propagating them up. This causes unpredictable behaviour, such as system being stuck in the browser.
> I just found an older version of Sun's Mojarra where they had the same issue, but the newer versions seem to have fixed it. See this taken from jsf 2.1.4:
> {code}
> public VisitResult visit(VisitContext context, UIComponent comp) {
> try {
> if (curPhase == PhaseId.APPLY_REQUEST_VALUES) {
> // RELEASE_PENDING handle immediate request(s)
> // If the user requested an immediate request
> // Make sure to set the immediate flag here.
> comp.processDecodes(ctx);
> } else if (curPhase == PhaseId.PROCESS_VALIDATIONS) {
> comp.processValidators(ctx);
> } else if (curPhase == PhaseId.UPDATE_MODEL_VALUES) {
> comp.processUpdates(ctx);
> } else if (curPhase == PhaseId.RENDER_RESPONSE) {
> PartialResponseWriter writer = ctx.getPartialViewContext().getPartialResponseWriter();
> writer.startUpdate(comp.getClientId(ctx));
> try {
> // do the default behavior...
> comp.encodeAll(ctx);
> }
> catch (Exception ce) {
> if (LOGGER.isLoggable(Level.SEVERE)) {
> LOGGER.severe(ce.toString());
> }
> if (LOGGER.isLoggable(Level.FINE)) {
> LOGGER.log(Level.FINE,
> ce.toString(),
> ce);
> }
> }
> writer.endUpdate();
> }
> else {
> throw new IllegalStateException("I18N: Unexpected " +
> "PhaseId passed to " +
> " PhaseAwareContextCallback: " +
> curPhase.toString());
> }
> }
> catch (IOException ex) {
> ex.printStackTrace();
> }
> // Once we visit a component, there is no need to visit
> // its children, since processDecodes/Validators/Updates and
> // encodeAll() already traverse the subtree. We return
> // VisitResult.REJECT to supress the subtree visit.
> return VisitResult.REJECT;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12921) rich:validator: created message is escaped, even if the message component should not be escaped
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12921?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12921:
-------------------------------
Original Estimate: 1 hour
Remaining Estimate: 1 hour
> rich:validator: created message is escaped, even if the message component should not be escaped
> -----------------------------------------------------------------------------------------------
>
> Key: RF-12921
> URL: https://issues.jboss.org/browse/RF-12921
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Environment: RichFaces 4.3.2-SNAPSHOT
> Metamer 5.0.0-SNAPSHOT
> JBoss AS 7.1.1.Final
> Java(TM) SE Runtime Environment 1.7.0_09-b05 @ Linux
> Firefox 18.0 @ Linux x86_64
> Reporter: Jiří Štefek
> Priority: Minor
> Fix For: 4.3.2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The created message is always escaped, even if the message component has its attribute @escape=false.
> Message components: rich:message, rich:messages, rich:notifyMessage, rich:notifyMessages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (RF-12921) rich:validator: created message is escaped, even if the message component should not be escaped
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12921?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12921:
-------------------------------
Sprint: RF5 Alpha1 Sprint 4
> rich:validator: created message is escaped, even if the message component should not be escaped
> -----------------------------------------------------------------------------------------------
>
> Key: RF-12921
> URL: https://issues.jboss.org/browse/RF-12921
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Environment: RichFaces 4.3.2-SNAPSHOT
> Metamer 5.0.0-SNAPSHOT
> JBoss AS 7.1.1.Final
> Java(TM) SE Runtime Environment 1.7.0_09-b05 @ Linux
> Firefox 18.0 @ Linux x86_64
> Reporter: Jiří Štefek
> Priority: Minor
> Fix For: 4.3.2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The created message is always escaped, even if the message component has its attribute @escape=false.
> Message components: rich:message, rich:messages, rich:notifyMessage, rich:notifyMessages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months