[JBoss JIRA] (RF-12845) rich:menuItem does not work as composite component
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12845?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-12845:
------------------------------------
[~michaelb80] indeed you are correct, the DropDownMenuRenderer only renders children that are of one of the following types:
{code}
child instanceof AbstractMenuGroup || child instanceof AbstractMenuItem || child instanceof AbstractMenuSeparator
{code}
See:
https://github.com/richfaces/components/blob/master/output/ui/src/main/ja...
You could try setting your the componsite component _componentType_ to '<org.richfaces.<package>.UIMenuItem'. Then you won't have to implement a java sclass yourself.
> rich:menuItem does not work as composite component
> --------------------------------------------------
>
> Key: RF-12845
> URL: https://issues.jboss.org/browse/RF-12845
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.1
> Environment: Win7 x64, Java 6 x64, Tomcat 7.0.30 x64, RF 4.3.1, IE8 + FF19.0.2
> Reporter: Michael B
> Priority: Minor
> Labels: richfaces
>
> When creating a composite component that contains a rich:menuItem, the menu item is not showing. => Client side error while identifying the menu items parent via css-selector.
> {code:xml|title:menuItem.xhtml}
> <?xml version="1.0" encoding="UTF-8"?>
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:f="http://java.sun.com/jsf/core"
> xmlns:rich="http://richfaces.org/rich"
> xmlns:composite="http://java.sun.com/jsf/composite">
>
> <composite:interface>
> <composite:attribute name="icon" type="java.lang.String" required="false" />
> <composite:attribute name="label" type="java.lang.String" required="true" />
> <composite:attribute name="menuItem" type="java.lang.String" required="true" />
> <composite:attribute name="menuKey" type="java.lang.String" required="true" />
> <composite:attribute name="value" type="java.lang.String" required="true" />
> </composite:interface>
>
> <composite:implementation>
> <rich:menuItem label="#{cc.attrs.label}" icon="#{cc.attrs.icon}" action="#{menuController.menuItemClicked}" rendered="#{menuController.isMenuItemAccessible( cc.attrs.menuKey, cc.attrs.menuItem )}">
> <f:param name="selectedItem" value="#{cc.attrs.value}" />
> </rich:menuItem>
> </composite:implementation>
>
> </html>
> {code}
> Including the resulting composite component in a rich:dropDownMenu like
> {code:xml}
> <ui:composition xmlns="http://www.w3.org/1999/xhtml"
> xmlns:ui="http://java.sun.com/jsf/facelets"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:f="http://java.sun.com/jsf/core"
> xmlns:a4j="http://richfaces.org/a4j"
> xmlns:rich="http://richfaces.org/rich"
> xmlns:xxx="http://java.sun.com/jsf/composite/xxx">
>
> <rich:toolbar>
> <rich:dropDownMenu>
> <f:facet name="label">
> <h:outputText value="Test" />
> </f:facet>
> <xxx:menuItem label="Item 1" value="item1" menuKey="aaa" menuItem="bbb" />
> </rich:dropDownMenu>
> </rich:toolbar>
>
> </ui:composition>
> {code}
> ... reproduces the problem. Writing the rich:menuItem directly inside the rich:dropDownMenu works. Also wrapping the composite component with rich:menuGroup works. Only the direct child option fails.
> See example for comparison - item 2 and 3 are working, while item 1 is not:
> {code:xml}
> <ui:composition xmlns="http://www.w3.org/1999/xhtml"
> xmlns:ui="http://java.sun.com/jsf/facelets"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:f="http://java.sun.com/jsf/core"
> xmlns:a4j="http://richfaces.org/a4j"
> xmlns:rich="http://richfaces.org/rich"
> xmlns:xxx="http://java.sun.com/jsf/composite/xxx">
>
> <rich:toolbar>
> <rich:dropDownMenu>
> <f:facet name="label">
> <h:outputText value="Test" />
> </f:facet>
> <xxx:menuItem label="Item 1" value="item1" menuKey="aaa" menuItem="bbb" />
> <rich:menuItem label="Item 2" action="#{menuController.menuItemClicked}" rendered="#{menuController.isMenuItemAccessible( 'aaa', 'bbb' )}">
> <f:param name="selectedItem" value="item2" />
> </rich:menuItem>
> <rich:menuGroup label="Group">
> <xxx:menuItem label="Item 3" value="item3" menuKey="aaa" menuItem="bbb" />
> </rich:menuGroup>
> </rich:dropDownMenu>
> </rich:toolbar>
>
> </ui:composition>
> {code}
> On a side not: just found out, that the problem might come from the rich:dropDownMenu only allowing for direct children of type rich:menuGroup or rich:menuItem, while a composite component always adds another UIPanel to wrap itself. So if I understand the concept correctly, one would have to write a custom component class that is a menu item and also implements NamingContainer and add it as 'componentType' to the interface. Kinda beats the purpose of being able to easily create an extended markup for components that are expected as direct children though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12841) Tooltip: JavaScript Error with showDelay and partial update
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12841?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12841:
-------------------------------
Labels: testcase_provided (was: )
> Tooltip: JavaScript Error with showDelay and partial update
> -----------------------------------------------------------
>
> Key: RF-12841
> URL: https://issues.jboss.org/browse/RF-12841
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final, 4.3.1
> Environment: Mojarra 2.1.17
> Reporter: Lutz Ulrich
> Priority: Minor
> Labels: testcase_provided
>
> rich:tooltip causes script error when showDelay is used and the tooltip is updated due to a JSF request.
> Console log of Firefox:
> TypeError: tooltip.popup is null
> tooltip.popup.show(tooltip.saveShowEvent); in tooltip.js (line 245)
> The error comes in all browsers I tested with.
> {code}
> <a4j:commandLink action="#{richTabMinimizer.toggle}" render="@this">
> <h:graphicImage library="org.richfaces.images"
> name="#{richTabMinimizer.expanded ? 'triangleUp.png' : 'triangleDown.png'}"/>
>
> <rich:tooltip followMouse="false" showDelay="1000">
> #{richTabMinimizer.expanded ? 'close' : 'expand'}
> </rich:tooltip>
> </a4j:commandLink>
>
> {code}
> (Its a stripped down example. The actual content of my tool-tip holds more text.)
> Note that my 'richTabMinimizer.toggle' bean toggles some GUI stuff and its property 'expanded' is switched from true to false and vice versa.
> You may probably replace it with anything to reproduce the error.
> Probably the tool-tip tries to show after the HTML elements have already been updated.
> It's no serious error. Nevertheless, its ugly.
> I guess it is not unusual to have a tool-tip (with a showDelay) on a command.
> But often, users will click the command just after the mouse entered the command.
> Maybe this issue report is a duplicate of RF-8652, but in contrast to 8652, I do not refer to open tooltips.
> For me, it would be sufficient if the script error is avoided.
> I do not expect the updated tooltip to show after the delay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12825) rich:column does not create unique IDs when included in rich:pickList
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12825?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12825:
-------------------------------
Component/s: (was: component-tables)
> rich:column does not create unique IDs when included in rich:pickList
> ---------------------------------------------------------------------
>
> Key: RF-12825
> URL: https://issues.jboss.org/browse/RF-12825
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-selects
> Affects Versions: 4.3.0.Final
> Reporter: Manuel Fehlhammer
> Fix For: 5-Tracking
>
>
> The following artefact, where I use rich:tooltip inside rich:column of a rich:pickList shows the bug.
> Only for the first entry of the source picklist a tooltip is displayed on mouse over.
> Reason (see linked forum thread) is, that the rich:column does not correctly generate the ID of the included h:output when iterating over the select items.
> Since this works ok, when rich:column is inside a rich:table it is obviously a problem, when rich:column is included in rich:pickList.
> {code:xml}
> <h:body>
> <f:view>
> <h:form>
> <rich:pickList value="#{backBean.pickListTargetCol}"
> var="item"
> listsHeight="100"
> listWidth="100"
> sourceCaption="SourceItems"
> targetCaption="PickedItems">
> <f:selectItems value="#{backBean.pickListSourceCol}"/>
> <rich:column id="myCol">
> <h:outputText id="item" value="Item_#{item}"/>
> <rich:tooltip target="item" value="Tooltip_#{item}"/>
> </rich:column>
> </rich:pickList>
> </h:form>
> </f:view>
> </h:body>
> {code}
> managed bean for this example:
> {code}
> @ManagedBean(name = "backBean")
> @SessionScoped
> public class TestBean {
> private Collection<Integer> pickListTargetCol;
> private Collection<Integer> pickListSourceCol;
>
> public Collection<Integer> getPickListTargetCol()
> {
> return pickListTargetCol;
> }
> public void setPickListTargetCol(Collection<Integer> pickListTargetCol)
> {
> this.pickListTargetCol = pickListTargetCol;
> }
>
> public Collection<Integer> getPickListSourceCol()
> {
> Collection<Integer> result = new ArrayList();
> for(int i = 1; i<=10; i++)
> {
> result.add(i);
> }
> return result;
> }
>
> public void setPickListSourceCol(Collection<Integer> pickListSourceCol)
> {
> this.pickListSourceCol = pickListSourceCol;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12825) rich:column does not create unique IDs when included in rich:pickList
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12825?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12825:
-------------------------------
Component/s: component-selects
> rich:column does not create unique IDs when included in rich:pickList
> ---------------------------------------------------------------------
>
> Key: RF-12825
> URL: https://issues.jboss.org/browse/RF-12825
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-selects, component-tables
> Affects Versions: 4.3.0.Final
> Reporter: Manuel Fehlhammer
> Fix For: 5-Tracking
>
>
> The following artefact, where I use rich:tooltip inside rich:column of a rich:pickList shows the bug.
> Only for the first entry of the source picklist a tooltip is displayed on mouse over.
> Reason (see linked forum thread) is, that the rich:column does not correctly generate the ID of the included h:output when iterating over the select items.
> Since this works ok, when rich:column is inside a rich:table it is obviously a problem, when rich:column is included in rich:pickList.
> {code:xml}
> <h:body>
> <f:view>
> <h:form>
> <rich:pickList value="#{backBean.pickListTargetCol}"
> var="item"
> listsHeight="100"
> listWidth="100"
> sourceCaption="SourceItems"
> targetCaption="PickedItems">
> <f:selectItems value="#{backBean.pickListSourceCol}"/>
> <rich:column id="myCol">
> <h:outputText id="item" value="Item_#{item}"/>
> <rich:tooltip target="item" value="Tooltip_#{item}"/>
> </rich:column>
> </rich:pickList>
> </h:form>
> </f:view>
> </h:body>
> {code}
> managed bean for this example:
> {code}
> @ManagedBean(name = "backBean")
> @SessionScoped
> public class TestBean {
> private Collection<Integer> pickListTargetCol;
> private Collection<Integer> pickListSourceCol;
>
> public Collection<Integer> getPickListTargetCol()
> {
> return pickListTargetCol;
> }
> public void setPickListTargetCol(Collection<Integer> pickListTargetCol)
> {
> this.pickListTargetCol = pickListTargetCol;
> }
>
> public Collection<Integer> getPickListSourceCol()
> {
> Collection<Integer> result = new ArrayList();
> for(int i = 1; i<=10; i++)
> {
> result.add(i);
> }
> return result;
> }
>
> public void setPickListSourceCol(Collection<Integer> pickListSourceCol)
> {
> this.pickListSourceCol = pickListSourceCol;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12841) Tooltip: JavaScript Error with showDelay and partial update
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12841?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12841:
-------------------------------
Fix Version/s: 5-Tracking
> Tooltip: JavaScript Error with showDelay and partial update
> -----------------------------------------------------------
>
> Key: RF-12841
> URL: https://issues.jboss.org/browse/RF-12841
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final, 4.3.1
> Environment: Mojarra 2.1.17
> Reporter: Lutz Ulrich
> Priority: Minor
> Labels: testcase_provided
> Fix For: 5-Tracking
>
>
> rich:tooltip causes script error when showDelay is used and the tooltip is updated due to a JSF request.
> Console log of Firefox:
> TypeError: tooltip.popup is null
> tooltip.popup.show(tooltip.saveShowEvent); in tooltip.js (line 245)
> The error comes in all browsers I tested with.
> {code}
> <a4j:commandLink action="#{richTabMinimizer.toggle}" render="@this">
> <h:graphicImage library="org.richfaces.images"
> name="#{richTabMinimizer.expanded ? 'triangleUp.png' : 'triangleDown.png'}"/>
>
> <rich:tooltip followMouse="false" showDelay="1000">
> #{richTabMinimizer.expanded ? 'close' : 'expand'}
> </rich:tooltip>
> </a4j:commandLink>
>
> {code}
> (Its a stripped down example. The actual content of my tool-tip holds more text.)
> Note that my 'richTabMinimizer.toggle' bean toggles some GUI stuff and its property 'expanded' is switched from true to false and vice versa.
> You may probably replace it with anything to reproduce the error.
> Probably the tool-tip tries to show after the HTML elements have already been updated.
> It's no serious error. Nevertheless, its ugly.
> I guess it is not unusual to have a tool-tip (with a showDelay) on a command.
> But often, users will click the command just after the mouse entered the command.
> Maybe this issue report is a duplicate of RF-8652, but in contrast to 8652, I do not refer to open tooltips.
> For me, it would be sufficient if the script error is avoided.
> I do not expect the updated tooltip to show after the delay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12825) rich:column does not create unique IDs when included in rich:pickList
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12825?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12825:
-------------------------------
Fix Version/s: 5-Tracking
> rich:column does not create unique IDs when included in rich:pickList
> ---------------------------------------------------------------------
>
> Key: RF-12825
> URL: https://issues.jboss.org/browse/RF-12825
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.0.Final
> Reporter: Manuel Fehlhammer
> Fix For: 5-Tracking
>
>
> The following artefact, where I use rich:tooltip inside rich:column of a rich:pickList shows the bug.
> Only for the first entry of the source picklist a tooltip is displayed on mouse over.
> Reason (see linked forum thread) is, that the rich:column does not correctly generate the ID of the included h:output when iterating over the select items.
> Since this works ok, when rich:column is inside a rich:table it is obviously a problem, when rich:column is included in rich:pickList.
> {code:xml}
> <h:body>
> <f:view>
> <h:form>
> <rich:pickList value="#{backBean.pickListTargetCol}"
> var="item"
> listsHeight="100"
> listWidth="100"
> sourceCaption="SourceItems"
> targetCaption="PickedItems">
> <f:selectItems value="#{backBean.pickListSourceCol}"/>
> <rich:column id="myCol">
> <h:outputText id="item" value="Item_#{item}"/>
> <rich:tooltip target="item" value="Tooltip_#{item}"/>
> </rich:column>
> </rich:pickList>
> </h:form>
> </f:view>
> </h:body>
> {code}
> managed bean for this example:
> {code}
> @ManagedBean(name = "backBean")
> @SessionScoped
> public class TestBean {
> private Collection<Integer> pickListTargetCol;
> private Collection<Integer> pickListSourceCol;
>
> public Collection<Integer> getPickListTargetCol()
> {
> return pickListTargetCol;
> }
> public void setPickListTargetCol(Collection<Integer> pickListTargetCol)
> {
> this.pickListTargetCol = pickListTargetCol;
> }
>
> public Collection<Integer> getPickListSourceCol()
> {
> Collection<Integer> result = new ArrayList();
> for(int i = 1; i<=10; i++)
> {
> result.add(i);
> }
> return result;
> }
>
> public void setPickListSourceCol(Collection<Integer> pickListSourceCol)
> {
> this.pickListSourceCol = pickListSourceCol;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12820) AutoComplete Layout Table is broken
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12820?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-12820:
----------------------------------
Assignee: Pavol Pitonak
[~ppitonak] do we have any tests covering this use case?
> AutoComplete Layout Table is broken
> -----------------------------------
>
> Key: RF-12820
> URL: https://issues.jboss.org/browse/RF-12820
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.1.0.Final, 4.2.3.Final, 4.3.0.Final
> Reporter: nathan dennis
> Assignee: Pavol Pitonak
> Labels: rich:autocomplete
>
> if the parameter layout="table" is passed, the component behaves with undocumented features.
> When typing in the input a selection list is displayed. Mouse over the selection list and the wrong selection is displayed in the input.
> This problem can be recreated in the show case by simply added the layout=”table” parameter to and existing autocomplete component.
> Though in the showcase there is limited selections, if a larger listed is added you can see that the first highlighted row maps to the correct selection +1... the second highlighted row maps to the correct selection to +2 ..etc.. so it appears there is an iterator off somewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (RF-12682) extendedDataTable render issue with rich:tabPanel
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12682?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12682:
-------------------------------
Labels: extendedDataTable render richfaces tabpanel testcase_provided (was: extendedDataTable render richfaces tabpanel)
> extendedDataTable render issue with rich:tabPanel
> -------------------------------------------------
>
> Key: RF-12682
> URL: https://issues.jboss.org/browse/RF-12682
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.2.3.Final, 4.3.0.M3, 4.3.0.CR1, 4.3.0.Final
> Reporter: Kaveh A.
> Labels: extendedDataTable, render, richfaces, tabpanel, testcase_provided
> Fix For: 5-Tracking
>
> Attachments: richfacesBug2.zip, RichFacesBugEclipseProject.zip
>
>
> This issue is not just specific to tabPanel. Anytime the extendedDataTable is hidden (when the page loads) and then it is made visible later the table can not display the data (table is empty at the load time).
> In this particular case if we load a page with two tabs. Furthermore if we have one extendedDataTable in each tab (the first tab shows and the second tab is not shown at first). In this case once the user clicks on the second tab and tries to populate the extendedDataTable (via any action). Then the table is not rendered properly. A sample project has been provided at the following link that further describe this issue. You can download the eclipse project attached at the end of the following message to reproduce this issue.
> https://community.jboss.org/message/783787
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months