[JBoss JIRA] (RF-12698) Rename CDK and Resources plugins to comply conventions: maven-cdk-plugin -> richfaces-cdk-maven-plugin
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12698?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč reassigned RF-12698:
-------------------------------
Assignee: Lukáš Fryč
> Rename CDK and Resources plugins to comply conventions: maven-cdk-plugin -> richfaces-cdk-maven-plugin
> ------------------------------------------------------------------------------------------------------
>
> Key: RF-12698
> URL: https://issues.jboss.org/browse/RF-12698
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Affects Versions: 4.3.0.CR1
> Reporter: Lukáš Fryč
> Assignee: Lukáš Fryč
> Fix For: 5.0.0.Alpha1
>
> Original Estimate: 30 minutes
> Remaining Estimate: 30 minutes
>
> During CDK build, following warning appears:
> {code}
> [INFO] ------------------------------------------------------------------------
> [INFO] Building RichFaces CDK: Resources Maven Plugin 4.3.0-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ maven-richfaces-resources-plugin ---
> [INFO] Deleting /mnt/workspace/workspaces/richfaces/cdk/maven-resources-plugin/target
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java-version) @ maven-richfaces-resources-plugin ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-maven-version) @ maven-richfaces-resources-plugin ---
> [INFO]
> [INFO] --- maven-plugin-plugin:2.9:descriptor (default-descriptor) @ maven-richfaces-resources-plugin ---
> [ERROR]
> Artifact Ids of the format maven-___-plugin are reserved for
> plugins in the Group Id org.apache.maven.plugins
> Please change your artifactId to the format ___-maven-plugin
> In the future this error will break the build.
> ....
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 10 months
[JBoss JIRA] (RF-12874) Cyclic dependencies in RF5 build
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-12874?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak closed RF-12874.
------------------------------
> Cyclic dependencies in RF5 build
> --------------------------------
>
> Key: RF-12874
> URL: https://issues.jboss.org/browse/RF-12874
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 5.0.0.Alpha1
> Reporter: Pavol Pitonak
> Assignee: Lukáš Fryč
> Priority: Blocker
> Fix For: 5.0.0.Alpha1
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1. git clone git://github.com/richfaces/richfaces5.git
> 2. mvn clean verify -D integration=jbossas
> result:
> {quote}
> [INFO] Scanning for projects...
> [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex\{label='org.richfaces:richfaces-parent:5.0.0-SNAPSHOT'\}' and 'Vertex\{label='org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT'\}' introduces to cycle in the graph org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT --> org.richfaces:richfaces-parent:5.0.0-SNAPSHOT --> org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectCycleException
> {quote}
> This is what we agreed on community meeting on 26 Mar 2013:
> {quote}
> #agreed The simplest resolution to the cyclic dep is to make richfaces-build-resources parent-less
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 10 months
[JBoss JIRA] (RF-12831) <rich:validator/> performs ajax validation without updating underlying model field
by Kamil Roman (JIRA)
[ https://issues.jboss.org/browse/RF-12831?page=com.atlassian.jira.plugin.s... ]
Kamil Roman resolved RF-12831.
------------------------------
Labels: (was: waiting_on_user)
Resolution: Rejected
I have rechecked the JSF spec and it seems you are right. During my testing I encountered an issue that without <rich:validator/> this worked differently. But as I retested it today I could not reproduce this, so I was probably doing something wrong. I am changing the status to Resolved - Rejected. Sorry for taking your time.
> <rich:validator/> performs ajax validation without updating underlying model field
> ----------------------------------------------------------------------------------
>
> Key: RF-12831
> URL: https://issues.jboss.org/browse/RF-12831
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.0.Final
> Environment: JBoss eap 6.0.0, Win 7
> Reporter: Kamil Roman
> Assignee: Juraj Húska
> Priority: Minor
> Attachments: rf-12831.zip
>
>
> Not sure if it's a bug or a feature, but field annotated with {code}<rich:validator/>{code} with a validation method set with {code}validator{code} attribute gets validated without updating the underlying model field. My code is something like this:
> {code:title=Model.java}
> public class Model {
> //...
> public Date getValidFrom() {/*...*/}
> public Date getValidTo() {/*...*/}
> }
> {code}
> {code:title=ModelValidator.java}
> public class ModelValidator{
> private Model model;
> public boolean isValidToAfterValidFrom() {
> return model.getValidTo().after(model.getValidFrom());
> }
> }
> {code}
> {code:title=model_form.xml}
> <c:set var="model" value="#{ModelBean.model}"/>
> <h:outputLabel value="#{labels.getLabel('valid_from')}" for="validFrom" />
> <rich:calendar value="#{model.validFrom}" id="validFrom" >
> <rich:validator/>
> </rich:calendar>
> <rich:message for="validFrom"/>
>
> <h:outputLabel value="#{labels.getLabel('valid_to')}" for="validTo" />
> <rich:calendar value="#{model.validTo}" id="validTo" validator="#{modelBean.validateValidTo}">
> <rich:validator event="inputblur"/>
> </rich:calendar>
> <rich:message for="validTo"/>
> {code}
> {code:title=ModelBean.java}
> public class ModelBean {
> public Model getModel() {/*..*/}
> private ModelValidator validator;
> //...
> public validateValidTo(FacesContext context, UIComponent toValidate, Object value) {
> if(!validator.isValidToAfterValidFrom()) {
> FacesMessage message = new FacesMessage(FacesMessage.SEVERITY_ERROR, labelBean.getLabel("valid.to.not.after.valid.from.error"), null);
> throw new ValidatorException(message);
> }
> }
> {code}
> The getModel() method returns the same Model instance as is used by the ModelValidator in ModelBean.
> Now, the testcase is:
> 1. User selects validTo earlier than ValidFrom (on a valid Model instance)
> 2. Validation passes as the underlying model value is not updated (validator refers to the same Model instance as ModelBean)
> 3. User submits the form.
> 4. System displays error message as server-side validation on submit is performed after applying request values.
> 5. User corrects the value in validTo field.
> 6. System still displays error message as validation fails, because the new value is not applied to the model (model holds the invalid value applied during failed submit).
> If this is not a bug, but a feature, it would be great if you included this behaviour in the docs!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 10 months