[JBoss JIRA] (RF-13162) Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13162?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13162:
---------------------------------
Since not all components use {{<default-behavior />}}, I would drop it as you suggested in option 1).
We can leave CDK's support, but do not use it ATM.
> Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
> -----------------------------------------------------------------------------------------------------
>
> Key: RF-13162
> URL: https://issues.jboss.org/browse/RF-13162
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
>
> Consider the xml component property definition:
> {code:title=From command-button-props.xml}
> <property>
> <description>
> Javascript code executed when a pointer button is clicked over this element.
> </description>
> <display-name>Button Click Script</display-name>
> <icon />
> <property-name>onclick</property-name>
> <property-class>java.lang.String</property-class>
> <property-extension>
> <cdk:pass-through>false</cdk:pass-through>
> <cdk:event-name default="true">click</cdk:event-name>
> <cdk:event-name>action</cdk:event-name>
> <default-behavior>true</default-behavior>
> </property-extension>
> </property>
> {code}
> There is currently no way to define this using the CDK @Attribute annotation - the _<default-behavior>_ annotation property is absent.
> To resolve this issue (blocking RF-12952) we need to add support for specifying the _default-behavior_ to the @Attribute annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13162) Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13162?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13162:
------------------------------------
We have 2 options moving forward:
1) Drop support for the <default-behavior> element from the RichFaces CDK
2) Modify the RichFaces CDK faces-config generator to output the correct <behavior> and <default-behavior> elements when the CDK attribute model's default event property is set.
I'm leaning towards 1), but I'm reluctant to "lose" information in the process. However the number of components that currently use the <default-behavior> element in their faces-config property definitions is vanishingly small, so we could easily track adding the information in a long-lived jira task; to be implemented should the need arise.
[~lfryc] WDYT?
> Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
> -----------------------------------------------------------------------------------------------------
>
> Key: RF-13162
> URL: https://issues.jboss.org/browse/RF-13162
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
>
> Consider the xml component property definition:
> {code:title=From command-button-props.xml}
> <property>
> <description>
> Javascript code executed when a pointer button is clicked over this element.
> </description>
> <display-name>Button Click Script</display-name>
> <icon />
> <property-name>onclick</property-name>
> <property-class>java.lang.String</property-class>
> <property-extension>
> <cdk:pass-through>false</cdk:pass-through>
> <cdk:event-name default="true">click</cdk:event-name>
> <cdk:event-name>action</cdk:event-name>
> <default-behavior>true</default-behavior>
> </property-extension>
> </property>
> {code}
> There is currently no way to define this using the CDK @Attribute annotation - the _<default-behavior>_ annotation property is absent.
> To resolve this issue (blocking RF-12952) we need to add support for specifying the _default-behavior_ to the @Attribute annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13166?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13166:
------------------------------------
RichFaces development has moved on to RichFaces 4, and more recently RichFaces 5. There are no additional planned releases of RichFaces 3.
> rich:suggestionbox nothingLabel overrides typed contents on first load
> ----------------------------------------------------------------------
>
> Key: RF-13166
> URL: https://issues.jboss.org/browse/RF-13166
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 3.3.3.Final
> Environment: IE Explorer 8, Windows 7 Machine
> Reporter: Trever Hickey
> Fix For: 3.Future
>
>
> Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
> Instead I don't want it to have the nothingLabel overwrite what's in the text box.
> However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
> This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13166?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13166:
-------------------------------
Fix Version/s: 3.Future
> rich:suggestionbox nothingLabel overrides typed contents on first load
> ----------------------------------------------------------------------
>
> Key: RF-13166
> URL: https://issues.jboss.org/browse/RF-13166
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 3.3.3.Final
> Environment: IE Explorer 8, Windows 7 Machine
> Reporter: Trever Hickey
> Fix For: 3.Future
>
>
> Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
> Instead I don't want it to have the nothingLabel overwrite what's in the text box.
> However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
> This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13166?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13166:
-------------------------------
Affects Version/s: 3.3.3.Final
(was: 4.3.3)
> rich:suggestionbox nothingLabel overrides typed contents on first load
> ----------------------------------------------------------------------
>
> Key: RF-13166
> URL: https://issues.jboss.org/browse/RF-13166
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 3.3.3.Final
> Environment: IE Explorer 8, Windows 7 Machine
> Reporter: Trever Hickey
>
> Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
> Instead I don't want it to have the nothingLabel overwrite what's in the text box.
> However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
> This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13162) Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13162?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13162:
------------------------------------
According to [~akazakov] from the JBoss Tools team, they do not use the <default-behavior> element, so we can safely remove it without affecting JBoss Tools / JBoss Developer Studio.
> Add support for the default-behavior faces-config property-extension to the CDK @Attribute annotation
> -----------------------------------------------------------------------------------------------------
>
> Key: RF-13162
> URL: https://issues.jboss.org/browse/RF-13162
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
>
> Consider the xml component property definition:
> {code:title=From command-button-props.xml}
> <property>
> <description>
> Javascript code executed when a pointer button is clicked over this element.
> </description>
> <display-name>Button Click Script</display-name>
> <icon />
> <property-name>onclick</property-name>
> <property-class>java.lang.String</property-class>
> <property-extension>
> <cdk:pass-through>false</cdk:pass-through>
> <cdk:event-name default="true">click</cdk:event-name>
> <cdk:event-name>action</cdk:event-name>
> <default-behavior>true</default-behavior>
> </property-extension>
> </property>
> {code}
> There is currently no way to define this using the CDK @Attribute annotation - the _<default-behavior>_ annotation property is absent.
> To resolve this issue (blocking RF-12952) we need to add support for specifying the _default-behavior_ to the @Attribute annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Trever Hickey (JIRA)
[ https://issues.jboss.org/browse/RF-13166?page=com.atlassian.jira.plugin.s... ]
Trever Hickey commented on RF-13166:
------------------------------------
Oh. Didn't know rich:suggestionBox was depracated. I guess I then want it in the 3.3.3 build if that is the current public release.
> rich:suggestionbox nothingLabel overrides typed contents on first load
> ----------------------------------------------------------------------
>
> Key: RF-13166
> URL: https://issues.jboss.org/browse/RF-13166
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 4.3.3
> Environment: IE Explorer 8, Windows 7 Machine
> Reporter: Trever Hickey
>
> Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
> Instead I don't want it to have the nothingLabel overwrite what's in the text box.
> However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
> This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13166?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13166:
------------------------------------
There is no _rich:suggestionBox_ in RichFaces 4.3.3. Do you mean _rich:autocomplete_? Or are you talking about RichFaces 3.3.3.Final?
> rich:suggestionbox nothingLabel overrides typed contents on first load
> ----------------------------------------------------------------------
>
> Key: RF-13166
> URL: https://issues.jboss.org/browse/RF-13166
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 4.3.3
> Environment: IE Explorer 8, Windows 7 Machine
> Reporter: Trever Hickey
>
> Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
> Instead I don't want it to have the nothingLabel overwrite what's in the text box.
> However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
> This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13166) rich:suggestionbox nothingLabel overrides typed contents on first load
by Trever Hickey (JIRA)
Trever Hickey created RF-13166:
----------------------------------
Summary: rich:suggestionbox nothingLabel overrides typed contents on first load
Key: RF-13166
URL: https://issues.jboss.org/browse/RF-13166
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: base functionality
Affects Versions: 4.3.3
Environment: IE Explorer 8, Windows 7 Machine
Reporter: Trever Hickey
Hi, I was having trouble using the rich:suggestionBox and found that it was using the nothingLabel feature inconsistently. It seems that "nothingLabel" overrides the contents if the search doesn't return results and I press the "Enter" key.
Instead I don't want it to have the nothingLabel overwrite what's in the text box.
However, it only does this once and any subsequent "Enter" presses when I put in a field that doesn't return results doesn't cause the nothingLabel to override the field. The only way the override returns is when I completely reset the page the search is on.
This seems like an inconsistent use of nothingLabel and was trying to figure out how to make its use consistent on all "Enter" presses.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (RF-13165) The rowclick event of the rich:dataTable is not recognized as a valid server-side event during an ajax postback
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13165?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13165:
-------------------------------
Reporter: Fab Mars (was: Brian Leathem)
> The rowclick event of the rich:dataTable is not recognized as a valid server-side event during an ajax postback
> ---------------------------------------------------------------------------------------------------------------
>
> Key: RF-13165
> URL: https://issues.jboss.org/browse/RF-13165
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Reporter: Fab Mars
> Fix For: 5-Tracking
>
>
> An embedded _<a4j:ajax>_ tag in an extendedDataTable with the event rowclick_ does not work. The relevant code snippet:
> {code}
> <a4j:ajax event="rowclick" render="shippingEditForm" listener="#{shippingEdit.setId(shipping.id)}"/>
> {code}
> This *should* work. A google search quickly shows one how many people expect it to work. I dug in to find out why it doesn't work:
> When a HTML element triggers an ajax event, a check is performed on the server-side to see if the HTML element that triggered the event is the JSF component that is being decoded. This is done in this line of code:
> https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> {code}
> if (behaviorSource != null && behaviorSource.equals(clientId)) {
> ...
> {code}
> Before the request is sent to the server, we check if the originating element of an event is from a component, and "re-target" it if not (see:RF-12616, RF-12715). This is done in these lines of code:
> https://github.com/richfaces/richfaces/blob/master/framework/src/main/res...
> {code}
> if (this.id && sourceElement.id.indexOf(this.id) == 0) { // otherwise parent element is definitely not JSF component
> var suffix = sourceElement.id.substring(this.id.length); // extract suffix
> if (suffix.match(/^[a-zA-Z]*$/) && isRichFacesComponent(this)) {
> parentElement = this;
> return false;
> }
> }
> {code}
> This re-targeting works well, as for the most part elements DOM ids within components use the _#\{clientId}Qualifier_ syntax. However this breaks down with table rows, where the ":" separator is used. This is the same separator used to separate JSF component id's in the _clientId_. For example, a table with the _clilentId_ "_form:edt_" will have rows with DOM id "_myForm:edt:5:n_".
> So we need to fix the client-side re-targeting to work for table rows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months