[JBoss JIRA] (RF-13481) Upgrade to Warp 1.0.0.Alpha6
by Lukáš Fryč (JIRA)
Lukáš Fryč created RF-13481:
-------------------------------
Summary: Upgrade to Warp 1.0.0.Alpha6
Key: RF-13481
URL: https://issues.jboss.org/browse/RF-13481
Project: RichFaces
Issue Type: Component Upgrade
Security Level: Public (Everyone can see)
Components: tests - functional
Affects Versions: 5.0.0.Alpha2
Reporter: Lukáš Fryč
Assignee: Lukáš Fryč
Fix For: 5.0.0.Alpha3
It seems Warp Alpha6 doesn't suffer from intermittent test issues as much as Alpha5 did (or it can recover).
My impression comes from running whole test suite without getting stuck on EAP 6.1 and WildFly CR1.
I will bump to snapshot and we will release as necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13306) Autocomplete: initialize value from DOM (was: ignored API call .setValue(''))
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RF-13306?page=com.atlassian.jira.plugin.s... ]
Jiří Štefek closed RF-13306.
----------------------------
verified, closing
> Autocomplete: initialize value from DOM (was: ignored API call .setValue(''))
> -----------------------------------------------------------------------------
>
> Key: RF-13306
> URL: https://issues.jboss.org/browse/RF-13306
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.4
> Reporter: alexey plotnikov
> Assignee: alexey plotnikov
> Fix For: 4.3.5
>
> Original Estimate: 30 minutes
> Remaining Estimate: 30 minutes
>
> All described here https://community.jboss.org/thread/233973
> I have this autocomplete component:
> {code}
> <table>
> <tr>
> <td>
> <rich:autocomplete mode="ajax" autocompleteMethod="#{autocomplete.autocompleteProviders}"
> minChars="0" var="s" fetchValue="#{s.realName}" id="provider-suggestion"
> autofill="false"
> onselectitem="autocompleteChangeProvider(event.target)" style="display: inline;"
> layout="table" value="#{autocomplete.providerName}" >
> <a4j:queue requestDelay="500" ignoreDupResponses="true" />
> <h:column>
> <h:outputText style="display:none;" value="#{s.id}"/>
> <h:outputText style="display:none;" value="#{s.realName}"/>
> </h:column>
> <h:column>
> <h:outputText value="#{s.name}" escape="false"/>
> </h:column>
> </rich:autocomplete>
> </td>
> <td>
> <h:graphicImage value="/img/arrow.png" onclick="#{rich:component('provider-suggestion')}.setValue('');#{rich:component('provider-suggestion')}.showPopup();stopEvent(event);"
> alt=""/>
> <h:graphicImage value="/img/cancel.png"
> onclick="#{rich:component('provider-suggestion')}.hidePopup();#{rich:component('provider-suggestion')}.setValue('');autocompleteChangeProvider(null);"
> alt="#{messages['pages.clear']}" title="#{messages['pages.clear']}"/>
> <h:inputHidden id="filter-provider-id" value="#{autocomplete.providerId}"/>
> </td>
> </tr>
> </table>
> {code}
> as you can see, i don't use showButton="true", because i need another functionality, i need erase input text before show popup window.
> I use JavaScript function "autocompleteChangeProvider" for extract selected id.
> I use separate button(/img/cancel.png) for erase input text, as you can see this function just use Richfaces API.
>
> And a problem:
> if autocomplete.providerName not null and not empty(in rich:autocomplete) and user clicks on show button(/img/arrow.png) than input text not erasing, but i called #{rich:component('provider-suggestion')}.setValue('') !!!
>
> I think i found a solution
> AutocompleteBase.js has this code:
> {code}
> rf.ui.AutocompleteBase = function(componentId, selectId, fieldId, options) {
> // call constructor of parent class
> $super.constructor.call(this, componentId);
> this.selectId = selectId;
> this.fieldId = fieldId;
> this.options = $.extend({}, defaultOptions, options);
> this.namespace = this.namespace || "." + rf.Event.createNamespace(this.name, this.selectId);
> this.currentValue = "";
> this.tempValue = this.getValue();
> this.isChanged = this.tempValue.length != 0;
> bindEventHandlers.call(this);
> };
> {code}
> as you can see this.currentValue = "" so JS thinks that this.currentValue="" so currentValue equal new value("" - empty string), so nothing happens.
> i replace this code by this:
> {code}
> rf.ui.AutocompleteBase = function(componentId, selectId, fieldId, options) {
> // call constructor of parent class
> $super.constructor.call(this, componentId);
> this.selectId = selectId;
> this.fieldId = fieldId;
> this.options = $.extend({}, defaultOptions, options);
> this.namespace = this.namespace || "." + rf.Event.createNamespace(this.name, this.selectId);
> this.currentValue = $(rf.getDomElement(fieldId)).val();
> this.tempValue = this.getValue();
> this.isChanged = this.tempValue.length != 0;
> bindEventHandlers.call(this);
> };
> {code}
> and it works!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13305) Autocomplete: i must press button twice for popup window
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RF-13305?page=com.atlassian.jira.plugin.s... ]
Jiří Štefek closed RF-13305.
----------------------------
verified closing
> Autocomplete: i must press button twice for popup window
> --------------------------------------------------------
>
> Key: RF-13305
> URL: https://issues.jboss.org/browse/RF-13305
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.4
> Reporter: alexey plotnikov
> Assignee: alexey plotnikov
> Fix For: 4.3.5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> All described here https://community.jboss.org/thread/233971
> I try repeat:
> I have this autocomplete component:
> {code}
> <table>
> <tr>
> <td>
> <rich:autocomplete mode="ajax" autocompleteMethod="#{autocomplete.autocompleteProviders}"
> minChars="0" var="s" fetchValue="#{s.realName}" id="provider-suggestion"
> autofill="false"
> onselectitem="autocompleteChangeProvider(event.target)" style="display: inline;"
> layout="table" value="#{autocomplete.providerName}" >
> <a4j:queue requestDelay="500" ignoreDupResponses="true" />
> <h:column>
> <h:outputText style="display:none;" value="#{s.id}"/>
> <h:outputText style="display:none;" value="#{s.realName}"/>
> </h:column>
> <h:column>
> <h:outputText value="#{s.name}" escape="false"/>
> </h:column>
> </rich:autocomplete>
> </td>
> <td>
> <h:graphicImage value="/img/arrow.png" onclick="#{rich:component('provider-suggestion')}.setValue('');#{rich:component('provider-suggestion')}.showPopup();stopEvent(event);"
> alt=""/>
> <h:graphicImage value="/img/cancel.png"
> onclick="#{rich:component('provider-suggestion')}.hidePopup();#{rich:component('provider-suggestion')}.setValue('');autocompleteChangeProvider(null);"
> alt="#{messages['pages.clear']}" title="#{messages['pages.clear']}"/>
> <h:inputHidden id="filter-provider-id" value="#{autocomplete.providerId}"/>
> </td>
> </tr>
> </table>
> {code}
> as you can see, i don't use showButton="true", because i need another functionality, i need erase input text before show popup window.
> I use JavaScript function "autocompleteChangeProvider" for extract selected id.
> I use separate button(/img/cancel.png) for erase input text, as you can see this function just use Richfaces API.
>
> And problem:
> if autocomplete.providerName not null and not empty(in rich:autocomplete) and user clicks on cancel button(img/cancel.png), then after that, if user clicks on show button(/img/arrow.png) popup not showing, user must clicks twice on this button.
> *This problem shows if i use showButton from rich:autocomplete instead my show button.*
> I think i found a solution of this problem:
> Autocomplete.js has this code:
> {code}
> var onChangeValue = function (event, value, callback) {
> selectItem.call(this, event);
>
> // value is undefined if called from AutocompleteBase onChange
> var subValue = (typeof value == "undefined") ? this.__getSubValue() : value;
> var oldValue = this.value;
> this.value = subValue;
>
> if ((this.options.isCachedAjax || !this.options.ajaxMode) &&
> this.cache && this.cache.isCached(subValue)) {
> ...
> } else {
> if (event.keyCode == rf.KEYS.RETURN || event.type == "click") {
> this.__setInputValue(subValue);
> }
> if (subValue.length >= this.options.minChars) {
> if ((this.options.ajaxMode || this.options.lazyClientMode) && oldValue != subValue) {
> callAjax.call(this, event, callback);
> }
> } else {
> if (this.options.ajaxMode) {
> clearItems.call(this);
> this.__hide(event);
> }
> }
> }
> };
> {code}
> for show popup this must be true:
> {code}
> oldValue != subValue
> {code}
> but in this part of code
> oldValue is ''(empty string) and subValue is ''(empty string),
> so this condition
> {code}
> oldValue != subValue
> {code}
> return false!
>
> i replace this code by this:
> {code}
> var onChangeValue = function (event, value, callback) {
> selectItem.call(this, event);
>
> // value is undefined if called from AutocompleteBase onChange
> var subValue = (typeof value == "undefined") ? this.__getSubValue() : value;
> var oldValue = this.value;
> this.value = subValue;
>
> if ((this.options.isCachedAjax || !this.options.ajaxMode) &&
> this.cache && this.cache.isCached(subValue)) {
> ...
> } else {
> if (event.keyCode == rf.KEYS.RETURN || event.type == "click") {
> this.__setInputValue(subValue);
> }
> if (subValue.length >= this.options.minChars) {
> if ((this.options.ajaxMode || this.options.lazyClientMode) && (oldValue != subValue || (oldValue === '' && subValue === ''))) {
> callAjax.call(this, event, callback);
> }
> } else {
> if (this.options.ajaxMode) {
> clearItems.call(this);
> this.__hide(event);
> }
> }
> }
>
> };
> {code}
> so, than oldValue='' and subValue=='' callAjax.call will be called and popup will be showing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13266) mediaOutput not working anymore on Glassfish3 and EAP6.1
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-13266?page=com.atlassian.jira.plugin.s... ]
Juraj Húska closed RF-13266.
----------------------------
Verified. Closing.
> mediaOutput not working anymore on Glassfish3 and EAP6.1
> --------------------------------------------------------
>
> Key: RF-13266
> URL: https://issues.jboss.org/browse/RF-13266
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.4
> Environment: Glassfish 3.1.2.2 patched with Weld 1.1.14 (the problem appears also on earlier Weld builds) and JSF 2.1.26 and JDK 1.7.0_45
> Reporter: Fab Mars
> Assignee: Brian Leathem
> Labels: regression
> Fix For: 4.3.5
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> This is a followup to https://issues.jboss.org/browse/RF-13098 focusing on Glassfish3.
> I have 2 mediaOutput in my code, none works.
> The first one passes a Long as the value to the createContent method and the expected output is a PDF. I get
> SEVERE: Input error for deserialize data java.io.InvalidClassException: Unauthorized deserialization attempt; org.jboss.weld.util.el.ForwardingMethodExpression
> The second one passes an array of 3 bytes (a color code) and the expected result is an image. I get
> SEVERE: Input error for deserialize data java.io.InvalidClassException: Unauthorized deserialization attempt; [B
> I'm preparing a reproducer on github and will share the url in the next comment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13480) Java Package re-structuring
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13480?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13480:
-------------------------------
Summary: Java Package re-structuring (was: Rename the _bean_ package to something more meaningful)
Original Estimate: 2 hours
Remaining Estimate: 2 hours
Description:
This issue addresses the cleanup of the java package namespace of the demo.
1) The package _org.richfaces.photoalbum.bean_ contains the single class _UserBean_. Let's rename the package to something less generic like _user_ or consider merging it into another pre-existing package like _ui_.
2) The _event_ package is separate from the _domain_ package. Let's consider moving the _event_ package to be a sub-package of _domain_. While we are at it, I find the package name _model_ to be more descriptive than _domain_.
3) The _services_ package may be better described as an _actions_ package.
4) The _util_ package is too generic. Consider creating _converters_ and _validators_ packages to hold the bulk of these classes. Additionally the classnames _*Stuff_ and _Utils_ could be named less generically.
5) having the two top-level classes _search_ and _ejbsearch_ is confusing. Can one package be a sub-folder of the other? Alternatively could one be in the _ui_ folder, or the other in a _model_ folder?
was:The package _org.richfaces.photoalbum.bean_ contains the single class _UserBean_. Let's rename the package to something less generic like _user_ or consider merging it into another pre-existing package like _ui_.
> Java Package re-structuring
> ---------------------------
>
> Key: RF-13480
> URL: https://issues.jboss.org/browse/RF-13480
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: examples
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Labels: photoalbum
> Fix For: 4.3.5
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> This issue addresses the cleanup of the java package namespace of the demo.
> 1) The package _org.richfaces.photoalbum.bean_ contains the single class _UserBean_. Let's rename the package to something less generic like _user_ or consider merging it into another pre-existing package like _ui_.
> 2) The _event_ package is separate from the _domain_ package. Let's consider moving the _event_ package to be a sub-package of _domain_. While we are at it, I find the package name _model_ to be more descriptive than _domain_.
> 3) The _services_ package may be better described as an _actions_ package.
> 4) The _util_ package is too generic. Consider creating _converters_ and _validators_ packages to hold the bulk of these classes. Additionally the classnames _*Stuff_ and _Utils_ could be named less generically.
> 5) having the two top-level classes _search_ and _ejbsearch_ is confusing. Can one package be a sub-folder of the other? Alternatively could one be in the _ui_ folder, or the other in a _model_ folder?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13480) Rename the _bean_ package to something more meaningful
by Brian Leathem (JIRA)
Brian Leathem created RF-13480:
----------------------------------
Summary: Rename the _bean_ package to something more meaningful
Key: RF-13480
URL: https://issues.jboss.org/browse/RF-13480
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: examples
Reporter: Brian Leathem
Assignee: Michal Petrov
Fix For: 4.3.5
The package _org.richfaces.photoalbum.bean_ contains the single class _UserBean_. Let's rename the package to something less generic like _user_ or consider merging it into another pre-existing package like _ui_.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13479) Re-organize files/folders in the top-level webapp folder
by Brian Leathem (JIRA)
Brian Leathem created RF-13479:
----------------------------------
Summary: Re-organize files/folders in the top-level webapp folder
Key: RF-13479
URL: https://issues.jboss.org/browse/RF-13479
Project: RichFaces
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: examples
Reporter: Brian Leathem
Assignee: Michal Petrov
Fix For: 4.3.5
Let's put the _img_ and _layout_ folder as sub-folders in the resources folder.
The top-level folder _social_ holds a single one-line file _fbchannel.xhtml_. Is there somewhere else we can place this file so it doesn't unnecessarily complicate the folder structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ]
Juraj Húska closed RF-13252.
----------------------------
Verified for all versions: 4.3.5, 4.5.0.Alpha2, 5.0.0.Alpha3.
> a4j:ajax includes jsf.js script twice
> -------------------------------------
>
> Key: RF-13252
> URL: https://issues.jboss.org/browse/RF-13252
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.4
> Environment: any browser
> EAP 6.2 (Mojarra 2.1.19)
> EAP 6.1 (Mojarra 2.1.19)
> JBoss AS 7.1.1 (Mojarra 2.1.7)
> Reporter: Jonáš Trantina
> Assignee: Lukáš Fryč
> Fix For: 4.3.5, 4.5.0.Alpha2, 5.0.0.Alpha3
>
> Attachments: reproducer.zip
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When a4j:script is used in the page like so:
> {noformat}
> <h:commandLink value="Click me ">
> <a4j:ajax event="click" render="@form"/>
> </h:commandLink>
> {noformat}
> Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3].
> Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4].
> [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
> [4] https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months