[JBoss JIRA] (RF-13458) CommandLink Javassist Compatibility Failures (richfaces-5.0.0.Alpha2)
by Steven W. (JIRA)
[ https://issues.jboss.org/browse/RF-13458?page=com.atlassian.jira.plugin.s... ]
Steven W. edited comment on RF-13458 at 1/6/14 10:11 AM:
---------------------------------------------------------
I did try & experienced the same (or similar) issues with the javassist that was used with Seam and also with a 3.15.0-GA from the javassist site
Also note this is something that worked with prior RichFaces release but started happening upon upgraded to latest RichFaces release (prior to that time I believe it was using the javassist that came with Seam)
Thanks,
Steve
was (Author: entracity):
I did try & experienced the same (or similar) issues with the javassist that was used with Seam and also with a 3.15.0-GA from the javassist site.
Thanks,
Steve
> CommandLink Javassist Compatibility Failures (richfaces-5.0.0.Alpha2)
> ---------------------------------------------------------------------
>
> Key: RF-13458
> URL: https://issues.jboss.org/browse/RF-13458
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Steven W.
>
> There appear to be compatibility issues with the richfaces-5.0.0.Alpha2 release and the javassist package. Using older versions of the package lead to failures stating that new javassist methods are not available.
> When using the newer libraries (3.14 -> javassist-3.18.0-GA) exceptions are generated on the use of previously functioning command links (the corresponding methods are still the same signatures i.e. return String and take no parameters)
> {code}
> <rich:commandLink id="listByUnit" render="f_home,f_selections,g_body_wrapper"
> value="#{messages['listByUnit']}"
> title="#{messages['titleListByUnit']}"
> action="#{appController.selectCurrSelectionUnit}"/>
> {code}
> with
> {code}
> public String selectCurrSelectionUnit()
> {code}
> yields:
> {code}
> 2014-01-03 13:57:57,597 ERROR [org.jboss.seam.exception.Exceptions] - handled and logged exception
> javax.servlet.ServletException: /layout/controller-selections.xhtml: Property 'selectCurrSelectionUnit' not found on type com.integrits.bean.Controller_$$_javassist_seam_2
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:606)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:374)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:83)
> at org.jboss.seam.web.LoggingFilter.doFilter(LoggingFilter.java:60)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.IdentityFilter.doFilter(IdentityFilter.java:40)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:90)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:64)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.servlet.SeamFilter.doFilter(SeamFilter.java:158)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
> at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
> at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1008)
> at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
> at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
> at java.lang.Thread.run(Thread.java:619)
> Caused by: javax.el.ELException: /layout/controller-selections.xhtml: Property 'selectCurrSelectionUnit' not found on type com.integrits.bean.Controller_$$_javassist_seam_2
> at com.sun.faces.facelets.compiler.AttributeInstruction.write(AttributeInstruction.java:94)
> at com.sun.faces.facelets.compiler.UIInstructions.encodeBegin(UIInstructions.java:82)
> at com.sun.faces.facelets.compiler.UILeaf.encodeAll(UILeaf.java:207)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:168)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:304)
> at com.sun.faces.renderkit.html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:105)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:304)
> at com.sun.faces.renderkit.html_basic.GridRenderer.renderRow(GridRenderer.java:185)
> at com.sun.faces.renderkit.html_basic.GridRenderer.encodeChildren(GridRenderer.java:129)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1819)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1822)
> at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:447)
> at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:125)
> at org.jboss.seam.jsf.SeamViewHandler.renderView(SeamViewHandler.java:188)
> at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:286)
> at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:120)
> at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
> at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594)
> ... 33 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13458) CommandLink Javassist Compatibility Failures (richfaces-5.0.0.Alpha2)
by Steven W. (JIRA)
[ https://issues.jboss.org/browse/RF-13458?page=com.atlassian.jira.plugin.s... ]
Steven W. commented on RF-13458:
--------------------------------
I did try & experienced the same (or similar) issues with the javassist that was used with Seam and also with a 3.15.0-GA from the javassist site.
Thanks,
Steve
> CommandLink Javassist Compatibility Failures (richfaces-5.0.0.Alpha2)
> ---------------------------------------------------------------------
>
> Key: RF-13458
> URL: https://issues.jboss.org/browse/RF-13458
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Steven W.
>
> There appear to be compatibility issues with the richfaces-5.0.0.Alpha2 release and the javassist package. Using older versions of the package lead to failures stating that new javassist methods are not available.
> When using the newer libraries (3.14 -> javassist-3.18.0-GA) exceptions are generated on the use of previously functioning command links (the corresponding methods are still the same signatures i.e. return String and take no parameters)
> {code}
> <rich:commandLink id="listByUnit" render="f_home,f_selections,g_body_wrapper"
> value="#{messages['listByUnit']}"
> title="#{messages['titleListByUnit']}"
> action="#{appController.selectCurrSelectionUnit}"/>
> {code}
> with
> {code}
> public String selectCurrSelectionUnit()
> {code}
> yields:
> {code}
> 2014-01-03 13:57:57,597 ERROR [org.jboss.seam.exception.Exceptions] - handled and logged exception
> javax.servlet.ServletException: /layout/controller-selections.xhtml: Property 'selectCurrSelectionUnit' not found on type com.integrits.bean.Controller_$$_javassist_seam_2
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:606)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:374)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:83)
> at org.jboss.seam.web.LoggingFilter.doFilter(LoggingFilter.java:60)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.IdentityFilter.doFilter(IdentityFilter.java:40)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:90)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:64)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
> at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.servlet.SeamFilter.doFilter(SeamFilter.java:158)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
> at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
> at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1008)
> at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
> at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
> at java.lang.Thread.run(Thread.java:619)
> Caused by: javax.el.ELException: /layout/controller-selections.xhtml: Property 'selectCurrSelectionUnit' not found on type com.integrits.bean.Controller_$$_javassist_seam_2
> at com.sun.faces.facelets.compiler.AttributeInstruction.write(AttributeInstruction.java:94)
> at com.sun.faces.facelets.compiler.UIInstructions.encodeBegin(UIInstructions.java:82)
> at com.sun.faces.facelets.compiler.UILeaf.encodeAll(UILeaf.java:207)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:168)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:304)
> at com.sun.faces.renderkit.html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:105)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:304)
> at com.sun.faces.renderkit.html_basic.GridRenderer.renderRow(GridRenderer.java:185)
> at com.sun.faces.renderkit.html_basic.GridRenderer.encodeChildren(GridRenderer.java:129)
> at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:847)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1819)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1822)
> at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:447)
> at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:125)
> at org.jboss.seam.jsf.SeamViewHandler.renderView(SeamViewHandler.java:188)
> at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:286)
> at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:120)
> at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
> at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594)
> ... 33 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13252 at 1/6/14 8:51 AM:
---------------------------------------------------------
For marking the resource as renderer, we would need to hard-code an flag to satisfy the condition put by Mojarra:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above and verified it fixed initial rendering,
the {{<script>}} is then still rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context on post-back.
was (Author: lfryc):
For marking the resource as renderer, we would need to hard-code an flag to satisfy the condition put by Mojarra:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
> a4j:ajax includes jsf.js script twice
> -------------------------------------
>
> Key: RF-13252
> URL: https://issues.jboss.org/browse/RF-13252
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.4
> Environment: any browser
> EAP 6.2 (Mojarra 2.1.19)
> EAP 6.1 (Mojarra 2.1.19)
> JBoss AS 7.1.1 (Mojarra 2.1.7)
> Reporter: Jonáš Trantina
> Assignee: Lukáš Fryč
> Fix For: 4.3.5
>
> Attachments: reproducer.zip
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When a4j:script is used in the page like so:
> {noformat}
> <h:commandLink value="Click me ">
> <a4j:ajax event="click" render="@form"/>
> </h:commandLink>
> {noformat}
> Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3].
> Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4].
> [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
> [4] https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13252:
---------------------------------
For marking the resource as renderer, we would need to hard-code an flag such as:
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
> a4j:ajax includes jsf.js script twice
> -------------------------------------
>
> Key: RF-13252
> URL: https://issues.jboss.org/browse/RF-13252
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.4
> Environment: any browser
> EAP 6.2 (Mojarra 2.1.19)
> EAP 6.1 (Mojarra 2.1.19)
> JBoss AS 7.1.1 (Mojarra 2.1.7)
> Reporter: Jonáš Trantina
> Assignee: Lukáš Fryč
> Fix For: 4.3.5
>
> Attachments: reproducer.zip
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When a4j:script is used in the page like so:
> {noformat}
> <h:commandLink value="Click me ">
> <a4j:ajax event="click" render="@form"/>
> </h:commandLink>
> {noformat}
> Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3].
> Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4].
> [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
> [4] https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13252 at 1/6/14 8:50 AM:
---------------------------------------------------------
For marking the resource as renderer, we would need to hard-code an flag such as to satisfy the condition put by Mojarra:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
was (Author: lfryc):
For marking the resource as renderer, we would need to hard-code an flag such as:
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
> a4j:ajax includes jsf.js script twice
> -------------------------------------
>
> Key: RF-13252
> URL: https://issues.jboss.org/browse/RF-13252
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.4
> Environment: any browser
> EAP 6.2 (Mojarra 2.1.19)
> EAP 6.1 (Mojarra 2.1.19)
> JBoss AS 7.1.1 (Mojarra 2.1.7)
> Reporter: Jonáš Trantina
> Assignee: Lukáš Fryč
> Fix For: 4.3.5
>
> Attachments: reproducer.zip
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When a4j:script is used in the page like so:
> {noformat}
> <h:commandLink value="Click me ">
> <a4j:ajax event="click" render="@form"/>
> </h:commandLink>
> {noformat}
> Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3].
> Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4].
> [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
> [4] https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13252 at 1/6/14 8:51 AM:
---------------------------------------------------------
For marking the resource as renderer, we would need to hard-code an flag to satisfy the condition put by Mojarra:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
was (Author: lfryc):
For marking the resource as renderer, we would need to hard-code an flag such as to satisfy the condition put by Mojarra:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
{code}
public class ResourceTrackerForMojarra implements ResourceTracker {
...
@Override
public void markResourceRendered(FacesContext facesContext, ResourceKey resourceKey) {
...
if (ResourceKey.create("javax.faces:jsf.js").equals(resourceKey)) {
facesContext.getAttributes().put("com.sun.faces.SCRIPT_STATE", Boolean.TRUE);
}
}
}
{code}
The Mojarra code here is little bit inconsistent as there is another mean of flagging presense of a script:
https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j...
----
Even though I prototyped the patch suggested above, the {{<script>}} was rendered on AJAX post-back (during partial-response).
That's because the flag is missing in context.
> a4j:ajax includes jsf.js script twice
> -------------------------------------
>
> Key: RF-13252
> URL: https://issues.jboss.org/browse/RF-13252
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.4
> Environment: any browser
> EAP 6.2 (Mojarra 2.1.19)
> EAP 6.1 (Mojarra 2.1.19)
> JBoss AS 7.1.1 (Mojarra 2.1.7)
> Reporter: Jonáš Trantina
> Assignee: Lukáš Fryč
> Fix For: 4.3.5
>
> Attachments: reproducer.zip
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When a4j:script is used in the page like so:
> {noformat}
> <h:commandLink value="Click me ">
> <a4j:ajax event="click" render="@form"/>
> </h:commandLink>
> {noformat}
> Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3].
> Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4].
> [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
> [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
> [4] https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13459) Google map doesn't work because of stack overflow
by Pavol Pitonak (JIRA)
Pavol Pitonak created RF-13459:
----------------------------------
Summary: Google map doesn't work because of stack overflow
Key: RF-13459
URL: https://issues.jboss.org/browse/RF-13459
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-misc
Affects Versions: 3.3.4.Final, 3.3.1.SP3
Reporter: Pavol Pitonak
# open http://showcase-rf3.richfaces.org/richfaces/gmap.jsf?c=gmap&tab=usage in Chrome 31, IE7/8/9
result:
* map is rendered for a second but that it disappear and popup with stack overflow error is displayed
* this is in browser console:
{code}
Uncaught RangeError: Maximum call stack size exceeded %7Bmain,adsense,geometry,zombie%7D.js:11
{code}
* there are several warnings in browser console but I'm not sure if they are somehow related:
{code}
Map.disableContinuousZoom is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
Control is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
Map.addControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
ScaleControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13287) rich:extendedDataTable column resizing with ajax loading not working properly
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13287?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak commented on RF-13287:
------------------------------------
[~manovotn], please verify and remove needs-qe label if it's OK.
> rich:extendedDataTable column resizing with ajax loading not working properly
> -----------------------------------------------------------------------------
>
> Key: RF-13287
> URL: https://issues.jboss.org/browse/RF-13287
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4
> Environment: Glassfish 3.1.2.2, Mojarra 2.1.26, IE10, IE8, Chrome 30,
> Reporter: Andreas G
> Assignee: Michal Petrov
> Labels: needs-qe, testcase_provided
> Fix For: 4.3.5
>
>
> In a rich:extendedDataTable with ajax loading turned on: When you resize a column and scroll down (load data), the size of the columns reset to their original value. Only the header keeps its size. The header and the data are not matching anymore.
> Reproducible in the 4.3.4 showcase!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months
[JBoss JIRA] (RF-13358) rich:panelMenuGroup allowing actions executions even if originally disabled
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13358?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak commented on RF-13358:
------------------------------------
[~manovotn], please verify and remove needs-qe label if it's OK.
> rich:panelMenuGroup allowing actions executions even if originally disabled
> ---------------------------------------------------------------------------
>
> Key: RF-13358
> URL: https://issues.jboss.org/browse/RF-13358
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.4
> Environment: Linux, AS 7.1.1 Brontes, FF 25 with FireBug addOn
> Reporter: Pavel Slegr
> Assignee: Brian Leathem
> Priority: Critical
> Labels: needs-qe
> Fix For: 4.3.5, 4.5.0.Alpha2, 5.0.0.Alpha3
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> related to https://issues.jboss.org/browse/RF-12813
> This can be possibly a security hole, as the second component piece is discovered to allow tampering actions through JS.
> I suggest to try out on other components as well !!!
> with following example
> {code}
> {
> <rich:panelMenuGroup id="group4" label="Group 4" expanded="false">
> <rich:panelMenuItem id="item41" label="Item 4.1" />
> <rich:panelMenuItem id="item42" label="Item 4.2" disabled="true" />
> <rich:panelMenuGroup id="group43" label="Group 4.1" disabled="true">
> <rich:panelMenuItem id="item431" label="Item 4.1.1" />
> </rich:panelMenuGroup>
> </rich:panelMenuGroup>
> }
> {code}
> the group43 element is intended to be disabled and thus not allowing any actions execution on it
> Once tampered with
> {code}
> {
> new RichFaces.ui.PanelMenuGroup("f:group43",{"collapseEvent":"click","unselectable":false,"selectable":false,"name":"group43","ajax":{"incId":"1"} ,"stylePrefix":"rf\u002Dpm\u002Dgr","expanded":false,"expandEvent":"click","disabled":false,"mode":"client"} )
> }
> {code}
> It is possible to expand the group and execute further actions on its children elements
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 4 months