[JBoss JIRA] (RF-13592) a4j:push doesn't work after rendering
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13592?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-13592 at 4/29/14 7:40 PM:
-------------------------------------------------------------
I reset the _lastMessageNumber_ when the RichFaces.Push#disconnect function is invoked.
The resolves the problem in Chrome and Firefox (other browsers will bec verified by QE).
QE: please also verify the correct behaviour when multiple push components are present on a page, and they are selectively re-rendered.
was (Author: bleathem):
I rest the _lastMessageNumber_ when the RichFaces.Push#disconnect function is invoked.
The resolves the problem in Chrome and Firefox (other browsers will bec verified by QE).
QE: please also verify the correct behaviour when multiple push components are present on a page, and they are selectively re-rendered.
> a4j:push doesn't work after rendering
> -------------------------------------
>
> Key: RF-13592
> URL: https://issues.jboss.org/browse/RF-13592
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-push/poll
> Affects Versions: 4.3.5
> Environment: JBoss EAP 6.2
> Browser: Chrome 33.0.1750.154 and IE 8.0.7601.17514
> JSF 2.19, Richfaces 4.3.5
> Reporter: Igor Bolshakov
> Assignee: Brian Leathem
> Priority: Critical
> Labels: gss, needs-qe
> Fix For: 4.3.7
>
> Attachments: a4j.log, localhost.har, push-test.zip, push-test.zip, screenshot.png, web.xml
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I use {{rendered}} attribute to start/stop a4j:push component in example below. After rendering of a4j:push element the handling of incoming push messages is broken. In my simple example I set alert to notify about recieved message (see attached screenshot).
> View xhtml code:
> {code:xml}<?xml version="1.0" encoding="ISO-8859-1"?>
> <ui:composition xmlns="http://www.w3.org/1999/xhtml"
> xmlns:a4j="http://richfaces.org/a4j"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:ui="http://java.sun.com/jsf/facelets">
> <h:form>
> <a4j:outputPanel id="push-panel">
> <a4j:push address="TEST_ADDRESS" ondataavailable="alert('event.rf.data=' + event.rf.data)"
> rendered="#{testBean.enabled}"/>
> </a4j:outputPanel>
> <a4j:commandButton id="startBtn" value="Start Push" action="#{testBean.startPush}" render="push-panel"/>
> <a4j:commandButton id="stopBtn" value="Stop Push" action="#{testBean.stopPush}" render="push-panel"/>
> <a4j:commandButton id="sendMessage" value="Send Message" action="#{testBean.sendMessage}"/>
> </h:form>
> </ui:composition>{code}
> Backing bean class:
> {code}public class TestBean {
> private boolean enabled = false;
> public boolean isEnabled() {
> return enabled;
> }
> public void startPush() {
> enabled = true;
> }
> public void stopPush() {
> enabled = false;
> }
> public void sendMessage() throws MessageException {
> TopicsContext.lookup().publish(new TopicKey("TEST_ADDRESS"), "Hello World");
> }
> }{code}
> Configuration in web.xml (see attachment).
> Scenario:
> 1) Open page
> 2) Click "Start Push" button
> 3) Click "Send Message" button
> 4) Alert "event.rf.data=Hello World" is shown (see attached screenshot)
> 5) Click "Stop Push" button
> 6) Polling is closed (see localhost.har in attachment)
> 7) Click "Start Push" button
> 8) Polling is started (see localhost.har in attachment)
> 9) Click "Send Message" button
> 10) Message is recieved (see localhost.har in attachment)
> 11) No alert, no javascript error
> For more details I saved a4j:log output in a4j.log file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years
[JBoss JIRA] (RF-13592) a4j:push doesn't work after rendering
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13592?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-13592.
--------------------------------
Labels: gss needs-qe (was: gss)
Assignee: Brian Leathem
Resolution: Done
I rest the _lastMessageNumber_ when the RichFaces.Push#disconnect function is invoked.
The resolves the problem in Chrome and Firefox (other browsers will bec verified by QE).
QE: please also verify the correct behaviour when multiple push components are present on a page, and they are selectively re-rendered.
> a4j:push doesn't work after rendering
> -------------------------------------
>
> Key: RF-13592
> URL: https://issues.jboss.org/browse/RF-13592
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-push/poll
> Affects Versions: 4.3.5
> Environment: JBoss EAP 6.2
> Browser: Chrome 33.0.1750.154 and IE 8.0.7601.17514
> JSF 2.19, Richfaces 4.3.5
> Reporter: Igor Bolshakov
> Assignee: Brian Leathem
> Priority: Critical
> Labels: gss, needs-qe
> Fix For: 4.3.7
>
> Attachments: a4j.log, localhost.har, push-test.zip, push-test.zip, screenshot.png, web.xml
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I use {{rendered}} attribute to start/stop a4j:push component in example below. After rendering of a4j:push element the handling of incoming push messages is broken. In my simple example I set alert to notify about recieved message (see attached screenshot).
> View xhtml code:
> {code:xml}<?xml version="1.0" encoding="ISO-8859-1"?>
> <ui:composition xmlns="http://www.w3.org/1999/xhtml"
> xmlns:a4j="http://richfaces.org/a4j"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:ui="http://java.sun.com/jsf/facelets">
> <h:form>
> <a4j:outputPanel id="push-panel">
> <a4j:push address="TEST_ADDRESS" ondataavailable="alert('event.rf.data=' + event.rf.data)"
> rendered="#{testBean.enabled}"/>
> </a4j:outputPanel>
> <a4j:commandButton id="startBtn" value="Start Push" action="#{testBean.startPush}" render="push-panel"/>
> <a4j:commandButton id="stopBtn" value="Stop Push" action="#{testBean.stopPush}" render="push-panel"/>
> <a4j:commandButton id="sendMessage" value="Send Message" action="#{testBean.sendMessage}"/>
> </h:form>
> </ui:composition>{code}
> Backing bean class:
> {code}public class TestBean {
> private boolean enabled = false;
> public boolean isEnabled() {
> return enabled;
> }
> public void startPush() {
> enabled = true;
> }
> public void stopPush() {
> enabled = false;
> }
> public void sendMessage() throws MessageException {
> TopicsContext.lookup().publish(new TopicKey("TEST_ADDRESS"), "Hello World");
> }
> }{code}
> Configuration in web.xml (see attachment).
> Scenario:
> 1) Open page
> 2) Click "Start Push" button
> 3) Click "Send Message" button
> 4) Alert "event.rf.data=Hello World" is shown (see attached screenshot)
> 5) Click "Stop Push" button
> 6) Polling is closed (see localhost.har in attachment)
> 7) Click "Start Push" button
> 8) Polling is started (see localhost.har in attachment)
> 9) Click "Send Message" button
> 10) Message is recieved (see localhost.har in attachment)
> 11) No alert, no javascript error
> For more details I saved a4j:log output in a4j.log file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years
[JBoss JIRA] (RF-13592) a4j:push doesn't work after rendering
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13592?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13592:
------------------------------------
The issue is that the _lastMessageNumber_ in the _RichFaces.Push_ closure is set on page load, and is not reset on ajax load. After ajax render the _message.number_ is compared to the _lastMessageNumber_, and the message is ignored if the number is too small. This can be seen in the attached sample as follows:
1) load the page
2) enable push
3) click send message X times
4) disable push
5) enable push
4) push send message X+1 times
The message will not be displayed until the X+1st click.
Resolution will involve resetting the _lastMessageNumber_ when the push component is destroyed.
> a4j:push doesn't work after rendering
> -------------------------------------
>
> Key: RF-13592
> URL: https://issues.jboss.org/browse/RF-13592
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-push/poll
> Affects Versions: 4.3.5
> Environment: JBoss EAP 6.2
> Browser: Chrome 33.0.1750.154 and IE 8.0.7601.17514
> JSF 2.19, Richfaces 4.3.5
> Reporter: Igor Bolshakov
> Priority: Critical
> Labels: gss
> Fix For: 4.3.7
>
> Attachments: a4j.log, localhost.har, push-test.zip, push-test.zip, screenshot.png, web.xml
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I use {{rendered}} attribute to start/stop a4j:push component in example below. After rendering of a4j:push element the handling of incoming push messages is broken. In my simple example I set alert to notify about recieved message (see attached screenshot).
> View xhtml code:
> {code:xml}<?xml version="1.0" encoding="ISO-8859-1"?>
> <ui:composition xmlns="http://www.w3.org/1999/xhtml"
> xmlns:a4j="http://richfaces.org/a4j"
> xmlns:h="http://java.sun.com/jsf/html"
> xmlns:ui="http://java.sun.com/jsf/facelets">
> <h:form>
> <a4j:outputPanel id="push-panel">
> <a4j:push address="TEST_ADDRESS" ondataavailable="alert('event.rf.data=' + event.rf.data)"
> rendered="#{testBean.enabled}"/>
> </a4j:outputPanel>
> <a4j:commandButton id="startBtn" value="Start Push" action="#{testBean.startPush}" render="push-panel"/>
> <a4j:commandButton id="stopBtn" value="Stop Push" action="#{testBean.stopPush}" render="push-panel"/>
> <a4j:commandButton id="sendMessage" value="Send Message" action="#{testBean.sendMessage}"/>
> </h:form>
> </ui:composition>{code}
> Backing bean class:
> {code}public class TestBean {
> private boolean enabled = false;
> public boolean isEnabled() {
> return enabled;
> }
> public void startPush() {
> enabled = true;
> }
> public void stopPush() {
> enabled = false;
> }
> public void sendMessage() throws MessageException {
> TopicsContext.lookup().publish(new TopicKey("TEST_ADDRESS"), "Hello World");
> }
> }{code}
> Configuration in web.xml (see attachment).
> Scenario:
> 1) Open page
> 2) Click "Start Push" button
> 3) Click "Send Message" button
> 4) Alert "event.rf.data=Hello World" is shown (see attached screenshot)
> 5) Click "Stop Push" button
> 6) Polling is closed (see localhost.har in attachment)
> 7) Click "Start Push" button
> 8) Polling is started (see localhost.har in attachment)
> 9) Click "Send Message" button
> 10) Message is recieved (see localhost.har in attachment)
> 11) No alert, no javascript error
> For more details I saved a4j:log output in a4j.log file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years
[JBoss JIRA] (RF-13564) rich:pickList shows an outline when clicked
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13564?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-13564.
--------------------------------
Resolution: Done
> rich:pickList shows an outline when clicked
> -------------------------------------------
>
> Key: RF-13564
> URL: https://issues.jboss.org/browse/RF-13564
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.5
> Reporter: alexey plotnikov
> Assignee: Brian Leathem
> Priority: Trivial
> Fix For: 4.3.7
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Hi all, i use rich:pickList and i was amazing. If we press left button on a mouse(don't release left button) on rich:pickList we'll see rectangle. You can check it [here|http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=pi...].
> I found a solution:
> in file template "picklist.template.xml"
> {code}
> ...
> <div id="#{clientId}" tabindex="-1" class="#{concatClasses('rf-pick', component.attributes['styleClass'], disabled ? component.attributes['disabledClass'] : '')}" style="#{component.attributes['style']}"
> cdk:passThrough="onclick:onclick ondblclick:ondblclick onmousedown:onmousedown onmouseup:onmouseup onmouseover:onmouseover
> onmousemove:onmousemove onmouseout:onmouseout onkeypress:onkeypress onkeydown:onkeydown onkeyup:onkeyup">
> ...
> {code}
> used tabindex attribue for DIV.
> Why?
> DIV elements are not compatible with tabindex ([see the HTML 4.01 spec|http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex]).
> I can create pull request :).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years
[JBoss JIRA] (RF-13506) Incorrect information on showcase fileUpload sample page (maxRequestSize description)
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13506?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13506:
------------------------------------
The _org.richfaces.fileUpload.maxRequestSize_ context parameter takes it's value in bytes, and it is set to 100,000 bytes. The value in the text incorrectly says it's incroeectly set to 1,000,000 bytes. I will change this to 100,000. I will however leave the 100kB in the text, as that is generally accepted practice when discussing storage size (see this [wikipedia article|http://en.wikipedia.org/wiki/Kilobyte] for details).
> Incorrect information on showcase fileUpload sample page (maxRequestSize description)
> -------------------------------------------------------------------------------------
>
> Key: RF-13506
> URL: https://issues.jboss.org/browse/RF-13506
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: component-input, examples, showcase
> Affects Versions: 4.3.4
> Reporter: Vasil Lukach
> Assignee: Brian Leathem
> Priority: Trivial
> Fix For: 4.3.7
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=fileUpload page contains incorrect information:
> "maxRequestSize attribute defines max size in bytes of the uploaded files (1000000 for this example)".
> But based on "This example allows you to upload up to 5 files. The file extension is limited to GIF, JPG, BMP, PNG and the maximum size of each file must not exceed 100kB" number 1000000 should be changed to 102400.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years
[JBoss JIRA] (RF-13478) VDL documentation typos
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13478?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-13478.
--------------------------------
Resolution: Done
All updated execpet the _execute_ attribute. It is defined centrally, and there is insufficient benefit to "forking" the description for the fileUpload component at this point.
> VDL documentation typos
> -----------------------
>
> Key: RF-13478
> URL: https://issues.jboss.org/browse/RF-13478
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: doc
> Affects Versions: 4.3.3, 4.3.4
> Reporter: Vasil Lukach
> Assignee: Brian Leathem
> Priority: Trivial
> Fix For: 4.3.7
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> RichFaces VDL documentation typos:
> # rich:fileUpload
> #- uploadLabel attribute : Add -> Upload
> #- execute attribute (proposal): remove "Some components make use of additional keywords"
> # a4j:mediaOutput
> #- element attribute: imj -> img
> # rich:accordion
> #- epand -> expand
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years