July 2014 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13690: ------------------------------------ [~michpetrov] given that this and RF-13691 are the remaining blocking issues for our 4.5.0.Alpha3 release, would you mind taking a look at this issue? I'll synch up with you in the (my) morning and pick up where you leave off. > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13690: ------------------------------------ The method in full: {code} // Tests whether we need to visit our children as part of // a tree visit private boolean doVisitChildren(VisitContext context) { // Just need to check whether there are any ids under this // subtree. Make sure row index is cleared out since // getSubtreeIdsToVisit() needs our row-less client id. // // We only need to position if row iteration is actually needed. // if (requiresRowIteration(context)) { setIndex(context.getFacesContext(), -1); } Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this); assert(idsToVisit != null); // All ids or non-empty collection means we need to visit our children. return (!idsToVisit.isEmpty()); } {code} > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13690: ------------------------------------ I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152]. The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is: {code} ---------------------------- Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java =================================================================== --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814) +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy) @@ -787,7 +787,9 @@ // Just need to check whether there are any ids under this // subtree. Make sure row index is cleared out since // getSubtreeIdsToVisit() needs our row-less client id. - setIndex(context.getFacesContext(), -1); + if (requiresRowIteration(context)) { + setIndex(context.getFacesContext(), -1); + } Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this); assert(idsToVisit != null); {code} and it's meant to address: {quote} {{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area {quote} > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13706) dequeued Ajax request not processed correctly if its source element has been updated

by Marcel Kolsteren (JIRA)

[ https://issues.jboss.org/browse/RF-13706?page=com.atlassian.jira.plugin.s... ] Marcel Kolsteren commented on RF-13706: --------------------------------------- I integrated my unit test into the 4.5.x branch. Please pull here: https://github.com/richfaces/richfaces/pull/94 > dequeued Ajax request not processed correctly if its source element has been updated > ------------------------------------------------------------------------------------ > > Key: RF-13706 > URL: https://issues.jboss.org/browse/RF-13706 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: core > Affects Versions: 4.3.7 > Reporter: Marcel Kolsteren > Assignee: Marcel Kolsteren > Fix For: 4.3.8, 4.5.0.Alpha3 > > Attachments: queuetest-javaee6.zip, queuetest.zip, richfaces-core-4.3.8-SNAPSHOT.patch.zip > > Original Estimate: 1 hour > Remaining Estimate: 1 hour > > I found a problem in the RichFaces Ajax queuing mechanism, which can cause all JavaScript execution to stop, leaving the end user with an unresponsive page. > The problem occurs when a request in the queue rerenders an area that includes the source element of the next request in the queue, but does not include the form of that source element. When the next request is fetched from the queue, JSF tries to find the correct form by climbing the DOM tree, starting at the source element of the event. However, because the source element has been rerendered, the path to its form is broken, and in that case JSF falls back to the first form of the page (see JavaScript function getForm that is called by jsf.ajax.request in jsf.js). If that form is not the form belonging to the rerendered version of the element, nasty things will happen. > To illustrate this, I created a very simple Java EE 7 web application (see attached Maven project) and deployed it in WildFly 8.1.0.Final. It contains a page with one clickable link that rerenders itself when clicked: > {noformat} > <!DOCTYPE html> > <html xmlns="http://www.w3.org/1999/xhtml" > xmlns:h="http://java.sun.com/jsf/html" > xmlns:a4j="http://richfaces.org/a4j"> > <h:head/> > <h:body> > <form action="http://www.meandi.nl"/> > <h:form> > <a4j:commandLink action="#{richBean.waitThreeSeconds}" value="Click Me" render="@this"/> > </h:form> > </h:body> > </html> > {noformat} > The method "waitThreeSeconds" does nothing but waiting for three seconds. When the link is double clicked, you'll observe that the first click is handled correctly, but that the second click results in an Ajax request posted to the URL of the first form, leading to access denied errors (because of cross domain scripting). The used RichFaces version is 4.3.7. > The problem can be fixed by changing the RichFaces JavaScript code, so that after completion of an Ajax request, stale elements are removed from the queue. I created a patch for RichFaces 4.3.7, and verified that it works (see attachment). Another solution strategy would be to try to find the new DOM element that corresponds to the stale source of the event, and fetch the form from that element. My thought was that removing the stale request would be better, because (1) it is kind of dangerous to process a user action on an element that has already been replaced and (2) the element might have been removed from the DOM tree by the previous rerender. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13673) Backport the plain skin fix from RF 5

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13673?page=com.atlassian.jira.plugin.s... ] Brian Leathem resolved RF-13673. -------------------------------- Resolution: Done Please file new issues for the components with a broken plain skin (a single issue to cover all broken components). It is unlikely we will resolve this for 4.5.0.Alpha3. > Backport the plain skin fix from RF 5 > ------------------------------------- > > Key: RF-13673 > URL: https://issues.jboss.org/browse/RF-13673 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: skinning > Reporter: Brian Leathem > Assignee: Brian Leathem > Fix For: 4.5.0.Alpha3 > > Attachments: autocompleteInPlain.png, calendarWithPlain.png > > Original Estimate: 30 minutes > Remaining Estimate: 30 minutes > > Backport RF-11103. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem edited comment on RF-13690 at 7/14/14 12:43 PM: -------------------------------------------------------------- Issues [resolved in mojarra 2.2.6|https://java.net/jira/browse/JAVASERVERFACES-3154?jql=project%20%3D...]. It seems likely that this breakage is due to JAVASERVERFACES-3152. was (Author: bleathem): Issues [resolved in mojarra 2.2.6|https://java.net/jira/browse/JAVASERVERFACES-3154?jql=project%20%3D...]. > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem edited comment on RF-13690 at 7/14/14 12:44 PM: -------------------------------------------------------------- Issues [resolved in mojarra 2.2.6|https://java.net/jira/browse/JAVASERVERFACES-3154?jql=project%20%3D...]. It seems likely that this breakage is due to [JAVASERVERFACES-3152.|https://java.net/jira/browse/JAVASERVERFACES-3152] was (Author: bleathem): Issues [resolved in mojarra 2.2.6|https://java.net/jira/browse/JAVASERVERFACES-3154?jql=project%20%3D...]. It seems likely that this breakage is due to JAVASERVERFACES-3152. > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13690: ------------------------------------ Issues [resolved in mojarra 2.2.6|https://java.net/jira/browse/JAVASERVERFACES-3154?jql=project%20%3D...]. > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13690) DataTable in uiRepeat - scrolling in table makes columns unsorted again

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13690?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13690: ------------------------------------ This issue works fine on WildFly 8.0.0.Final (jsf-impl-2.2.5-jbossorg-3), but breaks on WildFly 8.1.0.Final (jsf-impl-2.2.6-jbossorg-4). > DataTable in uiRepeat - scrolling in table makes columns unsorted again > ----------------------------------------------------------------------- > > Key: RF-13690 > URL: https://issues.jboss.org/browse/RF-13690 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tables > Affects Versions: 4.5.0.Alpha3 > Environment: WildFly 8.1. > Reporter: Juraj Húska > Assignee: Brian Leathem > Labels: regression > Fix For: 4.5.0.Alpha3 > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When {{DataTable}} is nested in {{uiRepeat}}, then scrolling over the table with {{dataScroller}} makes sorting according to some column broken - the columns are unsorted. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (RF-13673) Backport the plain skin fix from RF 5

by Juraj Húska (JIRA)

[ https://issues.jboss.org/browse/RF-13673?page=com.atlassian.jira.plugin.s... ] Juraj Húska updated RF-13673: ----------------------------- Attachment: autocompleteInPlain.png calendarWithPlain.png > Backport the plain skin fix from RF 5 > ------------------------------------- > > Key: RF-13673 > URL: https://issues.jboss.org/browse/RF-13673 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: skinning > Reporter: Brian Leathem > Assignee: Brian Leathem > Fix For: 4.5.0.Alpha3 > > Attachments: autocompleteInPlain.png, calendarWithPlain.png > > Original Estimate: 30 minutes > Remaining Estimate: 30 minutes > > Backport RF-11103. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues July 2014