[richfaces-issues] [JBoss JIRA] Commented: (RF-10867) JS API: switchablePanels: rename a few methods
[
https://issues.jboss.org/browse/RF-10867?page=com.atlassian.jira.plugin.s...
]
Jay Balunas commented on RF-10867:
----------------------------------
I agree with updating the doc for sure. I'm not sure about renaming these as part of
the 4.1 release. Although not idea nextItem() and getNextItem() are not that different,
and I do not want to break existing applications by changing these.
So in this case it is a doc issue only.
JS API: switchablePanels: rename a few methods
----------------------------------------------
Key: RF-10867
URL: https://issues.jboss.org/browse/RF-10867
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Final
Reporter: Ilya Shaikovsky
Fix For: 4.1.0.Milestone1
problematic API methods:
firstItem(), prevItem(), nextItem(), lastItem()
and description from documentation:
Switch to and display the first item, the previous item, the next item, or the last
item.
But actually all that methods just returns name of corresponding item. So them do not
perform switching but only could be used as a parameter of switchToItem(itemName) method.
Actually I do not think we need them to be used as parameters as there is more convenient
way already:
tabPanelObject.switchToItem('@last')
tabPanelObject.switchToItem('@next')
...
But let's keep as option for users and rename to
getFirstItem(), getPrevItem(), getNextItem(), getLastItem()
Approved via email discussion.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira