[richfaces-issues] [JBoss JIRA] (RF-12802) Move page fragments from repository qa to richfaces5

[ https://issues.jboss.org/browse/RF-12802?page=com.atlassian.jira.plugin.s... ] Juraj Húska edited comment on RF-12802 at 9/30/13 3:22 AM: ----------------------------------------------------------- Couple of questions which arose during refactoring, and we would like to know your opinion on that: 1. Do we want methods to throw exceptions when certain condition is not met, or we want them to be no operation in such situations. Consider e.g.: {code} public void hide() { if (!getMenuPopupInternal().isDisplayed()) { throw new IllegalStateException("You are attemting to hide the " + getNameOfFragment() + ", however, no " + getNameOfFragment() + " is displayed at the moment!"); } browser.findElement(Utils.BY_HTML).click(); waitUntilIsNotVisible().perform(); } {code} Which throws exception when an user is attempting to hide already hidden popup panel. 2. Do we want to have {{AdvancedInteractions advanced()}} method in the API ? For some Page Fragments, not doing so, means breaking program to interface rule. E.g. using {{TextInputComponentImpl}} in {{RichFacesAutocomplete}} [here|https://github.com/richfaces/richfaces-qa/blob/master/page-fragments...]. In order to allow user to call {{advanced}} on the returned object, we have to return concrete implementation, not the interface. Is that OK for that component ? I would not add {{advanced}} to API, because not all implementation (not our, but possible future implementations) need such method. was (Author: jhuska): Couple of questions which arose during refactoring, and we would like to know your opinion on that: 1. Do we want methods to throw exceptions when certain condition is not met, or we want them to be no operation in such situations. Consider e.g.: {code} public void hide() { if (!getMenuPopupInternal().isDisplayed()) { throw new IllegalStateException("You are attemting to hide the " + getNameOfFragment() + ", however, no " + getNameOfFragment() + " is displayed at the moment!"); } browser.findElement(Utils.BY_HTML).click(); waitUntilIsNotVisible().perform(); } {code} Which throws exception when an user is attempting to hide already hidden popup panel. 2. Do we want to have {{AdvancedInteractions advanced()}} method in the API ? For some Page Fragments, not doing so, means breaking program to interface rule. E.g. using {{TextInputComponentImpl}} in {{RichFacesAutocomplete}} [here|https://github.com/richfaces/richfaces-qa/blob/master/page-fragments...]. In order to allow user to call {{advanced}} on the returned object, we have to return concrete implementation, not the interface. Is that OK for that component ? I would not add {{advanced}} to API, because not all implementation (not our, but possible future implementations) needs such method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira