[richfaces-issues] [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
James G commented on RF-10221:
------------------------------
Hi Gleb, thanks for responding. I'll take one last shot here:
This is the code I'm disputing:
richfaces.Event.ready(richfaces.$(id).show());
which is the same as:
$(document).ready(richfaces.$(id).show());
everywhere else in the Richfaces javascript library, where the .ready() method is used, a
function reference is passed in as the parameter to this method.
For example in panelMenuItem.js I see the code:
$(this.__panelMenu()).ready(function () {
item.__renderNestingLevel();
});
from an academic point of view, if you want the foobar method to be called from a queued
callback then this code will NOT work:
$(document).ready( foobar() );
In this case, the return value of foobar is passed to the .ready() method which is NOT
what you want.
either one of these would work:
$(document).ready( function(){ foobar(); } );
$(document).ready( foobar );
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira