[richfaces-issues] [JBoss JIRA] (RF-12644) Improve CoreUtils/JSEncoder performance by character escape improvements
[
https://issues.jboss.org/browse/RF-12644?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12644:
---------------------------------
Hey Darius, could you please add some JUnit tests which would guard the {{JSEncoder}}?
I can see there is
[{{ScriptUtilsTest}}|https://github.com/richfaces/core/blob/develop/api/src/test/java/org/ajax4jsf/javascript/ScriptUtilsTest.java#L244]
which in the end tests {{JSEncoder}} through {{ScriptUtils}}, but it's really simple.
You can either extend {{ScriptUtilsTest}} or add {{JSEncoderTest}} side by side to
{{ScriptUtils}}.
Improve CoreUtils/JSEncoder performance by character escape
improvements
------------------------------------------------------------------------
Key: RF-12644
URL: https://issues.jboss.org/browse/RF-12644
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 4.3.0.M2
Reporter: Darius Ski
Assignee: Lukáš Fryč
Priority: Minor
Fix For: 4.3.0.M3
In JSUtils, character escaping is done a char at a time. Also in JSEncoder there is
opportunity to add encode method that operates with CharBuffer constants and making
encode/compile methods static.
Improves partial rendering performance, when large Strings are coming from user beans
(for example custom generated JSON), that need escaping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira