[richfaces-issues] [JBoss JIRA] (RF-12365) Spinner: NPE in InputNumberSpinnerRenderer.convertToBoolean

Friday, 27 July 2012

    [
https://issues.jboss.org/browse/RF-12365?page=com.atlassian.jira.plugin.s...
] 

Lukáš Fryč edited comment on RF-12365 at 7/27/12 8:57 AM:
----------------------------------------------------------

In recent CDK changes, I have changed semantics of {{convertToBoolean}}.
https://github.com/richfaces/cdk/commit/331a6c1d34e5930e748a32045de3e86e8...

Regrettably this change didn't promise backward-compatibility.

Since {{convertToBoolean}} is heavily used in project, I reverted the changes back,
and this method now returns {{boolean}} and if you provide {{null}} as parameter, it
return {{false}}.

      was (Author: lfryc):
    In recent CDK changes, I have changed semantics of {{convertToBoolean}}.
https://github.com/richfaces/cdk/commit/331a6c1d34e5930e748a32045de3e86e8...

Regrettably this change didn't promise backward-compatibility.

Since {{convertToBoolean}} is heavily used in project, I added reverted the changed back,
and this method now returns {{boolean}} and if you provide {{null}} as parameter, it
return {{false}}.

...
 Spinner: NPE in InputNumberSpinnerRenderer.convertToBoolean
 -----------------------------------------------------------

                 Key: RF-12365
                 URL: https://issues.jboss.org/browse/RF-12365
             Project: RichFaces
          Issue Type: Feature Request
      Security Level: Public(Everyone can see) 
          Components: cdk, component-input
    Affects Versions: 4.3.0.Milestone1
         Environment: RichFaces 4.3.0-SNAPSHOT
 JBoss AS 7.1.1.Final
 Mojarra 2.1.7-jbossorg-1
            Reporter: Pavol Pitonak
            Assignee: Lukáš Fryč
            Priority: Blocker
              Labels: regression
             Fix For: 4.3.0.Milestone1

 1. deploy Metamer and open
http://localhost:8080/metamer/faces/components/richInputNumberSpinner/sim...
 result:
 {quote}
 10:43:00,404 SEVERE [javax.enterprise.resource.webcontainer.jsf.application]
(http-localhost-127.0.0.1-8080-6) Error Rendering View[/richfaces/component-sample.xhtml]:
java.lang.NullPointerException
         at
org.richfaces.renderkit.html.InputNumberSpinnerRenderer.convertToBoolean(InputNumberSpinnerRenderer.java:138)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at
org.richfaces.renderkit.html.InputNumberSpinnerRenderer.doEncodeEnd(InputNumberSpinnerRenderer.java:175)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at org.richfaces.renderkit.RendererBase.encodeEnd(RendererBase.java:175)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:875)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1786)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1782)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1782)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:402)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:125)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:121)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
org.richfaces.demo.arrangeablemodel.PersistenceLifecycle.render(PersistenceLifecycle.java:66)
[classes:]
         at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:329)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at
org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:62)
[weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:172)
[rewrite-servlet-1.0.4.Final.jar:1.0.4.Final]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:275)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161)
[jbossweb-7.0.13.Final.jar:]
         at
org.jboss.as.jpa.interceptor.WebNonTxEmCloserValve.invoke(WebNonTxEmCloserValve.java:50)
[jboss-as-jpa-7.1.1.Final.jar:7.1.1.Final]
         at
org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:153)
[jboss-as-web-7.1.1.Final.jar:7.1.1.Final]
         at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:368)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:877)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:671)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:930)
[jbossweb-7.0.13.Final.jar:]
         at java.lang.Thread.run(Thread.java:662) [rt.jar:1.6.0_32]
 10:43:00,443 INFO  [javax.enterprise.resource.webcontainer.jsf.context]
(http-localhost-127.0.0.1-8080-6) Exception when handling error trying to reset the
response.: java.lang.NullPointerException
         at
org.richfaces.renderkit.html.InputNumberSpinnerRenderer.convertToBoolean(InputNumberSpinnerRenderer.java:138)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at
org.richfaces.renderkit.html.InputNumberSpinnerRenderer.doEncodeEnd(InputNumberSpinnerRenderer.java:175)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at org.richfaces.renderkit.RendererBase.encodeEnd(RendererBase.java:175)
[richfaces-components-ui-4.3.0-SNAPSHOT.jar:4.3.0-SNAPSHOT]
         at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:875)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1786)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1782)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1782)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:402)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:125)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:121)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
[jsf-impl-2.1.7-jbossorg-2.jar:]
         at
org.richfaces.demo.arrangeablemodel.PersistenceLifecycle.render(PersistenceLifecycle.java:66)
[classes:]
         at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594)
[jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:329)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at
org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:62)
[weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:172)
[rewrite-servlet-1.0.4.Final.jar:1.0.4.Final]
         at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:275)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161)
[jbossweb-7.0.13.Final.jar:]
         at
org.jboss.as.jpa.interceptor.WebNonTxEmCloserValve.invoke(WebNonTxEmCloserValve.java:50)
[jboss-as-jpa-7.1.1.Final.jar:7.1.1.Final]
         at
org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:153)
[jboss-as-web-7.1.1.Final.jar:7.1.1.Final]
         at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:368)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:877)
[jbossweb-7.0.13.Final.jar:]
         at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:671)
[jbossweb-7.0.13.Final.jar:]
         at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:930)
[jbossweb-7.0.13.Final.jar:]
         at java.lang.Thread.run(Thread.java:662) [rt.jar:1.6.0_32]
 {quote} 
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

[richfaces-issues] [JBoss JIRA] (RF-12365) Spinner: NPE in InputNumberSpinnerRenderer.convertToBoolean