[richfaces-issues] [JBoss JIRA] Issue Comment Edited: (RF-10793) ExtendedDataTable selection with Ctrl+click does not correctly update selection backing bean without clicking first

[ https://issues.jboss.org/browse/RF-10793?page=com.atlassian.jira.plugin.s... ] David Serres edited comment on RF-10793 at 3/24/11 1:32 PM: ------------------------------------------------------------ Hi guys, I have the solution. In the class "TableSelectionRendererContributor" there is the following condition: if (clientSelection.isReset() || clientSelection.isSelectAll()) { simpleSelection.clear(); } That means that if a "click" or a "Ctrl+a" has been done, the selection you had should be cleaned. This is done to remember the selection you had in case a click with Ctrl is made. The solution is to always make the "clear", as all data in the selection is always sent. To fix the bug, you can comment the condition, or add a javascript file that I have attached. In the javascript file, the value "x", should be added as "selectionFlag", as long as it is responsible of always reseting the simpleSelection. Regards David was (Author: david.serres): Hi guys, I have the solution. In the class "TableSelectionRendererContributor" there is the following condition: if (clientSelection.isReset() || clientSelection.isSelectAll()) { simpleSelection.clear(); } That means that if a "click" or a "Ctrl+a" has been done, the selection you had should be cleaned. This is done to remember the selection you had in case a click with Ctrl is made. The solution is to always make the "clear", as all data in the selection is always sent. To fix the bug, you can comment the condition, or add a javascript file with the following code: ExtendedDataTable.SelectionManager.prototype.processClick = function(event, rowIndex) { if (this.options.selectionMode == "none") { return; } var bSingleSelection = this.options.selectionMode == "single"; if(!event.shiftKey) { this.shiftRow = null; } var range; if ( event.shiftKey && !event.ctrlKey && !bSingleSelection && !event.altKey) { var arr = $(this.prefix + ":n").rows[0].id.split(":"); this.firstIndex = Number(arr[arr.length-1]); this.selectionFlag = "x"; if(!this.shiftRow) { this.shiftRow = this.activeRow; } this.startRow = this.shiftRow; if (((this.startRow <= rowIndex) && (this.firstIndex <= this.startRow || rowIndex < this.firstIndex)) || (this.startRow > rowIndex && this.firstIndex < this.startRow && rowIndex <= this.firstIndex)) { this.endRow = rowIndex; } else { this.endRow = this.startRow; this.startRow = rowIndex; } if(this.startRow > this.endRow) { //bugfix //without this selection of first row with shift was broken var t = this.startRow; this.startRow = this.endRow; this.endRow = t; } range = [this.startRow, this.endRow]; this.setSelection(range); } else if (!event.shiftKey && event.ctrlKey && !event.altKey) { this.selectionFlag = "x"; //<------ ADDED THIS!!!!!! if (this.selection.isSelectedId(rowIndex)) { this.removeRowFromSelection(rowIndex); } else { if (!bSingleSelection || this.selection.size() == 0) { this.addRowToSelection(rowIndex); } } } else if (!event.shiftKey && !event.ctrlKey && !event.altKey) { this.selectionFlag = "x"; range = [rowIndex, rowIndex]; this.setSelection(range); } this.setActiveRow(rowIndex); if (event.shiftKey) { if (window.getSelection) { window.getSelection().removeAllRanges(); } else if (document.selection) { document.selection.empty(); } } this.selectionChanged(event); } The value "x", should be added as "selectionFlag", as long as it is responsible of always reseting the simpleSelection. Regards David -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira