[richfaces-issues] [JBoss JIRA] Issue Comment Edited: (RF-9924) Panel menu: rename icon attributes
[
https://issues.jboss.org/browse/RF-9924?page=com.atlassian.jira.plugin.sy...
]
Lukas Fryc edited comment on RF-9924 at 1/11/11 5:24 AM:
---------------------------------------------------------
Please consider that the Group and Item itself have follows other naming principle:
Current situation:
Panel Menu - @groupCollapseIconLeft
Panel Menu Group - @iconLeftCollapsed
The attributes should be named consistently across Panel Menu and it's children.
Proposed consistent naming:
Panel Menu - @groupIconLeftCollapsed
Panel Menu Group - @iconLeftCollapsed
was (Author: lfryc(a)redhat.com):
Please consider that the Group and Item itself have follows other naming principle:
e.g.
Panel Menu - @groupCollapseIconLeft
Panel Menu Group - @iconLeftCollapsed
The attributes should be named consistently across Panel Menu and it's children.
I personally then prefer renaming Panel Menu attributes itself, e.g. to
@groupIconLeftCollapsed (it is easier to read in the code).
Panel menu: rename icon attributes
----------------------------------
Key: RF-9924
URL: https://issues.jboss.org/browse/RF-9924
Project: RichFaces
Issue Type: Task
Security Level: Public(Everyone can see)
Components: component-output
Affects Versions: 4.0.0.Milestone4
Environment: RichFaces 4.0.0-SNAPSHOT r.20396
Reporter: Pavol Pitonak
Assignee: Alex Kolonitsky
Fix For: 4.0.0.CR1
Replace "Collapse" with "Collapsed", "Disable" with
"Disabled" and "Expand" with "Expanded" in following
attributes of rich:panelMenu:
topGroupCollapseIconLeft
topGroupCollapseIconRight
topGroupDisableClass
topGroupDisableIconLeft
topGroupDisableIconRight
topGroupExpandIconLeft
topGroupExpandIconRight
topItemDisableClass
topItemDisableIconLeft
topItemDisableIconRight
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira