[richfaces-issues] [JBoss JIRA] (RF-12647) rich:dataTable rowclick regression

[ https://issues.jboss.org/browse/RF-12647?page=com.atlassian.jira.plugin.s... ] Fab Mars updated RF-12647: -------------------------- Description: During my migration from RF 3.3 I found this: Before (with RF 3.3.3): {code:xml} <rich:dataTable id="shippingList" value="#{billingLister.allShippings}" var="shipping"> <a4j:support event="onRowClick" reRender="shippingEditForm"> <a4j:actionparam name="shippingId" value="#{shipping.id}" assignTo="#{shippingEdit.id}"/> </a4j:support> <rich:column> <f:facet name="header"> <h:outputText value="Destination"/> </f:facet> <h:outputText value="#{shipping.destinationCountry.name}" /> </rich:column> <!-- other columns here --> </rich:dataTable> {code} There was nothing really impacting on the migration guide https://community.jboss.org/wiki/RichFacesMigrationGuide33x-4xMigration-C... So I logically did that with RF4.x.x: {code:xml} <rich:dataTable id="shippingList" value="#{billingLister.allShippings}" var="shipping"> <a4j:ajax event="rowclick" render="shippingEditForm"> <a4j:actionparam name="shippingId" value="#{shipping.id}" assignTo="#{shippingEdit.id}"/> </a4j:ajax> <rich:column> <f:facet name="header"> <h:outputText value="Destination"/> </f:facet> <h:outputText value="#{shipping.destinationCountry.name}" /> </rich:column> <!-- other columns here --> </rich:dataTable> {code} But the a4j:ajax isn't triggered (not at all, it's different from RF-11446). To start having something that responds, one needs to remove the a4j:param and do it straight. {code:xml} <a4j:ajax event="rowclick" render="shippingEditForm" listener="#{shippingEdit.setId(shipping.id)}"/> {code} Anyhow we're close to https://issues.jboss.org/browse/RF-11446 and whenever that one gets fixed, one should check this case here is also solved. But wait, here's more: when one clicks on a row with that code, he gets an ArrayIndexOutOfBoundsException because the clientID that's actually passed into UIDataAdapter#invokeOnRow is the id of the dataTable itself, NOT this of the row/cell. Hence, String rowId = clientId.substring(baseId.length() + 1) ends up tragically. So...to make it really work, you have to do what's described here: https://community.jboss.org/thread/174063 and not fall into the trap of RF-11446. Working code (RF 4.2.3+) {code:xml} <a4j:jsFunction name="shippingListRowClick" render="shippingEditForm"> <a4j:param name="shippingId" assignTo="#{shippingEdit.id}"/> </a4j:jsFunction> <rich:dataTable id="shippingList" value="#{billingLister.allShippings}" var="shipping" onrowclick="shippingListRowClick(#{shipping.id});"> <rich:column> <f:facet name="header"> <h:outputText value="Destination"/> </f:facet> <h:outputText value="#{shipping.destinationCountry.name}" /> </rich:column> <!-- other columns here --> </rich:dataTable> {code} All that...for that. Overall that makes quite a difference between RF 3.3 and RF 4.x. I'd say we have a couple of regressions. Or at least that needs an extra clarification in the documentation and migration guide. Thank you. was: During my migration from RF 3.3 I found this: Before (with RF 3.3.3): {code:xml} <rich:dataTable id="shippingList" value="#{billingLister.allShippings}" var="shipping"> <a4j:support event="onRowClick" reRender="shippingEditForm"> <a4j:actionparam name="shippingId" value="#{shipping.id}" assignTo="#{shippingEdit.id}"/> </a4j:support> <rich:column> <f:facet name="header"> <h:outputText value="Destination"/> </f:facet> <h:outputText value="#{shipping.destinationCountry.name}" /> </rich:column> <!-- other columns here --> </rich:dataTable> {code} There was nothing really impacting on the migration guide https://community.jboss.org/wiki/RichFacesMigrationGuide33x-4xMigration-C... So I logically did that with RF4.x.x: {code:xml} <rich:dataTable id="shippingList" value="#{billingLister.allShippings}" var="shipping"> <a4j:ajax event="rowclick" render="shippingEditForm"> <a4j:actionparam name="shippingId" value="#{shipping.id}" assignTo="#{shippingEdit.id}"/> </a4j:ajax> <rich:column> <f:facet name="header"> <h:outputText value="Destination"/> </f:facet> <h:outputText value="#{shipping.destinationCountry.name}" /> </rich:column> <!-- other columns here --> </rich:dataTable> {code} But the a4j:aja isn't triggered. To start having something that works, one needs to remove the a4j:param and do it straight. {code:xml} <a4j:ajax event="rowclick" render="shippingEditForm" listener="#{shippingEdit.setId(shipping.id)}"/> {code} Not sure this is a regression or not, but wait, here's more: when one clicks on a row with that code, he gets an ArrayIndexOutOfBoundsException because the clientID that's actually passed into UIDataAdapter#invokeOnRow is the id of the dataTable itself, NOT this of the row/cell. Hence String rowId = clientId.substring(baseId.length() + 1) ends up tragically. So...to make it really work, you have to do what's described here: https://community.jboss.org/thread/174063 and not fall into the trap of https://issues.jboss.org/browse/RF-11446. Great really... Overall that makes quite a difference between RF 3.3 and RF 4.x. I'd say it's a regression. Or at least that needs an extra clarification in the documentation and migration guide. Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira