[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-11747: ------------------------------- Fix Version/s: 4.1.0.Final Description: Dears, i'am using rich:tree in two places, one in the main panel of my template, and the other one is in a popup, i'am using the onbeforetoggle event, it was running successfully since 4.0 to 4.1 M2, after M2 it is not functioning right, here is my tests : 1- RF 4-M3, onbeforetoggle not firing in the main template & in the popup. 2- RF 4-M4, main template is firing the event, popup is not firing. 3- RF 4-CR1, same as M3. here is my .xhtml code : {code} <rich:tree id="myTree" var="node" nodeType="#{node.type}" toggleType="ajax" selectionType="ajax"> <rich:treeModelRecursiveAdaptor roots="#{bean.roots}" nodes="#{node.folders}"> <rich:treeNode title="#{node.path}" type="folder" onbeforetoggle="getSelectedPath('#{node.path}')" ondblclick="chooseFolder('#{node.ecmId}', '#{node.path}')" toggleListener="#{bean.treeToggleListener}"> <h:outputText value="#{node.label}" /> </rich:treeNode> </rich:treeModelRecursiveAdaptor> </rich:tree> {code} where getSelectedPath is a a4j:jsFunction. was: Dears, i'am using rich:tree in two places, one in the main panel of my template, and the other one is in a popup, i'am using the onbeforetoggle event, it was running successfully since 4.0 to 4.1 M2, after M2 it is not functioning right, here is my tests : 1- RF 4-M3, onbeforetoggle not firing in the main template & in the popup. 2- RF 4-M4, main template is firing the event, popup is not firing. 3- RF 4-CR1, same as M3. here is my .xhtml code : <rich:tree id="myTree" var="node" nodeType="#{node.type}" toggleType="ajax" selectionType="ajax"> <rich:treeModelRecursiveAdaptor roots="#{bean.roots}" nodes="#{node.folders}"> <rich:treeNode title="#{node.path}" type="folder" onbeforetoggle="getSelectedPath('#{node.path}')" ondblclick="chooseFolder('#{node.ecmId}', '#{node.path}')" toggleListener="#{bean.treeToggleListener}"> <h:outputText value="#{node.label}" /> </rich:treeNode> </rich:treeModelRecursiveAdaptor> </rich:tree> where getSelectedPath is a a4j:jsFunction. Component/s: regression Forum Reference: http://community.jboss.org/thread/175411 (was: http://community.jboss.org/thread/175411) If this is indeed a regression, we should look at the possibility of getting a fix in for 4.1.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-11747: --------------------------------- Hey Ibrahim, I have tried on the modified Showcase sample: {code:xml|title=treeModelRecursiveAdaptor-sample.xhtml (modified 1)} <rich:tree toggleType="ajax" var="item"> <rich:treeModelRecursiveAdaptor roots="#{fileSystemBean.sourceRoots}" nodes="#{item.directories}"> <rich:treeNode onbeforetoggle="alert('#{item.shortPath}')"> #{item.shortPath} </rich:treeNode> <rich:treeModelAdaptor nodes="#{item.files}"> <rich:treeNode>#{item}</rich:treeNode> </rich:treeModelAdaptor> </rich:treeModelRecursiveAdaptor> </rich:tree> {code} {code:xml|title=treeModelRecursiveAdaptor-sample.xhtml (modified 2)} <a4j:commandButton> <rich:componentControl event="click" target="popup" operation="show" /> </a4j:commandButton> <rich:popupPanel id="popup"> <rich:tree toggleType="ajax" var="item"> <rich:treeModelRecursiveAdaptor roots="#{fileSystemBean.sourceRoots}" nodes="#{item.directories}"> <rich:treeNode onbeforetoggle="alert('#{item.shortPath}')"> #{item.shortPath} </rich:treeNode> <rich:treeModelAdaptor nodes="#{item.files}"> <rich:treeNode>#{item}</rich:treeNode> </rich:treeModelAdaptor> </rich:treeModelRecursiveAdaptor> </rich:tree> </rich:popupPanel> {code} That's quite close to your sample and works fine. It would be great if you could minimize your sample to the simplest one which is not working and post us that sample. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Ibrahim Abu Ghosh commented on RF-11747: ---------------------------------------- Hey Lukas, sorry i'm late, i was in a holiday :), yes if you use a JavaScript alert it will popup, but my problem is if you use a jsFunction, here is my jsFunction : onbeforetoggle="getSelectedPath('#{node.path}')" <a4j:jsFunction name="getSelectedPath"> <a4j:param name="path" assignTo="#{myBean.selectedFolderPath}"/> </a4j:jsFunction> myBean.selectedFolderPath supposed to have a new value before i call the toggleListener, when i call the toggleListener the selectedFolderPath is null !!. Thanks for your effort. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-11747: --------------------------------- Ibrahim, you are running into ordering issue, which I need to verify. But in your case, it would be better to use one of following, which are more deterministic (and they are not sending one more unnecessary request): # use {{TreeSelectionChangeEvent#getNewSelection()}} to obtain new selected node value. # use {{jsFunction's}} {{actionListener}} instead of {{toggleListener}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Ibrahim Abu Ghosh updated RF-11747: ----------------------------------- Workaround Description: remove onbeforetoggle and use tree.getRowData() in toggleListener to get the required information about the selected node instead of using jsFunction. Workaround: Workaround Exists Forum Reference: http://community.jboss.org/thread/175411 (was: http://community.jboss.org/thread/175411) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11747?page=com.atlassian.jira.plugin.s... ] Jan Papousek commented on RF-11747: ----------------------------------- I've tried to reproduce the bug, but I haven't been successful. I've created the following a4j:jsFunction: {code} <h:outputLabel id="jsFunctionCheckerLabel" value="jsFunction Checker" for="jsFunctionChecker"/> <a4j:outputPanel id="jsFunctionChecker"> <h:outputText value="#{phasesBean.date}"> <f:convertDateTime pattern="HH:MM:ss.SSS" /> </h:outputText> </a4j:outputPanel> {code} This function is called by '@onbeforetoggle' attribute and the date is rerendered before the @toggleListener is invoked -> so the order of events holds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira