[JBoss JIRA] Created: (RF-10784) AjaxViewRoot swallows NoSuchElementException from by the application code
12:38 p.m.
AjaxViewRoot swallows NoSuchElementException from by the application code
-------------------------------------------------------------------------
Key: RF-10784
URL: https://issues.jboss.org/browse/RF-10784
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 3.3.2.SR1
Reporter: Vladimir Kravchenko
AjaxViewRoot.processEvents() swallows NoSuchElemntException thrown by an apllication code,
due to too wide catch block:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
} catch (NoSuchElementException e) {
havePhaseEvents = false;
}
}
}
{code}
http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/framework/impl/...
A NoSuchElemtException thrown inside "source.broadcast(event);" will be
swallowed by the catch block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:06 p.m.
New subject: [JBoss JIRA] Resolved: (RF-10784) AjaxViewRoot swallows NoSuchElementException from by the application code
[
https://issues.jboss.org/browse/RF-10784?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski resolved RF-10784.
---------------------------------
Assignee: Nick Belaevski
Resolution: Won't Fix
JSF itself does exactly the same (Mojarra 1.2, UIViewRoot#broadcastEvents(FacesContext,
PhaseId)): http://pastebin.com/z9EwJfBq
Unfortunately, this is how JSF 1.2 specification requires to handle exceptions. MyFaces
implementation extends this by providing custom exception handler functionality, however
this is too big enhancement for the branch in maintenance mode, unless somebody provides a
patch.
JSF 2/RF 4 doesn't have such issue.
AjaxViewRoot swallows NoSuchElementException from by the application
code
-------------------------------------------------------------------------
Key: RF-10784
URL: https://issues.jboss.org/browse/RF-10784
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.3.2.SR1
Reporter: Vladimir Kravchenko
Assignee: Nick Belaevski
AjaxViewRoot.processEvents() swallows NoSuchElemntException thrown by an apllication
code, due to too wide catch block:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
} catch (NoSuchElementException e) {
havePhaseEvents = false;
}
}
}
{code}
http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/framework/impl/...
A NoSuchElemtException thrown inside "source.broadcast(event);" will be
swallowed by the catch block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:22 p.m.
New subject: [JBoss JIRA] Commented: (RF-10784) AjaxViewRoot swallows NoSuchElementException from by the application code
[
https://issues.jboss.org/browse/RF-10784?page=com.atlassian.jira.plugin.s...
]
Vladimir Kravchenko commented on RF-10784:
------------------------------------------
What I mean is the following change:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
} catch (NoSuchElementException e) {
havePhaseEvents = false;
break;
}
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
}
}
{code}
The "processEvents" method may swallow NoSuchElementException thrown by
"phaseEventsQueue.remove()" call, but not ones that are thrown inside the
"source.broadcast(event);" call.
Will it break JSF specification?
AjaxViewRoot swallows NoSuchElementException from by the application
code
-------------------------------------------------------------------------
Key: RF-10784
URL: https://issues.jboss.org/browse/RF-10784
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.3.2.SR1
Reporter: Vladimir Kravchenko
Assignee: Nick Belaevski
AjaxViewRoot.processEvents() swallows NoSuchElemntException thrown by an apllication
code, due to too wide catch block:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
} catch (NoSuchElementException e) {
havePhaseEvents = false;
}
}
}
{code}
http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/framework/impl/...
A NoSuchElemtException thrown inside "source.broadcast(event);" will be
swallowed by the catch block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:24 p.m.
New subject: [JBoss JIRA] Reopened: (RF-10784) AjaxViewRoot swallows NoSuchElementException from by the application code
[
https://issues.jboss.org/browse/RF-10784?page=com.atlassian.jira.plugin.s...
]
Vladimir Kravchenko reopened RF-10784:
--------------------------------------
AjaxViewRoot swallows NoSuchElementException from by the application
code
-------------------------------------------------------------------------
Key: RF-10784
URL: https://issues.jboss.org/browse/RF-10784
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.3.2.SR1
Reporter: Vladimir Kravchenko
Assignee: Nick Belaevski
AjaxViewRoot.processEvents() swallows NoSuchElemntException thrown by an apllication
code, due to too wide catch block:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
} catch (NoSuchElementException e) {
havePhaseEvents = false;
}
}
}
{code}
http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/framework/impl/...
A NoSuchElemtException thrown inside "source.broadcast(event);" will be
swallowed by the catch block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:49 p.m.
New subject: [JBoss JIRA] Updated: (RF-10784) AjaxViewRoot swallows NoSuchElementException from by the application code
[
https://issues.jboss.org/browse/RF-10784?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10784:
--------------------------------
Fix Version/s: 3.Future
Nope, this is fine.
AjaxViewRoot swallows NoSuchElementException from by the application
code
-------------------------------------------------------------------------
Key: RF-10784
URL: https://issues.jboss.org/browse/RF-10784
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.3.2.SR1
Reporter: Vladimir Kravchenko
Assignee: Nick Belaevski
Fix For: 3.Future
AjaxViewRoot.processEvents() swallows NoSuchElemntException thrown by an apllication
code, due to too wide catch block:
{code}
public void processEvents(FacesContext context,
EventsQueue phaseEventsQueue, boolean havePhaseEvents) {
FacesEvent event;
while (havePhaseEvents) {
try {
event = (FacesEvent) phaseEventsQueue.remove();
UIComponent source = event.getComponent();
try {
source.broadcast(event);
} catch (AbortProcessingException e) {
if (_log.isErrorEnabled()) {
UIComponent component = event.getComponent();
String id = null != component ? component
.getClientId(context) : "";
_log.error(
"Error processing faces event for the component "
+ id, e);
}
}
} catch (NoSuchElementException e) {
havePhaseEvents = false;
}
}
}
{code}
http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/framework/impl/...
A NoSuchElemtException thrown inside "source.broadcast(event);" will be
swallowed by the catch block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5029
days inactive
5029
days old
richfaces-issues@lists.jboss.org
4 comments
2 participants
participants (2)
-
Nick Belaevski (JIRA) -
Vladimir Kravchenko (JIRA)