11:57 p.m.
Brian Leathem created RF-12029:
----------------------------------
Summary: AbstractTogglePanel should extend UIRepeat, instead of UIOutput
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat, instead
of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 a.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12029:
------------------------------------
Summary of a discussion in IRC:
{quote}
(02:35:14 AM) blabno: AbstractTogglePanel was extending UIOutput (i guess for holding info
about selected tab), i've changed this (basically c'n'p necessary stuff from
UIOutput to ATogP) and now ATogP extends UIRepeat
...
(08:31:55 AM) blabno: ok, I understand, well, as with carousel component i've noticed
that there are use cases where component may be used as iterative or non-iterative
(08:32:26 AM) blabno: i.e. we want to have fixed 3 tabs, so we hardcode
<tabPanel><tab/><tab/><tab/></tabPanel
(08:32:50 AM) blabno: but sometimes we want to have many tabs
(08:33:03 AM) blabno: so we do <tabPanel value=""
var=""><tab/></tabPanel>
(08:33:22 AM) blabno: this is how i've done it for carousel and it works like a charm
(08:33:42 AM) blabno: however here with those tabs it's very hard
(08:34:17 AM) blabno: especiale because of that getActiveItem method (used in many places
to see if tab should be executed,updated,validated,etc)
(08:35:18 AM) blabno: so the datamodel (in case of iterative case) is being visited over
and over again
(08:36:33 AM) blabno: the impl of that method is very annoying
(08:36:51 AM) blabno: first it gets activeItem which is string
(08:37:12 AM) blabno: then runs over all tabs to see if that tab is disabled
(08:37:29 AM) blabno: and in such case it switches to the first item
(08:37:46 AM) blabno: but anyways, optimization can be done later, right now i'm
having problem with ajax
(08:37:54 AM) blabno: client and server switches work great
(08:40:25 AM) blabno: in short the problem is with switching tab in ajax mode
(08:41:18 AM) bleathem: what goes wrong?
(08:41:26 AM) blabno: partialContext first wants to estblish which components should be
executed, and only later it sets submited value (selected tab) so the new tab is not
rendered in response
(08:41:56 AM) blabno: because (i suspect) getActiveItem points to old tab and is changed
when submitted value is set
(08:42:23 AM) blabno: and that getActiveItem is used in determining if tab should be
processed
(08:43:07 AM) blabno: i must have messed sth up, cause old version of component worked,
but i'm stuck and fresh eye would be handy
{quote}
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12029:
------------------------------------
To get the error to work:
{quote}
uncomment dynamic panel with ajax fragment on facelet in demo
{quote}
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12029:
------------------------------------
Consider the dynamicly rendered tabs in the facelet:
{code}
<a4j:outputPanel id="output" ajaxRendered="true">
Validation failed:#{facesContext.validationFailed}
</a4j:outputPanel>
<h:form id="form">
<h1>Dynamic tab panel</h1>
<ou:tabPanel id="tabPanel" switchType="ajax"
value="#{dynamicTabPanelBean.ladies}" var="person"
rowKeyVar="index">
<ou:tab id="tab" name="#{person.name}">
#{person.name}
<h:inputText id="birthday"
value="#{person.birthDate}">
<f:convertDateTime pattern="yyyy-mm-dd"/>
</h:inputText>
</ou:tab>
</ou:tabPanel>
</h:form>
{code}
Switching tabs in ajax modes takes two clicks - the tab does not change until the 2nd
click.
The response on the first click:
{code:title="Response after the first click on tab 1 (formatted for clarity)}
<?xml version='1.0' encoding='UTF-8'?>
<partial-response>
<changes>
<update id="output"><![CDATA[<span
id="output">Validation failed:false</span>]]></update>
<update
id="javax.faces.ViewState"><![CDATA[3037308798212741137:-1743374825880192262]]></update>
</changes>
</partial-response>
{code}
the response on the second click:
{code:title="Response after the second click on tab 1 (formatted for clarity)}
<?xml version='1.0' encoding='UTF-8'?>
<partial-response>
<changes>
<update id="output"><![CDATA[<span
id="output">Validation failed:false</span>]]></update>
<update id="form:tabPanel:1:tab">
<![CDATA[
<div id="form:tabPanel:1:tab" class="rf-tab">
<div class="rf-tab-cnt"
id="form:tabPanel:1:tab:content">
Ayn Rand
<input id="form:tabPanel:1:birthday"
type="text" name="form:tabPanel:1:birthday"
value="1905-00-02" />
</div>
<script type="text/javascript">new
RichFaces.ui.Tab("form:tabPanel:1:tab",{"index":1,"leave":null,"togglePanelId":"form:tabPanel","switchMode":"ajax","name":"Ayn
Rand","enter":null,"disabled":false} )</script>
</div>
]]>
</update>
<update
id="javax.faces.ViewState"><![CDATA[3037308798212741137:-1743374825880192262]]></update>
<extension id="org.richfaces.extension">
<complete>RichFaces.$('form:tabPanel').onCompleteHandler('Ayn
Rand');;</complete>
</extension>
</changes>
</partial-response>
{code}
Notice how the response content only reflects the tab change in the response of the 2nd
click
Note: For both the first and second response, the executeIds in the
ExtendedPartialViewContext is:
{code}
form:tabPanel:1:tab
form:tabPanel
{code}
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:58 a.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12029:
------------------------------------
The TogglePanelRenderer#doDecode method calls the TabPanelRenderer#isSubmitted method
before adding the panel renderId to the PartialViewContext#renderIds.
On the first tab submit, TabPanelRenderer#isSubmitted returns false, because the call:
{code:title=TabPanelRenderer, line:90}
panel.getItem(panel.getSubmittedActiveItem())
{code}
Does not return a panel item that corresponds to the parameter.
The method/visitor that retrieves the tab panels by number needs to be looked at more
closely, and corrected.
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12029:
---------------------------------
There is feature request for very similar concept: RF-9443
from forum reference:
{quote}
{code}
<h:form>
<rich:accordion>
<ui:repeat value="#{navigationBean.navigationCategories.entrySet}"
var="category">
<rich:accordionItem header="#{category.key}">
#{category.value}
</rich:accordionItem>
</ui:repeat>
</rich:accordion>
</h:form>
{code}
{quote}
The proposed API seems better, since it
* allows to combine static and dynamic tabs
* separates the iteration and switchable panel logic
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč edited comment on RF-12029 at 3/15/12 11:39 AM:
-----------------------------------------------------------
There is feature request for very similar concept: RF-9443
from forum reference:
{quote}
{code}
<h:form>
<rich:accordion>
<ui:repeat value="#{navigationBean.navigationCategories.entrySet}"
var="category">
<rich:accordionItem header="#{category.key}">
#{category.value}
</rich:accordionItem>
</ui:repeat>
</rich:accordion>
</h:form>
{code}
{quote}
The proposed API seems better, since it
* allows to combine static and dynamic tabs
* separates the iteration and switchable panel logic
(we can discuss the other approach in RF-9443)
was (Author: lfryc):
There is feature request for very similar concept: RF-9443
from forum reference:
{quote}
{code}
<h:form>
<rich:accordion>
<ui:repeat value="#{navigationBean.navigationCategories.entrySet}"
var="category">
<rich:accordionItem header="#{category.key}">
#{category.value}
</rich:accordionItem>
</ui:repeat>
</rich:accordion>
</h:form>
{code}
{quote}
The proposed API seems better, since it
* allows to combine static and dynamic tabs
* separates the iteration and switchable panel logic
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:44 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Bernard Labno commented on RF-12029:
------------------------------------
Lukas, Which API seems better, the one with built in value/var or with nested ui:repeat?
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12029:
---------------------------------
I consider the one with nested {{ui:repeat}} better since it's more flexible - allows
to use combination of dynamic/static tabs.
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:35 p.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12029:
---------------------------------
This issue has been discussed on team meeting, the minutes are here:
4. Dynamic switchable panels (bleathem, 14:50:46)
http://transcripts.jboss.org/meeting/irc.freenode.org/richfaces/2012/rich...
This issue is concurrent request for RF-9443.
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Assignee: Bernard Labno
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 a.m.
[
https://issues.jboss.org/browse/RF-12029?page=com.atlassian.jira.plugin.s...
]
Brian Leathem resolved RF-12029.
--------------------------------
Assignee: (was: Bernard Labno)
Resolution: Duplicate Issue
This issue has been resolved with RF-9443
AbstractTogglePanel should extend UIRepeat, instead of UIOutput
---------------------------------------------------------------
Key: RF-12029
URL: https://issues.jboss.org/browse/RF-12029
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-output
Reporter: Brian Leathem
Valid uses exist for dynamically generating rich:tab, rich:togglePanelItem,
rich:accordionItem. Current techniques for supporting this use case involve using
c:forEach, which is a problem since c: tags are processed too early to nicely support
dynamic use cases.
One idea to support this use case, is to have AbstractTogglePanel extend UIRepeat,
instead of UIOutput to better dynamic child components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4182
days inactive
4426
days old
richfaces-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Bernard Labno (JIRA) -
Brian Leathem (JIRA)
-
Lukáš Fryč (JIRA)