[ http://jira.jboss.com/jira/browse/RF-2772?page=comments#action_12404670 ] Adam Jenkins commented on RF-2772: ---------------------------------- More Information: It seems that the divs for the dynamic components are being rendered ok, but they linked to the panelBar in the javascript that follows. With the following code snipped <t:panelGroup colspan="2"> <rich:panelBar id="claim-panel-bar"> <rich:panelBarItem id="t1" label="test1"> <h:outputText value="test"/> </rich:panelBarItem> <rich:panelBarItem id="t2" label="test2"> <h:outputText value="test"/> </rich:panelBarItem> <rich:panelBarItem id="t3" label="test3"> <h:outputText value="test"/> </rich:panelBarItem> <a4j:repeat id="claim-history-repeat" value="#{generalInformation.claimHistory}" var="item" binding="#{generalInformation.claimHistoryRepeat}"> <rich:panelBarItem id="claim-panel" label="some div"> some stuff </rich:panelBarItem> </a4j:repeat> </rich:panelBar> </t:panelGroup> I get the following output: <div class="dr-pnlbar rich-panelbar dr-pnlbar-b " id="customerInformationForm:claim-panel-bar" style="padding: 0px; height: 100%; width: 100%; "><div class="dr-pnlbar rich-panelbar dr-pnlbar-ext " id="customerInformationForm:t1"><div class="dr-pnlbar-h rich-panelbar-header " style=";">test1</div><div class="dr-pnlbar-h-act rich-panelbar-header-act " style=";;;;display: none;">test1</div><div style="display: none; width: 100%;"><table cellpadding="0" style="height: 100%;" width="100%"><tbody><tr><td class="dr-pnlbar-c rich-panelbar-content " style=";">test</td></tr></tbody></table></div></div><div class="dr-pnlbar rich-panelbar dr-pnlbar-ext " id="customerInformationForm:t2"><div class="dr-pnlbar-h rich-panelbar-header " style=";">test2</div><div class="dr-pnlbar-h-act rich-panelbar-header-act " style=";;;;display: none;">test2</div><div style="display: none; width: 100%;"><table cellpadding="0" style="height: 100%;" width="100%"><tbody><tr><td class="dr-pnlbar-c rich-panelbar-content " style=";">test</td></tr></tbody></table></div></div><div class="dr-pnlbar rich-panelbar dr-pnlbar-ext " id="customerInformationForm:t3"><div class="dr-pnlbar-h rich-panelbar-header " style=";">test3</div><div class="dr-pnlbar-h-act rich-panelbar-header-act " style=";;;;display: none;">test3</div><div style="display: none; width: 100%;"><table cellpadding="0" style="height: 100%;" width="100%"><tbody><tr><td class="dr-pnlbar-c rich-panelbar-content " style=";">test</td></tr></tbody></table></div></div><div class="dr-pnlbar rich-panelbar dr-pnlbar-ext " id="customerInformationForm:claim-history-repeat:0:claim-panel"><div class="dr-pnlbar-h rich-panelbar-header " style=";">some div</div><div class="dr-pnlbar-h-act rich-panelbar-header-act " style=";;;;display: none;">some div</div><div style="display: none; width: 100%;"><table cellpadding="0" style="height: 100%;" width="100%"><tbody><tr><td class="dr-pnlbar-c rich-panelbar-content " style=";"></td></tr></tbody></table></div></div><input id="customerInformationForm:claim-panel-bar_panelBarInput" name="customerInformationForm:claim-panel-bar" type="hidden" /><script type="text/javascript"><!-- new Richfaces.PanelBar('customerInformationForm:claim-panel-bar',{'onitemchange':'','items':[{'onleave':'','id':'customerInformationForm:t1','onenter':''} ,{'onleave':'','id':'customerInformationForm:t2','onenter':''} ,{'onleave':'','id':'customerInformationForm:t3','onenter':''} ] } ); //--></script></div> (sorry for the code bomb)... the important bit seems to be <script type="text/javascript"><!-- new Richfaces.PanelBar('customerInformationForm:claim-panel-bar',{'onitemchange':'','items':[{'onleave':'','id':'customerInformationForm:t1','onenter':''} ,{'onleave':'','id':'customerInformationForm:t2','onenter':''} ,{'onleave':'','id':'customerInformationForm:t3','onenter':''} ] } ); //--></script> It links through the static items, but not the dynamic ones. I'm about to dive into the code and see if I can see where and why this is. If anyone can offer some input now about how and why this might be happening, what classes to look at an how you would like it fixed I'd really appreciate it. Cheers Adam -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/RF-2772?page=comments#action_12404673 ] Adam Jenkins commented on RF-2772: ---------------------------------- More Information: The offending piece of code seems to be in PanelBarRendererBase.java, method getScriptPanelBarItems. The code iterates over the children and only adds the necessary javascript bindings if the child is an instanceof UIPanelBarItem. I'm thinking of amending this class so that it also checks for the ajax4jsf repeat tag....I don't imagine this will cause a dependency problem as there is already a dependency between richfaces and a4j. Can anyone think of a reason why this is not an advisable solution to this issue? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/RF-2772?page=comments#action_12404689 ] Adam Jenkins commented on RF-2772: ---------------------------------- Disregard last comment I modified the code so it does a string match on Class.getName() (hence no instanceof dependencies). I don't need any functionality beyond UIComponent.getChildren -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/RF-2772?page=comments#action_12404698 ] Adam Jenkins commented on RF-2772: ---------------------------------- Done and Dusted!!!! what a day ok, I've modified the PanelBar renderer to handle if it has a SequenceDataAdaptor client (so you can use a4j:repeat and dynamically add bar items to the panel bar). I'll prepare a patch tomorrow (Aussie time) and attach it to this jira for consideration...happy to change it in anyway you need...would be nice to get it into 3.1.4 next release? don't know what or when that is.... going home.... ...need beer -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/RF-2772?page=all ] Adam Jenkins updated RF-2772: ----------------------------- Attachment: RF-2772.patch Can someone review this patch and offer suggestions please? Cheers Adam -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/RF-2772?page=all ] Ilya Shaikovsky resolved RF-2772. --------------------------------- Resolution: Rejected usage c:forEach is proper way. a4j:repeat should not work for this case. This was explained at forum many times. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/RF-2772?page=com.atlassian.jira.plugin... ] Daniel Murygin commented on RF-2772: ------------------------------------ I'am using 3.3.1.GA and Adams example still doesn't work. Does the path find it's way to the subversion repository? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira