[JBoss JIRA] (RF-11806) UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for existing flows
12:22 p.m.
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Priority: Critical
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:22 p.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Marius Bogoevici reassigned RF-11806:
-------------------------------------
Assignee: Brian Leathem
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Brian Leathem
Priority: Critical
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:36 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Brian Leathem updated RF-11806:
-------------------------------
Fix Version/s: 4.1.1.Final
Description:
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
was:
The fix introduced for 4.1.0.CR2 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Brian Leathem
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:36 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Marius Bogoevici updated RF-11806:
----------------------------------
Description:
The fix introduced for 4.1.0.CR2 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
was:
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Brian Leathem
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR2 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:40 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Brian Leathem reassigned RF-11806:
----------------------------------
Assignee: Lukáš Fryč (was: Brian Leathem)
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-11806:
---------------------------------
I have conceived current solution from following blogpost:
http://blog.kennardconsulting.com/2009/11/safely-manipulating-component-t...
resp. revisited solution:
http://blog.kennardconsulting.com/2010/10/safely-manipulating-component-t...
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-11806:
---------------------------------
From the following snippet in reply I can see it's safe to use
component's contructor for reaching UIViewRoot:
http://java.net/jira/browse/JAVASERVERFACES-1383?focusedCommentId=74475&a...
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:41 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč edited comment on RF-11806 at 12/13/11 7:39 AM:
-----------------------------------------------------------
I have designed fix for this issue:
It is based on moving registration for
{{UIViewRoot#subscribeForViewEvent(...)}}
from constructor
to the {{PostAddToViewEvent}} time.
Component itself needs to register for events ({{PostAddToViewEvent}} and
{{PostRestoreStateEvent}}).
was (Author: lfryc):
I have designed fixed for this issue:
It is based on moving registration for
{{UIViewRoot#subscribeForViewEvent(...)}}
from constructor
to the {{PostAddToViewEvent}} time.
Component itself needs to register for events ({{PostAddToViewEvent}} and
{{PostRestoreStateEvent}}).
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:43 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-11806:
---------------------------------
Marius, Brian, review please my pull request before integrating to the code-base.
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-11806:
---------------------------------
I have verified the proposed modification fixes properly RF-11423, RF-10859 and RF-11675.
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 a.m.
[
https://issues.jboss.org/browse/RF-11806?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-11806:
---------------------------------
Work has been merged to {{develop}},
Marius, could you please re-verify issue with current {{4.1.1-SNAPSHOT}}?
UIDataAdaptor breaks with Spring Webflow 2.3 when rendering pages for
existing flows
------------------------------------------------------------------------------------
Key: RF-11806
URL: https://issues.jboss.org/browse/RF-11806
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.1.0.CR2
Reporter: Marius Bogoevici
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.1.1.Final
The fix introduced for 4.1.0.CR1 by adding event registration to the constructor:
{code}
public UIDataAdaptor() {
super();
getFacesContext().getViewRoot().subscribeToViewEvent(PreRenderViewEvent.class,
this);
}
{code}
breaks when Spring Webflow restores the view in the middle of the flow with a NPE. E.g.
when a data table is constructed, the viewRoot is not yet set on the current thread, which
causes the exception above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4686
days inactive
4694
days old
richfaces-issues@lists.jboss.org
10 comments
7 participants
participants (7)
-
Brian Leathem (Assigned) (JIRA) -
Brian Leathem (Updated) (JIRA)
-
Lukáš Fryč (Commented) (JIRA)
-
Lukáš Fryč (Issue Comment Edited) (JIRA)
-
Marius Bogoevici (Assigned) (JIRA)
-
Marius Bogoevici (Created) (JIRA)
-
Marius Bogoevici (Updated) (JIRA)