[JBoss JIRA] (RF-12550) Tab panel: dynamically created tabs don't work inside accordion and tab panel
11:14 a.m.
Pavol Pitonak created RF-12550:
----------------------------------
Summary: Tab panel: dynamically created tabs don't work inside accordion
and tab panel
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:36 a.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12550:
---------------------------------
The action called by {{UICommandButton}} is called twice because there are two
{{ActionEvent}}s issued on PROCESS_DECODES phase.
I analysed the stacks of those calls
https://gist.github.com/3938501
and a cause is on following lines:
first time called {{visitTree}}:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
second time:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
I think the tree walker alghoritm should return {{COMPLETE}} here.
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:38 a.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč edited comment on RF-12550 at 10/23/12 8:37 AM:
-----------------------------------------------------------
The action called by {{UICommandButton}} is called twice because there are two
{{ActionEvent}}s issued on PROCESS_DECODES phase.
I analysed the stacks of those calls
https://gist.github.com/3938501
and a cause is on following lines:
first time called {{visitTree}}:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
second time:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
I think the tree walker alghoritm should return {{COMPLETE}} here (current resurned visit
result is {{ACCEPT}}).
was (Author: lfryc):
The action called by {{UICommandButton}} is called twice because there are two
{{ActionEvent}}s issued on PROCESS_DECODES phase.
I analysed the stacks of those calls
https://gist.github.com/3938501
and a cause is on following lines:
first time called {{visitTree}}:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
second time:
https://github.com/jboss/jboss-jsf-api_spec/blob/jboss-jsf-api_2.1_spec-2...
I think the tree walker alghoritm should return {{COMPLETE}} here.
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 a.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Brian Leathem updated RF-12550:
-------------------------------
Fix Version/s: 4.3.0.M2
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
Fix For: 4.3.0.M2
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 a.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Brian Leathem reassigned RF-12550:
----------------------------------
Assignee: Brian Leathem
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
Assignee: Brian Leathem
Fix For: 4.3.0.M2
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:07 p.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Brian Leathem resolved RF-12550.
--------------------------------
Resolution: Done
Great analysis Lukas - thanks!
To resolve this issue, I prevented doubling visits to TogglePanel children druing
processDecodes, processValidations, and processUpdates calls by having these methods
return VisitResult.REJECT to prevent the visit call from iterating over the children.
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
Assignee: Brian Leathem
Fix For: 4.3.0.M2
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 a.m.
[
https://issues.jboss.org/browse/RF-12550?page=com.atlassian.jira.plugin.s...
]
Juraj Húska closed RF-12550.
----------------------------
Tab panel: dynamically created tabs don't work inside accordion
and tab panel
-----------------------------------------------------------------------------
Key: RF-12550
URL: https://issues.jboss.org/browse/RF-12550
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes, regression
Affects Versions: 4.3.0.M2
Environment: RichFaces 4.3.0-SNAPSHOT
Metamer 4.3.0-SNAPSHOT
Mojarra 2.1.7
JBoss AS 7.1.2.Final-redhat-1
Java(TM) SE Runtime Environment 1.6.0_32-b05 @ Linux
Chrome 22.0.1229.94 @ Linux x86_64
Reporter: Pavol Pitonak
Assignee: Brian Leathem
Fix For: 4.3.0.M2
# deploy Metamer and open one of these pages
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
##
http://localhost:8080/metamer/faces/components/richTabPanel/addTab2.xhtml...
# click *[a4j Create tab]* button
result:
* two tabs are created, one new tab is expected
* works fine in 4.3.0.M1
* works fine in other templates
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4455
days inactive
4459
days old
richfaces-issues@lists.jboss.org
6 comments
4 participants
participants (4)
-
Brian Leathem (JIRA) -
Juraj Húska (JIRA)
-
Lukáš Fryč (JIRA)
-
Pavol Pitonak (JIRA)