[JBoss JIRA] Created: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
10:12 a.m.
UIRichMessages doesn't render global messages when globalOnly is false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component
Affects Versions: 3.3.1, 3.3.0
Reporter: Michael Seghers
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [JBoss JIRA] Updated: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski updated RF-7634:
-------------------------------
Original Estimate: (was: 30 minutes)
Remaining Estimate: (was: 30 minutes)
Component/s: component-output
(was: component)
Fix Version/s: 3.3.2.CR1
Assignee: Alex Kolonitsky
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Alex Kolonitsky
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:18 p.m.
New subject: [JBoss JIRA] Resolved: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski resolved RF-7634.
--------------------------------
Resolution: Cannot Reproduce Bug
Assignee: Nick Belaevski (was: Alex Kolonitsky)
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 p.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Michael Seghers commented on RF-7634:
-------------------------------------
If I add a global message to the FacesContext, and put a <rich:messages/> on my
page, I do not get the message. This is in my opinion logical, since we the get in the
"else" condition, which only considers message for components, not the global
ones. I checked this in 3.3.0 and looked at the code in 3.3.1 and saw no changes. If I use
a regular <h:messages/> tag, the message appears.
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski commented on RF-7634:
------------------------------------
http://fisheye.jboss.org/browse/~raw,r=12351/RichFaces/trunk/ui/message/s...
Sorry, I don't see what's wrong with the code. Here is the execution branch where
global messages are handled if globalOnly = "false":
Iterator<String> clientIdsWithMessages = context
.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(),
severenities);
}
Also I cannot reproduce the issue - global messages are shown even if I set globalOnly =
"false".
I'll check one possible problem now and report...
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:41 p.m.
New subject: [JBoss JIRA] Reopened: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski reopened RF-7634:
--------------------------------
<rich:messages for="#{null}" globalOnly="false" />
<h:form id="form">
<a4j:commandLink value="generate message"
action="#{forum5Bean.generateMessage}" />
</h:form>
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:43 p.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski commented on RF-7634:
------------------------------------
Setting "for" to null using EL (e.g. in Facelets templates) leads to empty
String coming out as attribute value - so no messages are shown.
Michael,
Is it your case?
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 a.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Michael Seghers commented on RF-7634:
-------------------------------------
No, it is not, I just use the tag <rich:messages/> as written here to reproduce
this. I will investigate the issue further on Monday, and report back to you. I still
can't see how global messages (messages without client id in my understanding) are
added, since they are only added when globalOnly is true. Am I understanding things
wrong?
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 a.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski commented on RF-7634:
------------------------------------
context.getClientIdsWithMessages() returns null entry for global messages, that's how
they're added
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.CR1
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 p.m.
New subject: [JBoss JIRA] Updated: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski updated RF-7634:
-------------------------------
Fix Version/s: 3.3.2.GA
(was: 3.3.2.CR1)
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.GA
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 a.m.
New subject: [JBoss JIRA] Commented: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Michael Seghers commented on RF-7634:
-------------------------------------
Hello Nick,
this is my code to test the issue:
in the backing bean:
public void addGlobalAndFieldMessage(final ActionEvent event) {
FacesContext facesContext = FacesContext.getCurrentInstance();
facesContext.addMessage(null, new FacesMessage("summary global",
"detail global"));
facesContext.addMessage("field", new FacesMessage("summary
field", "detail field"));
}
on the page:
<rich:messages id="messageArea" />
<h:form>
<h:inputText id="field"/>
<h:commandButton
actionListener="#{testBackingBean.addGlobalAndFieldMessage}" value="show
messages"/>
</h:form>
result is I only see the message "summary field", but I should also get
"summary global", right?
when I add globalOnly="true" on the messages component, I obviously only see the
"summary global" which is as expected.
Could you try my code?
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Fix For: 3.3.2.GA
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 a.m.
New subject: [JBoss JIRA] Resolved: (RF-7634) UIRichMessages doesn't render global messages when globalOnly is false
[
https://jira.jboss.org/jira/browse/RF-7634?page=com.atlassian.jira.plugin...
]
Nick Belaevski resolved RF-7634.
--------------------------------
Fix Version/s: (was: 3.3.2.GA)
Resolution: Cannot Reproduce Bug
Your code works ok for me with RichFaces 3.3.1.GA/JSF RI 1.2_12 - both messages are output
ok
UIRichMessages doesn't render global messages when globalOnly is
false
----------------------------------------------------------------------
Key: RF-7634
URL: https://jira.jboss.org/jira/browse/RF-7634
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0, 3.3.1
Reporter: Michael Seghers
Assignee: Nick Belaevski
Taken following code snippet from the UIRichMessages.getMessages(FacesContext)
if (isGlobalOnly()) {
addMessagesForId(context, null, severenities);
} else if (null != forInputId) {
UIComponent componentFor = RendererUtils.getInstance()
.findComponentFor(context, this, forInputId);
if (null != componentFor) {
addMessagesForId(context, componentFor.getClientId(context), severenities);
}
} else {
Iterator<String> clientIdsWithMessages = context.getClientIdsWithMessages();
while (clientIdsWithMessages.hasNext()) {
addMessagesForId(context, clientIdsWithMessages.next(), severenities);
}
}
This means that the call to addMessagesForId(context, null, severenities) is only called
in when globalOnly is true, but it should also be called in the last else part, where all
messages should be rendered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5565
days inactive
5597
days old
richfaces-issues@lists.jboss.org
11 comments
2 participants
participants (2)
-
Michael Seghers (JIRA) -
Nick Belaevski (JIRA)