[JBoss JIRA] Created: (RF-8907) Tag handler generation fails if @Attribute has signature property set
4:53 p.m.
Tag handler generation fails if @Attribute has signature property set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:46 p.m.
New subject: [JBoss JIRA] Updated: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Bernard Labno updated RF-8907:
------------------------------
Attachment: taghandler.ftl.patch
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:27 a.m.
New subject: [JBoss JIRA] Assigned: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Nick Belaevski reassigned RF-8907:
----------------------------------
Assignee: Alexander Smirnov
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 a.m.
New subject: [JBoss JIRA] Commented: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov commented on RF-8907:
---------------------------------------
Provided path is not correct ( the signature property is never empty , so checking for its
existense does not make sense ). The proper place is Model Validator that performs all
checks on model regardless of configuration source.
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:30 a.m.
New subject: [JBoss JIRA] Updated: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov updated RF-8907:
----------------------------------
Fix Version/s: 4.0.0.Milestone2
Additional tasks to handle MethodExpression-type attributes:
1) convert parameter list to Signature bean with return type.
2) repalce 2 boolean attributes methodBinding/binding to one with Enum type.
3) Check attribute type in validator.
4) improve TagHandler template - eliminate dependency form utils class and generate proper
code directly.
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:14 p.m.
New subject: [JBoss JIRA] Commented: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Bernard Labno commented on RF-8907:
-----------------------------------
Alexander, I would not post this if I haven't run into this issue. The signature is
null sometimes! Try building ui-sandbox/schedule.
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:44 a.m.
New subject: [JBoss JIRA] Commented: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov commented on RF-8907:
---------------------------------------
Ok, the solution seems still uncomplete. I've also changed annotation processor code
to avoid null values, but still missing return value , as it mentioned at
http://community.jboss.org/message/552114#552114.
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] Commented: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Bernard Labno commented on RF-8907:
-----------------------------------
What is incomplete? Could you explain, please?
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 p.m.
New subject: [JBoss JIRA] Updated: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Jay Balunas updated RF-8907:
----------------------------
Fix Version/s: Future_4.X
(was: 4.0.0.Milestone2)
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:24 a.m.
New subject: [JBoss JIRA] Commented: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://jira.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov commented on RF-8907:
---------------------------------------
I've found much more issues in the tag handler generator. I changed it to properly use
returnType attribute, but some tests still failing. hope I'll finish it on Monday
07/26.
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://jira.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: taghandler.ftl.patch
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 a.m.
New subject: [JBoss JIRA] Updated: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://issues.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.sy...
]
Alexander Smirnov updated RF-8907:
----------------------------------
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://issues.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: taghandler.ftl.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 a.m.
New subject: [JBoss JIRA] Resolved: (RF-8907) Tag handler generation fails if @Attribute has signature property set
[
https://issues.jboss.org/browse/RF-8907?page=com.atlassian.jira.plugin.sy...
]
Alexander Smirnov resolved RF-8907.
-----------------------------------
Resolution: Done
Tag handler generation fails if @Attribute has signature property
set
---------------------------------------------------------------------
Key: RF-8907
URL: https://issues.jboss.org/browse/RF-8907
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.0.0.Alpha2
Reporter: Bernard Labno
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: taghandler.ftl.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
Following does not fail if signature property is omitted, but it is unacceptable.
@JsfComponent(tag = @Tag(name = "schedule",
handler = "org.richfaces.view.facelets.html.ScheduleHandler",
generate = true,
type = TagType.Facelets))
public abstract class AbstractSchedule extends UIComponentBase
implements ScheduleCommonViewAttributes, ScheduleListenerEventsProducer,
AjaxComponent {
@Attribute(signature = @Signature(parameters = ScheduleItemMoveEvent.class, returnType =
Boolean.class))
public abstract MethodExpression getItemMoveListener();
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4865
days inactive
5051
days old
richfaces-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Alexander Smirnov (JIRA) -
Bernard Labno (JIRA)
-
Jay Balunas (JIRA)
-
Nick Belaevski (JIRA)