[
https://issues.jboss.org/browse/RF-13629?page=com.atlassian.jira.plugin.s...
]
Juraj Húska edited comment on RF-13629 at 5/16/14 6:38 AM:
-----------------------------------------------------------
The issue, with vertical movement, described in
[
comment|https://issues.jboss.org/browse/RF-13629?focusedCommentId=1296804...]
is fixed with your recent commit.
However, here are some other issues to consider:
* When _autosized == true_, performance of moving the popupPanel on Firefox (29) is very
bad. It is not a smooth transition at all, affecting usability a lot. It is as well
regression against 4.3.6.Final. - Chrome works just ok
* when _height_ or _width_ is set to 0, then RF-10251 can not be reproduced anymore,
however, another issue occurs - popupPanel is rendered with width as big as screen, and it
is adjusted to the correct one, once it is moved (resembles RF-13616).
General comments
* IMHO width and height like attributes requires refactoring, validation of the values
user set to them, so for example it will not be possible to set _width_ to 0. The VDL doc
for some attributes (e.g. {{minHeight}}) is describing this, however, it does not check
the values at all.
was (Author: jhuska):
The issue, with vertical movement, described in
[
comment|https://issues.jboss.org/browse/RF-13629?focusedCommentId=1296804...]
is fixed with your recent commit.
However, here are some other issues to consider:
* When _autosized == true_, performance of moving the popupPanel on Firefox (29) is very
bad. It is not a smooth transition at all, affecting usability a lot. It is as well
regression against 4.3.6.Final. - Chrome works just ok
* when _height_ or _width_ is set to 0, then RF-10251 can not be reproduced anymore,
however, another issue occurs - popupPanel is rendered with width as big as screen, and it
is adjusted to the correct one, once it is moved (resembles RF-13616).
General comments
* IMHO width and height like attributes requires refactoring, validation of the values
user set to them, so for example it will not be possible to set _width_ to 0. The VDL doc
for some attributes (e.g. {{minHeight}}) is describing this, however, it does not check
the values at all.
popupPanel - minWidth, minHeight, maxWidth, maxHeight are not ignored
when autosize == true
-------------------------------------------------------------------------------------------
Key: RF-13629
URL:
https://issues.jboss.org/browse/RF-13629
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-output
Affects Versions: 4.3.7
Environment: Firefox
Reporter: Juraj Húska
Assignee: Brian Leathem
Priority: Critical
Labels: needs-qe, regression
Fix For: 4.5.0.Alpha3
Attachments: popupPanelGood.png, popupPanelWrong.png, sample.zip
Original Estimate: 1 hour
Remaining Estimate: 1 hour
In previous releases when attribute {{autosize == true}} attributes from $SUBJECT were
ignored. In {{4.3.7.}}, they are not.
When used together (does not really make sense IMHO, but maybe I am neglecting some use
case), the popup width is not adjusted automatically.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)