[
https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12860:
------------------------------------
Thanks for looking at this [~dlee606]!
To re-iterate, the steps are:
# Forked the appropriate RichFaces repository into your account
# Clone your fork to your local machine
# Make your changes and commit them
# Push your changes back to your fork
At that point you should see the button to initialte the pull request on the github page
of your fork.
Overriding 'Array.prototype.remove' causes JS error when
rich:accordion is used
-------------------------------------------------------------------------------
Key: RF-12860
URL:
https://issues.jboss.org/browse/RF-12860
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-output
Affects Versions: 4.3.0.Final
Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
Reporter: David Lee
Assignee: Brian Leathem
Labels: javascript, rich:accordionItem
Fix For: 4.3.2
Attachments: richfaces-sanbox.zip
Put the rich:accordionItem and rich:extendedDataTable on same page,
and just click on any column for sort.
The firebug will show an error:
items[i].__header is not a function
[Break On This Error]
h -= items[i].__header().outerHeight();
Looks like accordionItem.js line48 been triggered when sort:
$(document).one("javascriptServiceComplete", function () {
item.__fitToHeight(item.getTogglePanel());
});
And after this happened, my whole thing crashed.
Now more sortable or click for any action.
----
*from QA:*
When the following code is insterted to the page:
{code}
<script type="text/javascript">
//<![CDATA[
Array.prototype.remove = function(s) {
for (var i = 0; i < this.length; i++) {
if (s == this[i]) {
this.splice(i, 1);
}
}
};
//]]>
</script>
{code}
and rich:accordion is present, clicking on rich:accordionItem causes the following JS
error (from firebug):
{code}
items[i].__header is not a function
[Break On This Error]
h -= items[i].__header().outerHeight();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira