[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jay Balunas updated RF-11054: ----------------------------- Fix Version/s: 4.1.0.Milestone1 Affects Version/s: 4.0.0.Final Component/s: component-panels-layout-themes Forum Reference: http://community.jboss.org/thread/167372 (was: http://community.jboss.org/thread/167372) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jay Balunas updated RF-11054: ----------------------------- Component/s: base functionality Forum Reference: http://community.jboss.org/thread/167372 (was: http://community.jboss.org/thread/167372) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jay Balunas updated RF-11054: ----------------------------- Fix Version/s: 4.1.0.Final (was: 4.1.0.Milestone1) Forum Reference: http://community.jboss.org/thread/167372 (was: http://community.jboss.org/thread/167372) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jay Balunas updated RF-11054: ----------------------------- Fix Version/s: 4.1.0.Tracking (was: 4.1.0.Final) Forum Reference: http://community.jboss.org/thread/167372 (was: http://community.jboss.org/thread/167372) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-11054: ------------------------------- Fix Version/s: 4.Future (was: 4.1.0.Tracking) Forum Reference: http://community.jboss.org/thread/167372 (was: http://community.jboss.org/thread/167372) I wonder if this has more to do with dynamically changing the switchType after having created some tabs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jean ANDRE commented on RF-11054: --------------------------------- Moreover, even if you set the tab by program on action or action listener, during the rendering but after the deletion in your model, we still get the NPE on getActiveItem. Then setting the activeItem does not work in such case. FacesContext facesContext = FacesContext.getCurrentInstance(); UIComponent desktopTab = facesContext.getViewRoot().findComponent("tabbedForm:desktopTabPanel"); ((UITabPanel)desktopTab).setActiveItem("tab-search"); I've also tried to bind the tabPanel with a backing bean, it's seem that the F5 key show a memory corruption because the tabPanel does not appears except its content !!! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jean ANDRE commented on RF-11054: --------------------------------- This is an inconsistent bug that depends of the context. See also other comments from similar bug reports related to the getActiveItem. Why the programmer did not take in consideration that tab can be deleted, added, even moved and having a default behavior in case of the activeItem does not point to a valid item !? such has selecting the first tab if there or none if the TabPanel is empty !! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jean ANDRE commented on RF-11054: --------------------------------- There is definitively a link with the component outputPanel. When the outputPanel is removed, the exception may not appear. Removing the tab, by the onclick on a graphicImage has not the same effect as using the h:commandButton with action. In the second way, it does not trigger the NPE but the tag must be selected before to be able to delete the tab. Moreover, I've just try the version 4.1.0 M4, this version displays the following stack trace instead of the NPE - We do not have a NPE but an IndexOutBounds Exception. Setting the activeItem, was ever the way (binding, activeItem, by ViewRoot.findComponent,...), does not have any effect. Here is the stack trace. at javax.faces.webapp.FacesServlet.service(FacesServlet.java:606) at com.ibm.ws.webcontainer.servlet.ServletWrapper.service(ServletWrapper.java:1147) at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:722) at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:449) at com.ibm.ws.webcontainer.servlet.ServletWrapperImpl.handleRequest(ServletWrapperImpl.java:178) at com.ibm.ws.webcontainer.filter.WebAppFilterManager.invokeFilters(WebAppFilterManager.java:1020) at com.ibm.ws.webcontainer.servlet.CacheServletWrapper.handleRequest(CacheServletWrapper.java:87) at com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:883) at com.ibm.ws.webcontainer.WSWebContainer.handleRequest(WSWebContainer.java:1659) at com.ibm.ws.webcontainer.channel.WCChannelLink.ready(WCChannelLink.java:195) at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleDiscrimination(HttpInboundLink.java:452) at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleNewRequest(HttpInboundLink.java:511) at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.processRequest(HttpInboundLink.java:305) at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.ready(HttpInboundLink.java:276) at com.ibm.ws.tcp.channel.impl.NewConnectionInitialReadCallback.sendToDiscriminators(NewConnectionInitialReadCallback.java:214) at com.ibm.ws.tcp.channel.impl.NewConnectionInitialReadCallback.complete(NewConnectionInitialReadCallback.java:113) at com.ibm.ws.tcp.channel.impl.AioReadCompletionListener.futureCompleted(AioReadCompletionListener.java:165) at com.ibm.io.async.AbstractAsyncFuture.invokeCallback(AbstractAsyncFuture.java:217) at com.ibm.io.async.AsyncChannelFuture.fireCompletionActions(AsyncChannelFuture.java:161) at com.ibm.io.async.AsyncFuture.completed(AsyncFuture.java:138) at com.ibm.io.async.ResultHandler.complete(ResultHandler.java:204) at com.ibm.io.async.ResultHandler.runEventProcessingLoop(ResultHandler.java:775) at com.ibm.io.async.ResultHandler$2.run(ResultHandler.java:905) at com.ibm.ws.util.ThreadPool$Worker.run(ThreadPool.java:1648) Caused by: java.lang.IndexOutOfBoundsException: Index: 14, Size: 15 at java.util.ArrayList.get(ArrayList.java:347) at com.sun.faces.facelets.tag.jsf.ComponentSupport.finalizeForDeletion(ComponentSupport.java:136) at com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.doOrphanedChildCleanup(ComponentTagHandlerDelegateImpl.java:338) at com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.apply(ComponentTagHandlerDelegateImpl.java:192) at javax.faces.view.facelets.DelegatingMetaTagHandler.apply(DelegatingMetaTagHandler.java:120) at javax.faces.view.facelets.DelegatingMetaTagHandler.applyNextHandler(DelegatingMetaTagHandler.java:137) at org.richfaces.view.facelets.html.BehaviorsAddingComponentHandlerWrapper.applyNextHandler(BehaviorsAddingComponentHandlerWrapper.java:53) at com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.apply(ComponentTagHandlerDelegateImpl.java:184) at javax.faces.view.facelets.DelegatingMetaTagHandler.apply(DelegatingMetaTagHandler.java:120) at javax.faces.view.facelets.CompositeFaceletHandler.apply(CompositeFaceletHandler.java:98) at com.sun.faces.facelets.tag.ui.CompositionHandler.apply(CompositionHandler.java:166) at com.sun.faces.facelets.compiler.NamespaceHandler.apply(NamespaceHandler.java:93) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jean ANDRE commented on RF-11054: --------------------------------- Finally we get success in using the following code. {code} <h:graphicImage value="/images/closeButton.png" styleClass="closeButton" onclick="closeTab('#{tab.id}');event.stopPropagation();" immediate="true" /> {code} {code} <!-- --> <!-- CLOSE TAB --> <!-- --> <a4j:jsFunction id="closeTab" name="closeTab" action="#{desktopTabController.doCloseTab}" render="menu-opened-tabs,desktopTabPanel"> <a4j:param name="tabId" assignTo="#{desktopTabController.closeTabId}" /> </a4j:jsFunction> {code} The function event.stopPropagation() instead of Event.stop(event). The NPE is a contextual bug : it may depend on : - Having or not having set the activeItem - We have also return an Collections.unmodifiableCollection(xxx) of our dynamic tabs. - Event order ?? RichFaces should guide the users on how build robust dynamic tabs that supports also dynamic close/deletion. What are the best practices and what are the buggy scenarios. There is different ways to build dynamic tabs, some are better than other, some are better suitable for a specific situation than other and etc. It would be good that richfaces give us the closeTab as a built-in feature and allow us to decide to close or not closing the tab based on the user context (I mean, user is editing some field, do we need to cancel the modification...) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11054?page=com.atlassian.jira.plugin.s... ] Jean ANDRE edited comment on RF-11054 at 2/24/12 12:43 PM: ----------------------------------------------------------- Finally we get success in using the following code. {code} <h:graphicImage value="/images/closeButton.png" styleClass="closeButton" onclick="closeTab('#{tab.id}');event.stopPropagation();" immediate="true" /> {code} {code} <!-- --> <!-- CLOSE TAB --> <!-- --> <a4j:jsFunction id="closeTab" name="closeTab" action="#{desktopTabController.doCloseTab}" render="menu-opened-tabs,desktopTabPanel"> <a4j:param name="tabId" assignTo="#{desktopTabController.closeTabId}" /> </a4j:jsFunction> {code} The function event.stopPropagation() instead of Event.stop(event). The NPE is a contextual bug : it may depend on : - Having or not having set the activeItem - We have also return an Collections.unmodifiableCollection(xxx) of our dynamic tabs. - Race condition : because at the begin of the project, the same code trigger an NPE and now, it does not. So, is there an impact about having an empty dynamic tabs versus tabs with some content ? Deletion also triggers NPE in some circumstance (not all the time). RichFaces should guide the users on how build robust dynamic tabs that supports also dynamic close/deletion. What are the best practices and what are the buggy scenarios. There is different ways to build dynamic tabs, some are better than other, some are better suitable for a specific situation than other and etc. It would be good that richfaces give us the closeTab as a built-in feature and allow us to decide to close or not closing the tab based on the user context (I mean, user is editing some field, do we need to cancel the modification...) was (Author: jorelia64): Finally we get success in using the following code. {code} <h:graphicImage value="/images/closeButton.png" styleClass="closeButton" onclick="closeTab('#{tab.id}');event.stopPropagation();" immediate="true" /> {code} {code} <!-- --> <!-- CLOSE TAB --> <!-- --> <a4j:jsFunction id="closeTab" name="closeTab" action="#{desktopTabController.doCloseTab}" render="menu-opened-tabs,desktopTabPanel"> <a4j:param name="tabId" assignTo="#{desktopTabController.closeTabId}" /> </a4j:jsFunction> {code} The function event.stopPropagation() instead of Event.stop(event). The NPE is a contextual bug : it may depend on : - Having or not having set the activeItem - We have also return an Collections.unmodifiableCollection(xxx) of our dynamic tabs. - Race condition : because at the begin of the project, the same code trigger an NPE and now, it does not. So, is there an impact about having an empty dynamic tabs versus tabs with some content ? RichFaces should guide the users on how build robust dynamic tabs that supports also dynamic close/deletion. What are the best practices and what are the buggy scenarios. There is different ways to build dynamic tabs, some are better than other, some are better suitable for a specific situation than other and etc. It would be good that richfaces give us the closeTab as a built-in feature and allow us to decide to close or not closing the tab based on the user context (I mean, user is editing some field, do we need to cancel the modification...) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira