9:38 a.m.
Brendan Healey created RF-11971:
-----------------------------------
Summary: rich:menuItem onclick return value ignored
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 p.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Brian Leathem updated RF-11971:
-------------------------------
Workaround Description:
{code}
<rich:menuItem label="Delete"
mode="ajax"
onclick="confirmAction();"/>
<script type="text/javascript">
confirmAction = function() {
if(!confirm('are you sure?')) {
return;
} else {
callAction();
}
}
</script>
<a4j:jsFunction name="callAction"
action="#{bean.doSomething}"/>
{code}
was:
<rich:menuItem label="Delete"
mode="ajax"
onclick="confirmAction();"/>
<script type="text/javascript">
confirmAction = function() {
if(!confirm('are you sure?')) {
return;
} else {
callAction();
}
}
</script>
<a4j:jsFunction name="callAction"
action="#{bean.doSomething}"/>
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:29 p.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Brian Leathem reassigned RF-11971:
----------------------------------
Assignee: Pavol Pitonak
QE, can you please confirm whether returning null from the onclick handler of a menuitem
prevents action execution.
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Pavol Pitonak
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:26 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Pavol Pitonak reassigned RF-11971:
----------------------------------
Assignee: Jan Papousek (was: Pavol Pitonak)
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Jan Papousek
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:12 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek commented on RF-11971:
-----------------------------------
I've added a new page to Metamer
(http://localhost:8080/metamer/faces/components/richMenuItem/RF-11971.xhtml).
Action defined in the @action attribute is performed independently on the value of
@onclick attribute.
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Jan Papousek
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:16 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek updated RF-11971:
------------------------------
Steps to Reproduce:
# deploy Metamer
# http://localhost:8080/metamer/faces/components/richMenuItem/RF-11971.xhtml
# click on the "Click on Me (onclick returns false without confirmation)"
# click on the "Cancel" button -> counter value is incremented (action is
performed)
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Jan Papousek
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:16 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek reassigned RF-11971:
---------------------------------
Assignee: Brian Leathem (was: Jan Papousek)
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Brian Leathem
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:24 p.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Brian Leathem updated RF-11971:
-------------------------------
Fix Version/s: 4.2.1.Final
Assignee: (was: Brian Leathem)
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Fix For: 4.2.1.Final
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:52 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Brian Leathem updated RF-11971:
-------------------------------
Component/s: component-menu
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Fix For: 4.2.1.Final
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:28 p.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč reassigned RF-11971:
-------------------------------
Assignee: Lukáš Fryč
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:25 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč resolved RF-11971.
-----------------------------
Resolution: Done
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek closed RF-11971.
-----------------------------
Verified. When it's return 'false' from onclick handler, it'll prevent
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek reopened RF-11971:
-------------------------------
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek closed RF-11971.
-----------------------------
Resolution: Done
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
[
https://issues.jboss.org/browse/RF-11971?page=com.atlassian.jira.plugin.s...
]
Jan Papousek edited comment on RF-11971 at 3/16/12 11:22 AM:
-------------------------------------------------------------
Verified. When 'false' is returned from onclick handler, it'll prevent action
execution.
A note: 'null' has no effect.
was (Author: jpapouse):
Verified. When it's return 'false' from onclick handler, it'll prevent
rich:menuItem onclick return value ignored
------------------------------------------
Key: RF-11971
URL: https://issues.jboss.org/browse/RF-11971
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-menu
Affects Versions: 4.2.0.Final
Environment: Chrome / glassfish 3.1.1 / mojarra 2.1.6
Reporter: Brendan Healey
Assignee: Lukáš Fryč
Fix For: 4.2.1.CR1
My expectation was that using rich:menuItem
onclick="if(!confirm('#{msgs.playerConfirmDelete}')) return false;"
(and selecting cancel) would prevent any action routines being called, as is common
with components such as h:commandButton. As it stands the return value is ignored and
processing continues with return true or return false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4638
days inactive
4674
days old
richfaces-issues@lists.jboss.org
14 comments
5 participants
participants (5)
-
Brendan Healey (JIRA) -
Brian Leathem (JIRA)
-
Jan Papousek (JIRA)
-
Lukáš Fryč (JIRA)
-
Pavol Pitonak (JIRA)