[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Benoit VI updated RF-12167: --------------------------- Description: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of "!=" in the second expression, and so it's always false ! onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false; } Thanks by advance for fixing this little error. was: I noticed a typo error in onbeforeselectionchange javascript method : There is an "!==" insted of "!=" in the second expression, and so it's always false ! onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false; } Thanks by advance for fixing this little error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Benoit VI updated RF-12167: --------------------------- Description: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of one in the second expression, and so it's always false ! {{monospaced onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false; }} Thanks by advance for fixing this little error. was: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of "!=" in the second expression, and so it's always false ! {{monospaced}} onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false; } {{/monospaced}} Thanks by advance for fixing this little error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Benoit VI updated RF-12167: --------------------------- Description: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of one in the second expression, and so it's always false ! onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false;} Thanks by advance for fixing this little error. was: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of one in the second expression, and so it's always false ! {{onbeforeselectionchange: function (event) {}} {{ return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !== false;}} Thanks by advance for fixing this little error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Benoit VI updated RF-12167: --------------------------- Description: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of one in the second expression, and so it's always false ! onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !={color:red}={color} false;} The consequence is that it is impossible to use the onbeforeselectionchange attribute to eventually avoid selection change in certain cases (for instance to prevent the selection change when you click on a radio in the table). Thanks by advance for fixing this error. was: I noticed a typo error in onbeforeselectionchange javascript method : There is two "=" instead of one in the second expression, and so it's always false ! onbeforeselectionchange: function (event) { return !this.options.onbeforeselectionchange || this.options.onbeforeselectionchange.call(this.element, event) !={color:red}={color} false;} Thanks by advance for fixing this little error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12167: ------------------------------- Fix Version/s: 4.2.2.Final (was: 4.2-Tracking) (was: 4.3.0.Milestone1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12167?page=com.atlassian.jira.plugin.s... ] Brian Leathem resolved RF-12167. -------------------------------- Resolution: Done Removed the extra "=" from the comparison to false Benoit - thanks for reporting this issue, along with a suggested fix. In the future, feel free to submit a pull request and get proper credit for your fixes! https://community.jboss.org/wiki/ContributorGettingStartedGuide -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira