[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Nick Belaevski updated RF-10754: -------------------------------- Fix Version/s: 4.Future -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-10754. ----------------------------- Assignee: Lukáš Fryč Fix Version/s: 4.2.1.CR1 (was: 4.Future) Resolution: Done EDT scrolling feature rewritten. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč edited comment on RF-10754 at 3/28/12 10:50 AM: ----------------------------------------------------------- Thanks for the hint Peter, I have used it as the base for the rewritten version of scrolling feature. I would appreciate your feedback how the new version stands in {{4.2.1.CR1}}. Let's check it in the wild! was (Author: lfryc): Thanks for the hint Peter, I have used it as the base for the rewritten version of scrolling feature. I would appreciate your feedback how the new version stands in {{4.2.1.CR1}}. Let's take in the wild! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Peter Hallama edited comment on RF-10754 at 4/2/12 4:57 AM: ------------------------------------------------------------ Hi Lukáš, I just tested latest 4.2.1-SNAPSHOT Version (could not find CR1 yet) and have several issues in my setup: 1. when the table is initially already exceeding the configured size vertical scrolling seems to be broken (scroller is present (diabled) with full size) 2. for quite a lot of my tables I have issues with column-width adjustment which is just not possible - a few tables work. -> I See the mouseover but "ondrag" it just marks the column text. 3. in one usecase (when initializing a table onclick on another table row by ajax update) the new table has no scrolling bars at all. I tested on my version also, unfortunately I reformatted the js-code so a can't post a diff but here are the changes: 1. add new Function {code} adjustScrollingIssues: function() { var headerElem = document.getElementById(this.id + ":header"); var bodyElem = document.getElementById(this.id + ":body"); //compute correct width by gettong from parent div var parentWidth = this.scrollElement.parentNode.parentNode.parentNode.parentNode.parentNode.offsetWidth; this.scrollElement.style.width = parentWidth + "px"; headerElem.style.width = parentWidth + "px"; if (bodyElem != null) { //might be null in case of empty body... bodyElem.style.width = parentWidth + "px"; } }, {code} 2. initialize function just before ende {code} this.updateLayout(); //>>>Begin insert this.adjustScrollingIssues(); this.updateLayout(); //this.adjustResizers(); //<<<end insert this.updateScrollPosition(); //TODO Restore horizontal scroll position {code} still a little bit hacked but really seem to be stable now for my usecases. was (Author: psh): Hi Lukáš, I just tested latest 4.2.1-SNAPSHOT Version (could not find CR1 yet) and have several issues in my setup: 1. when the table is initially already exceeding the configured size vertical scrolling seems to be broken (scroller is present (diabled) with full size) 2. for quite a lot of my tables I have issues with column-width adjustment which is just not possible - a few tables work. -> I See the mouseover but "ondrag" it just marks the column text. 3. in one usecase when initializing a table onclick on another table row by ajax update the new tabler has no scrolling bars at all. I tested on my version also, unfortunately i reformatted the js-code so a can't post a diff but here are the canges: 1. add new Function {code} adjustScrollingIssues: function() { var headerElem = document.getElementById(this.id + ":header"); var bodyElem = document.getElementById(this.id + ":body"); //compute correct width by gettong from parent div var parentWidth = this.scrollElement.parentNode.parentNode.parentNode.parentNode.parentNode.offsetWidth; this.scrollElement.style.width = parentWidth + "px"; headerElem.style.width = parentWidth + "px"; if (bodyElem != null) { //might be null in case of empty body... bodyElem.style.width = parentWidth + "px"; } }, {code} 2. initialize function just before ende {code} this.updateLayout(); //>>>Begin insert this.adjustScrollingIssues(); this.updateLayout(); //this.adjustResizers(); //<<<end insert this.updateScrollPosition(); //TODO Restore horizontal scroll position {code} still a little bit hacked but really seem to be stable now for my usecases. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč edited comment on RF-10754 at 4/2/12 6:07 AM: --------------------------------------------------------- Hey Peter, thanks for checking the fix. I admit I can't reproduce the issue you mentioned. Could you please grab following example [1] and modify the page {{extendedtable-RF10754.xhtml}} [2] it so it will be broken? Could you please add more details? Which browser and version are you using? [1] https://github.com/richfaces/dev-examples/tree/release/4.2.1.CR1/iteratio... [2] https://github.com/richfaces/dev-examples/blob/release/4.2.1.CR1/iteratio... was (Author: lfryc): Hey Peter, thanks for checking the fix. I admit I can't reproduce the issue you mentioned. Could you please grab following example [1] and modify the page {{extendedtable-RF-10754/xhtml}} [2] it so it will be broken? Could you please add more details? Which browser and version are you using? [1] https://github.com/richfaces/dev-examples/tree/release/4.2.1.CR1/iteratio... [2] https://github.com/richfaces/dev-examples/blob/release/4.2.1.CR1/iteratio... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Peter Hallama updated RF-10754: ------------------------------- Attachment: test-bug.zip -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-10754?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč edited comment on RF-10754 at 4/6/12 10:44 AM: ---------------------------------------------------------- Hi Peter, great analysis! Could you please attach the sample project source or share that on github? I expect this is similar issues to the original one, but it would need separated fix. Could you please open new bug so we can track it? Please post the link here once you will open it. was (Author: lfryc): Hi Peter, great analysis! Could you please attach the sample project source or share that on github? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira