[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Juraj Huska commented on RF-11548: ---------------------------------- If it is possible I would love to do this task by myself, if it so, please assign this to me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Juraj Huska updated RF-11548: ----------------------------- Description: The standard error messages provided by mojarra are changed from one version to another. For example there is quiet small change, but causes that for example in JBoss AS 6.0.0.Final I have this error message: Name: Validation Error: *Value* is less than allowable minimum of '3' and on JBoss AS 7.0.2.Final I have: Name: Validation Error: *Length* is less than allowable minimum of '3' this causes some problems when testing and also IMHO it would look better with unified error messages for all components and containers. was: The standard error messages provided by mojarra are changed from one version to another. For example there is quiet small change, but causes that for example in JBoss AS 6.0.0.Final I have this error message: Name: Validation Error: *Value* is less than allowable minimum of '3' and on JBoss AS 7.0.2.Final I have: Name: Validation Error: *Length* is less than allowable minimum of '3' this causes some problems when testing and also IMHO it would look better with unified error messages for all components. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Juraj Huska updated RF-11548: ----------------------------- Assignee: (was: Juraj Huska) Fix Version/s: 4.1.0.Milestone4 (was: 4.Future) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Juraj Huska edited comment on RF-11548 at 10/19/11 11:13 AM: ------------------------------------------------------------- I have just done step by step what was written here: http://blogs.oracle.com/johnc/entry/more_jsf_validation_custom_error This should achieve that on all containers there are consistent JSF validation messages. This is commit which contains these changes: https://github.com/jhuska/showcase/commit/34d8f6d1b09d81ac21ab6b87b38a278... *The only drawback*, now, is that each message takes a parameter with the label of component which generated particular messages. Some of the labels are generated dynamically, which causes sometimes ugly validation messages, like j_idt221:age: 'da' must be a number between -2147483648 and 2147483647 Example: 9346 IMHO this can be solved in three ways: -generate IDs and names attributes not dynamically -delete parameter for message which determines from which input it was generated which is not good, mainly for rich:messages component, where user than will not know where the message comes from -let this small issue be Should I make pull request with the small described ugliness ? was (Author: jhuska): I have just done step by step what was written here: http://blogs.oracle.com/johnc/entry/more_jsf_validation_custom_error This should achieve that on all containers there are consistent JSF validation messages. The messages are defined in the file: https://github.com/jhuska/showcase/blob/custom-JSF-messages/src/main/reso... *The only drawback*, now, is that each message takes a parameter with the label of component which generated particular messages. Some of the labels are generated dynamically, which causes sometimes ugly validation messages, like j_idt221:age: 'da' must be a number between -2147483648 and 2147483647 Example: 9346 IMHO this can be solved in three ways: -generate IDs and names attributes not dynamically -delete parameter for message which determines from which input it was generated which is not good, mainly for rich:messages component, where user than will not know where the message comes from -let this small issue be Should I make pull request with the small described ugliness ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-11548: ---------------------------- Fix Version/s: 4.2.0.Tracking (was: 4.1.0.Milestone4) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Juraj Huska commented on RF-11548: ---------------------------------- Hi Brian, I have had a review with Lukas about this JIRA and he advised me to ask you, whether my *proposed solution* can be merged to showcase *4.1.1.Final*, since for 4.1.0.Final it is quite late now? Just to summarize my solution(already sent pull request for it) is: -I have just *copied the definition of error messages from one JSF implementation*, and set that *showcase should use* this definition on *all* containers, this should also lead to decreasing of failed tests for showcase by 9. Can be this solution accepted(pull request merged), even than it is not the ideal solution ?(please see the drawback in my previous comment). Thanks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-11548?page=com.atlassian.jira.plugin.s... ] Jan Papousek closed RF-11548. ----------------------------- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira