10:15 a.m.
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James Goodfellow
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 a.m.
New subject: [JBoss JIRA] Updated: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10221:
--------------------------------
Assignee: Gleb Galkin
Fix Version/s: 4.0.0.CR1
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James Goodfellow
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.CR1
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8 a.m.
New subject: [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin commented on RF-10221:
----------------------------------
James, some refactoring happened, so don't use showPopupPanel(), hidePopupPanel()
since it will be hidden in future.
You can use in JavaScript RichFaces.$('popup').show(); or
RichFaces.$('popup').hide(); instead. Also you can use
#{rich:component('popup')}.show(), #{rich:component('popup')}.hide() that
is more suitable since you can use in rich:component your popup id and all necessary JS
code will be generated by RF.
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James Goodfellow
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.CR1
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:02 a.m.
New subject: [JBoss JIRA] Resolved: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin resolved RF-10221.
------------------------------
Resolution: Won't Fix
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James Goodfellow
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.CR1
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 a.m.
New subject: [JBoss JIRA] Reopened: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
James G reopened RF-10221:
--------------------------
I believe there's still a bug here. If you set the show parameter of rich:popupPanel
(show="true") javascript is generated to call the suspect method:
RichFaces.ui.PopupPanel.showPopupPanel. It seems that the intension of this method was to
queue the showing of the popup panel until the page has been loaded. Instead, the show
method is called immediately and an undefined is passed onto the queue
(richfaces.Event.ready). Please review this method.
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Milestone6
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:13 a.m.
New subject: [JBoss JIRA] Updated: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10221:
--------------------------------
Fix Version/s: 4.0.0.Final
(was: 4.0.0.Milestone6)
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 a.m.
New subject: [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin commented on RF-10221:
----------------------------------
James, I've checked these methods once more and they are OK, but I've recognized a
possible error in your code: you use RichFaces.ui.PopupPanel.showPopupPanel('foo',
{}); call with wrong ID. Let's assume we have the following markup:
<h:form id="form">
<rich:popupPanel id="foo" />
</h:form>
So, the call should be RichFaces.ui.PopupPanel.showPopupPanel('form:foo', {});
since the ID of the form is attached to the rendered popup panel ID. I would suggest you
to use #{rich:component('foo')}.show() instead since the form could be without
it's own ID and all the necessary JS code will be generated by RF.
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
New subject: [JBoss JIRA] Resolved: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin resolved RF-10221.
------------------------------
Resolution: Done
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:26 p.m.
New subject: [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
James G commented on RF-10221:
------------------------------
Hi Gleb, thanks for responding. I'll take one last shot here:
This is the code I'm disputing:
richfaces.Event.ready(richfaces.$(id).show());
which is the same as:
$(document).ready(richfaces.$(id).show());
everywhere else in the Richfaces javascript library, where the .ready() method is used, a
function reference is passed in as the parameter to this method.
For example in panelMenuItem.js I see the code:
$(this.__panelMenu()).ready(function () {
item.__renderNestingLevel();
});
from an academic point of view, if you want the foobar method to be called from a queued
callback then this code will NOT work:
$(document).ready( foobar() );
In this case, the return value of foobar is passed to the .ready() method which is NOT
what you want.
either one of these would work:
$(document).ready( function(){ foobar(); } );
$(document).ready( foobar );
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:58 a.m.
New subject: [JBoss JIRA] Reopened: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin reopened RF-10221:
------------------------------
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:17 a.m.
New subject: [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin commented on RF-10221:
----------------------------------
James, sorry, it was a misunderstanding. Thank you very much for your attentiveness,
you're right about ready() method and its parameter. I've fixed this API as
follows:
showPopupPanel : function (id, opts, event) {
richfaces.Event.ready(function(){richfaces.$(id).show()});
},
hidePopupPanel : function (id, opts, event) {
richfaces.Event.ready(function(){richfaces.$(id).hide()});
}
Also I've verified it as follows and everything works OK:
<script type="text/javascript">
RichFaces.ui.PopupPanel.showPopupPanel('form:popup', {});
</script>
<h:form id="form">
<rich:popupPanel id="popup" />
</h:form>
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:17 a.m.
New subject: [JBoss JIRA] Resolved: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
Gleb Galkin resolved RF-10221.
------------------------------
Resolution: Done
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:49 a.m.
New subject: [JBoss JIRA] Commented: (RF-10221) Error when opening a popup panel
[
https://issues.jboss.org/browse/RF-10221?page=com.atlassian.jira.plugin.s...
]
James G commented on RF-10221:
------------------------------
Thanks Gleb.
Error when opening a popup panel
--------------------------------
Key: RF-10221
URL: https://issues.jboss.org/browse/RF-10221
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-panels-layout-themes
Affects Versions: 4.0.0.Milestone5
Environment: myfaces 2.0.3, tomcat 6
Reporter: James G
Assignee: Gleb Galkin
Labels: popupPanel
Fix For: 4.0.0.Final
When I call show or hide for a popup panel I get the following error: "fn is
undefined" from firefox.
I believe the offening code is: (in popupPanel.js)
showPopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).show());
},
hidePopupPanel : function (id, opts, event) {
$(document).ready(richfaces.$(id).hide());
}
It should probably be something more like:
showPopupPanel : function (id, opts, event) {
$(document).ready( function() { richfaces.$(id).show() } );
},
hidePopupPanel : function (id, opts, event) {
$(document).ready( function(){ richfaces.$(id).hide() } );
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4958
days inactive
5014
days old
richfaces-issues@lists.jboss.org
12 comments
4 participants
participants (4)
-
Gleb Galkin (JIRA) -
James G (JIRA)
-
James Goodfellow (JIRA)
-
Nick Belaevski (JIRA)