[
https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč edited comment on RF-13252 at 1/3/14 10:12 AM:
----------------------------------------------------------
I think that Mojarra should instead use {{UIView#addComponentResource}} to add {{jsf.js}}
resource, that will in turn use duplication detection in its rendering logic.
--Another solution might be specifying {{@ResourceDependency}} directly as I assume that a
reason for [conditional rendering of
{{jsf.js}}|https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/CommandLinkRenderer.java#L124]
is optimalization in case the button is rendered (however most of the JSF apps using AJAX
won't mind to refer to {{jsf.js}} anyway).-- (I noticed Mojarra also checks for
inclusion of commandLink in a form).
was (Author: lfryc):
I think that Mojarra should instead use {{UIView#addComponentResource}} to add
{{jsf.js}} resource, that will in turn use duplication detection in its rendering logic.
Another solution might be specifying {{@ResourceDependency}} directly as I assume that a
reason for [conditional rendering of
{{jsf.js}}|https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/CommandLinkRenderer.java#L124]
is optimalization in case the button is rendered (however most of the JSF apps using AJAX
won't mind to refer to {{jsf.js}} anyway).
a4j:ajax includes jsf.js script twice
-------------------------------------
Key: RF-13252
URL:
https://issues.jboss.org/browse/RF-13252
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-a4j-core
Affects Versions: 4.3.4
Environment: any browser
EAP 6.2 (Mojarra 2.1.19)
EAP 6.1 (Mojarra 2.1.19)
JBoss AS 7.1.1 (Mojarra 2.1.7)
Reporter: Jonáš Trantina
Assignee: Lukáš Fryč
Fix For: 4.3.5
Attachments: reproducer.zip
Original Estimate: 4 hours
Remaining Estimate: 4 hours
When a4j:script is used in the page like so:
{noformat}
<h:commandLink value="Click me ">
<a4j:ajax event="click" render="@form"/>
</h:commandLink>
{noformat}
Then two script tags pointing to jsf.js are added to the page, once in the head by the
inclusion of @ResourceDependency [1], and once again by Overriding the
ClientBehaviorRenderer#getScript method [2,3].
Note, that according to Brian, resolving this without introducing any functional
regressions may require the resolution of RF-12270 [4].
[1]
https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
[2]
https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav...
[3]
https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/...
[4]
https://issues.jboss.org/browse/RF-12270
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira