6:42 p.m.
Lukáš Fryč created RF-12249:
-------------------------------
Summary: CDK: generates both get* and is* methods for boolean/Boolean
expressions
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 p.m.
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
Tthis needs to be fixed - it should automatically call {{is*()}} variant {{boolean}} and
{{Boolean}} methods.
CDK: generates both get* and is* methods for boolean/Boolean
expressions
------------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12249:
----------------------------
Summary: CDK: generate both get* and is* methods for boolean/Boolean expressions
(was: CDK: generates both get* and is* methods for boolean/Boolean expressions)
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
http://download.oracle.com/otndocs/jcp/7224-javabeans-1.01-fr-spec-oth-JS...
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12249:
----------------------------
Fix Version/s: 4.3.0.Milestone1
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
Fix the CDK to follow the JavaBeans specification, dealing with breakages as they come up
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12249:
----------------------------
Priority: Critical (was: Major)
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:08 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč reassigned RF-12249:
-------------------------------
Assignee: Lukáš Fryč
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
http://download.oracle.com/otndocs/jcp/7224-javabeans-1.01-fr-spec-oth-JS...
{quote}
8.3.2 *Boolean properties*
In addition, for boolean properties, we allow a getter method to match the pattern:
{code}
public boolean is<PropertyName>();
{code}
This {{“is<PropertyName>”}} method may be provided instead of a
{{“get<PropertyName>”}} meth-
od, or it may be provided in addition to a {{“get<PropertyName>”}} method.
In either case, if the {{“is<PropertyName>”}} method is present for a boolean
property then we will
use the {{“is<PropertyName>”}} method to read the property value.
An example boolean property might be:
{code}
public boolean isMarsupial();
public void setMarsupial(boolean m);
{code}
{quote}
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
So I have found two issues:
{code:java}
@Attribute
abstract public Boolean getCloseable();
{code}
generates
{code}
public Boolean isCloseable() {
Boolean value = (Boolean) getStateHelper().eval(Properties.closeable);
return value;
}
{code}
but the generated method should be named {{getCloseable}} in case of {{Boolean}}.
----
The similar (but no so severe) issues happen when {{boolean}} method defined:
{code:java}
@Attribute
abstract public boolean getCloseable();
{code}
generates
{code:java}
public boolean isCloseable() {
Boolean value = (Boolean) getStateHelper().eval(Properties.closeable, false);
return value;
}
{code}
but specification does not require to provide {{isCloseable}} - the {{getCloseable}}
method is no generated at all.
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate both get* and is* methods for boolean/Boolean expressions
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12249:
---------------------------------
The fixed implementation will count with either:
{code}
@Attribute
abstract public Boolean getCloseable();
{code}
and
{code}
@Attribute
abstract public boolean isCloseable();
{code}
----
It doesn't strictly follow spec, since we would need to allow {{boolean
getCloseable()}} alternative too, but at least it is more predictable.
CDK: generate both get* and is* methods for boolean/Boolean
expressions
-----------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:22 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate get* method for Boolean and is* for boolean expression
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12249:
----------------------------
Summary: CDK: generate get* method for Boolean and is* for boolean expression (was:
CDK: generate both get* and is* methods for boolean/Boolean expressions)
CDK: generate get* method for Boolean and is* for boolean expression
--------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate get* method for Boolean and is* for boolean expression
2:25 p.m.
New subject: [JBoss JIRA] (RF-12249) CDK: generate get* method for Boolean and is* for boolean expression
[
https://issues.jboss.org/browse/RF-12249?page=com.atlassian.jira.plugin.s...
]
Juraj Húska closed RF-12249.
----------------------------
verified
CDK: generate get* method for Boolean and is* for boolean expression
--------------------------------------------------------------------
Key: RF-12249
URL: https://issues.jboss.org/browse/RF-12249
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 4.3.0.Milestone1
Generate both "get..." and "is..." method for Boolean and boolean
attributes
If you have an attribute like :
{code:java}
@Attribute
abstract public boolean isClosable();
{code}
This will generate a "isClosable()" method of course. But, then, trying to
access it in a template like :
{code:xml}
<c:if test="#{alert.closable}">
{code}
Will crash since JSF try to call the "getClosable()" method. The workaround is
to write :
{code:xml}
<c:if test="#{alert.isClosable()}">
{code}
But it would be nicer if the "geClosable()" method was generated in the same
time of the "isClosable()" method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4278
days inactive
4358
days old
richfaces-issues@lists.jboss.org
13 comments
2 participants
participants (2)
-
Juraj Húska (JIRA) -
Lukáš Fryč (JIRA)