[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Michael Heinen updated RF-12145: -------------------------------- Attachment: onc42.war Attached war file without libs. Use richfaces 4.2 and myfaces 2.1.6 Call <context>/faces/oncomplete.xhtml 1) Click Post button with checkbox enable --> js alert "after ActionListener" 2) Click Clear 3) Disable checkbox and click Post button agaion --> js alert "beforeActionListener" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Michael Heinen updated RF-12145: -------------------------------- Attachment: onc333.war Attached war file "onc333" without libs. Use richfaces 3.3.3 and myfaces 1.2.10 Call <context>/faces/oncomplete.xhtml 1) Click Post button with checkbox enable --> js alert "after ActionListener" 2) Click Clear 3) Disable checkbox and click Post button agaion --> js alert "after ActionListener" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Michael Heinen updated RF-12145: -------------------------------- Summary: RF4.2: Render and Oncomplete attributes not evaluated after invokeApplication if command is not rendered anymore (was: RF4.2: Oncomplete not evaluated after invokeApplication if command is not rendered anymore) Description: Sample use case: The last page of a wizard contains a commandButton with an EL expressions in the oncomplete attribute and in the render attribute. This button renders an outer component in order to close the wizard. The button itself is not rendered anymore after clicking it. As a consequence the EL expressions of the oncomplete attribute and of the render attribute is not evaluated after the invocation of an actionListener. This worked well with richfaces 3.3.3, therefore it's a critical regression. I'll attach a sample webApp for richfaces 4.2 and for riochfaces 3.3.3 Note that the render attribute of f:ajax is evaluated correctly. These attributes of the clicked command must be evaluated in phase render response in all cases. was: Sample use case: The last page of a wizard contains a commandButton with an EL expression in the oncomplete attribute. This button renders an outer component in order to close the wizard. The button itself is not rendered anymore after clicking it. As a consequence the EL expression of the oncomplete attribute is not evaluated after the invocation of an actionListener. This worked well with richfaces 3.3.3, therefore it's a critical regression. I'll attach a sample webApp for richfaces 4.2 and for riochfaces 3.3.3 Updated summary and description: oncomplete AND render attribute are affected -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Brian Leathem reassigned RF-12145: ---------------------------------- Assignee: Pavol Pitonak QE could you please verify this behaviour? I'm particularly interested to know if this is a problem with mojarra. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Michael Heinen commented on RF-12145: ------------------------------------- It does also not work with mojarra 2.1.7. You can use it in the attached sample app. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Jan Papousek commented on RF-12145: ----------------------------------- Michael: If you use maven project, could you provide it (instead of packaged WAR)? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Jan Papousek commented on RF-12145: ----------------------------------- I've tried it, but it didn't work as expected. It would be better to upload WARs containing libs. Can you attach also source code of the controllers (mainly OncController)? Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Jan Papousek commented on RF-12145: ----------------------------------- Michael: Can you also attach WAR containing libs and sources for your 3.3.3 sample app (behaving correctly)? Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Jan Papousek updated RF-12145: ------------------------------ Description: Sample use case: The last page of a wizard contains a commandButton with an EL expressions in the oncomplete attribute and in the render attribute. This button renders an outer component in order to close the wizard. The button itself is not rendered anymore after clicking it. As a consequence the EL expressions of the oncomplete attribute and of the render attribute is not evaluated after the invocation of an actionListener. This worked well with richfaces 3.3.3, therefore it's a critical regression. I'll attach a sample webApp for richfaces 4.2 and for riochfaces 3.3.3 Note that the render attribute of f:ajax is evaluated correctly. These attributes of the clicked command must be evaluated in phase render response in all cases. ---- {code:title="OncController.java"} package com; import java.util.Map; import javax.faces.bean.ManagedBean; import javax.faces.bean.SessionScoped; import javax.faces.context.FacesContext; import javax.faces.event.ActionEvent; @ManagedBean(name = "OncController") @SessionScoped public class OncController { private boolean innerShown = true; private int calls = 0; public OncController() { } public boolean isInnerShown() { return innerShown; } public void setInnerShown(boolean aInnerShown) { innerShown = aInnerShown; } public void clear(final ActionEvent ae) { innerShown=true; calls=0; } public void doIt(final ActionEvent ae) { final Map<String, Object> requestMap = FacesContext.getCurrentInstance().getExternalContext() .getRequestMap(); requestMap.put("key1", "alert('after actionListener');"); requestMap.put("key2", "group2"); calls++; } public String getOncomplete() { final Map<String, Object> requestMap = FacesContext.getCurrentInstance().getExternalContext() .getRequestMap(); final String value = (String) requestMap.get("key1"); if (value != null) { return value; } else { return "alert('before actionListener');"; } } public String getRenderIdsRichfaces() { final Map<String, Object> requestMap = FacesContext.getCurrentInstance().getExternalContext() .getRequestMap(); final String value = (String) requestMap.get("key2"); if (value != null) { return ","+value; } return""; } public String getRenderIdsFAjax() { final Map<String, Object> requestMap = FacesContext.getCurrentInstance().getExternalContext() .getRequestMap(); final String value = (String) requestMap.get("key2"); if (value != null) { return " " + value; } return""; } public int getCalls() { return calls; } } {code} {code:title="oncomplete.xhtml"} <html xmlns="http://www.w3.org/1999/xhtml" xmlns:ui="http://java.sun.com/jsf/facelets" xmlns:h="http://java.sun.com/jsf/html" xmlns:f="http://java.sun.com/jsf/core" xmlns:a4j="http://richfaces.org/a4j" xmlns:rich="http://richfaces.org/rich" xmlns:c="http://java.sun.com/jsp/jstl/core"> <ui:composition> <h:head><title>Oncomplete test</title></h:head> <h:body> <a4j:log mode="popup"/> <h:form id="myForm"> Post button rendered:<h:selectBooleanCheckbox id="innerBool" value="#{OncController.innerShown}"/> <br/> <h:panelGroup id="outer"> <c:if test="#{OncController.innerShown}"> <a4j:commandButton value="RichFaces Post" actionListener="#{OncController.doIt}" render="outer,details#{OncController.renderIdsRichfaces}" oncomplete="#{OncController.oncomplete}"/> <h:commandButton value="fAJAX Post" actionListener="#{OncController.doIt}"> <f:ajax render="outer details#{OncController.renderIdsFAjax}" execute="@form"/> </h:commandButton> </c:if> </h:panelGroup> <br/><br/> <h:panelGroup id="details"> oncomplete: <h:outputText value="#{OncController.oncomplete}"/> </h:panelGroup> <br/><br/> <h:panelGroup id="group2"> calls: <h:outputText value="#{OncController.calls}"/> </h:panelGroup> <br/><br/> <a4j:commandButton value="Clear" actionListener="#{OncController.clear}" render="myForm" /> </h:form> </h:body> </ui:composition> </html> {code} was: Sample use case: The last page of a wizard contains a commandButton with an EL expressions in the oncomplete attribute and in the render attribute. This button renders an outer component in order to close the wizard. The button itself is not rendered anymore after clicking it. As a consequence the EL expressions of the oncomplete attribute and of the render attribute is not evaluated after the invocation of an actionListener. This worked well with richfaces 3.3.3, therefore it's a critical regression. I'll attach a sample webApp for richfaces 4.2 and for riochfaces 3.3.3 Note that the render attribute of f:ajax is evaluated correctly. These attributes of the clicked command must be evaluated in phase render response in all cases. Steps to Reproduce: # download [sample WAR file|https://issues.jboss.org/secure/attachment/12353641/zOnc42WithLibs.war] and add Richfaces libs to it # start Apache Tomcat 6/7 and deploy the WAR file # open http://localhost:8080/zOnc42WithLibs/faces/oncomplete.xhtml # click on the "RichFaces Post" button #* alert window "after action listener" is shown (correct) # click on the "Clear" button # disable "Post button rendered" checkbox # click on the "RichFaces Post" button #* alert window "before action listener" is shown (wrong) Environment: MyFaces 2.1.6 / Mojarra 2.1.7 Tomcat 6.0.35 / 7.0.26 was: MyFaces 2.1.6 Tomcat 6.0.35 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Jan Papousek reassigned RF-12145: --------------------------------- Assignee: Brian Leathem (was: Jan Papousek) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Brian Leathem reassigned RF-12145: ---------------------------------- Assignee: (was: Brian Leathem) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12145: ------------------------------- Component/s: component-a4j-core -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12145: ------------------------------- Fix Version/s: 4.3.0.Milestone2 (was: 4.3.0.Milestone1) Priority: Major (was: Critical) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Michael Heinen updated RF-12145: -------------------------------- Attachment: RF-12145.zip Attached is a workaround that works in many cases. - A PhaseListener stores after phase InvokeApplication the "render" and "oncomplete" attributes of the clicked command. - The patched ExtendedPartialViewContextImpl checks these stored values. The PhaseListener uses findComponent to get the clicked command. This does not work for commands in ui:data or ui:repeat components. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12145: ------------------------------- Original Estimate: 3 hours Remaining Estimate: 3 hours -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč reassigned RF-12145: ------------------------------- Assignee: Lukáš Fryč -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/RF-12145?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-12145: ---------------------------- Component/s: core -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira