9:07 p.m.
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Priority: Minor
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:27 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10154:
----------------------------------
Step to reproduce:
<h:form>
<h:commandButton action="#{fasole.visitTree(facesContext, view)}"
value="Visit" />
<h:dataTable value="#{fasole.someItems}"
var="zeile">
<h:column>
<h:outputText value="#{zeile}"
rendered="#{fasole.isRendered(zeile)}" />
</h:column>
</h:dataTable>
</h:form>
Fasole.java snippet:
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null,
Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered(Object object) {
if (null == object) {
throw new NullPointerException();
}
return true;
}
1) click Visit -> nothing happens
2) change h:dataTable to r:dataTable or r:extendedDataTable and click Visit -> NPE
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Priority: Minor
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:54 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10154:
--------------------------------
Assignee: Nick Belaevski
Fix Version/s: 4.0.0.CR1
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:48 p.m.
New subject: [JBoss JIRA] Resolved: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski resolved RF-10154.
---------------------------------
Resolution: Cannot Reproduce Bug
@ManagedBean
@SessionScoped
public class Snippet {
public void action() {
FacesContext facesContext = FacesContext.getCurrentInstance();
visitTree(facesContext, facesContext.getViewRoot());
}
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null,
Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered() {
Map<String, Object> map =
FacesContext.getCurrentInstance().getExternalContext().getRequestMap();
Object o = map.get("zeile");
if (o == null) {
throw new NullPointerException();
}
System.out.println(o);
return true;
}
}
<h:form>
<h:commandButton action="#{snippet.action}" value="Visit" />
<rich:extendedDataTable value="#{dataProvider.data}"
var="zeile">
<h:column>
<h:outputText value="#{zeile}" rendered="#{snippet.rendered}"
/>
</h:column>
</rich:extendedDataTable>
</h:form>
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10154:
----------------------------------
You are right, problem is not in RichFaces, but in myfaces implementation. With mojarra
2.0.3-b03 it works, with myfaces 2.0.3 or trunk NPE happens. I forgot specify whole
environment.
I'll investigate it more. How to mark issue in jira as "myfaces only"?
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:42 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10154:
----------------------------------
Btw. what is the default referential enviroment for RichFaces? Specially JSP and EL
versions and implementations.
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 p.m.
New subject: [JBoss JIRA] Reopened: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski reopened RF-10154:
---------------------------------
Reproducible under MyFaces only
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10154:
-------------------------------------
Martin,
Just specify MyFaces in 'environment' field
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:50 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10154:
-------------------------------------
Regarding environment: base testing is done under Mojarra, Tomcat/JBoss 6; JSP is not
supported.
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10154:
----------------------------------
This problem appears only if project stage is Development, because myfaces use an extra
component walk for debug informations collecting:
Caused by: java.lang.NullPointerException
at cz.aura.faces.richfaces.Snippet.isRendered(Snippet.java:44)
....
at org.richfaces.component.UIDataAdaptor.visitComponents(UIDataAdaptor.java:1280)
at org.richfaces.component.UIDataAdaptor.visitDataChildren(UIDataAdaptor.java:1307)
at org.richfaces.component.UIDataTableBase.visitDataChildren(UIDataTableBase.java:337)
at
org.richfaces.component.AbstractExtendedDataTable.visitDataChildren(AbstractExtendedDataTable.java:138)
at org.richfaces.component.UIDataAdaptor.visitTree(UIDataAdaptor.java:1381)
....
at
org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener._doTreeVisit(DebugPhaseListener.java:310)
at
org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener.afterPhase(DebugPhaseListener.java:286)
please note the DebugPhaseListener which is involved. This is done for RESTORE_VIEW phase
too and in that case
org.richfaces.component.UIDataAdaptor.requiresRowIteration(FacesContext) returns false.
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:21 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10154:
--------------------------------
Workaround Description: Use check for null object in visitor callback.
Workaround: [Workaround Exists]
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.0.0.CR1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:23 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10154:
--------------------------------
Fix Version/s: Post_4.F
(was: 4.0.0.CR1)
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: Post_4.F
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:05 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10154:
----------------------------------
org.richfaces.component.UIDataAdaptor contains comment:
// NOTE: that the visitRows local will be obsolete once the
// appropriate visit hints have been added to the API
boolean visitRows = requiresRowIteration(facesContext);
is the required hint javax.faces.component.visit.VisitHint.SKIP_ITERATION which was added
in JSF 2.1 ?
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: Post_4.F
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10154:
-------------------------------------
Exactly, that's it.
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: Post_4.F
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 a.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Andy Schwartz commented on RF-10154:
------------------------------------
Both Mojarra (as of 2.0.4) and MyFaces (as of today) support an interim "skip
iteration" solution for 2.0 via the "javax.faces.visit.SKIP_ITERATION"
FacesContext property. See MyFaces dev discussion here:
http://markmail.org/search/?q=list:org.apache.myfaces.dev#query:list%3Aor...
And related issue here:
MYFACES-3036 Support SKIP_ITERATION FacesContext propert
https://issues.apache.org/jira/browse/MYFACES-3036
If UIDataAdaptor.requiresRowIteration was updated to honor this property, I believe that
this would avoid the DebugPhaseListener tree visit failure. More details here:
MYFACES-3033 Improve DebugPhaseListener for UIData and SKIP_ITERATION
https://issues.apache.org/jira/browse/MYFACES-3033
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Fix For: 4.Next
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 p.m.
New subject: [JBoss JIRA] Commented: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10154:
-------------------------------------
Andy,
Thanks - we'll update!
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Labels: jsf21, tran
Fix For: 4.Future
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:32 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10154:
-----------------------------
Fix Version/s: 4.0.1.Milestone1
(was: 4.Future)
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Labels: jsf21
Fix For: 4.0.1.Milestone1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:55 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10154:
-----------------------------
Fix Version/s: 4.1.0.Milestone1
(was: 4.0.1.Milestone1)
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Assignee: Nick Belaevski
Priority: Minor
Labels: jsf21
Fix For: 4.1.0.Milestone1
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10154:
-----------------------------
Fix Version/s: 4.1.0.Final
(was: 4.1.0.Milestone1)
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Priority: Minor
Labels: jsf21
Fix For: 4.1.0.Final
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 p.m.
New subject: [JBoss JIRA] Updated: (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
[
https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10154:
-----------------------------
Fix Version/s: 4.Future
(was: 4.1.0.Final)
UIDataAdaptor vs. UIData visitTee small difference
--------------------------------------------------
Key: RF-10154
URL: https://issues.jboss.org/browse/RF-10154
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tables
Affects Versions: 4.0.0.Milestone5
Environment: RichFaces 4.0.X trunk, svn rev. 20913
Reporter: Martin Kočí
Priority: Minor
Labels: jsf21
Fix For: 4.Future
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with
VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext,
VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext,
callback);-> it will visit h:outputText component and test if is rendered ->
#{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter
and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces),
UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4649
days inactive
4858
days old
richfaces-issues@lists.jboss.org
19 comments
4 participants
participants (4)
-
Andy Schwartz (JIRA) -
Jay Balunas (JIRA)
-
Martin Kočí (JIRA)
-
Nick Belaevski (JIRA)