1:41 p.m.
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Priority: Optional
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:03 p.m.
New subject: [JBoss JIRA] Updated: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10712:
--------------------------------
Assignee: Konstantin Mishin
Fix Version/s: 4.0.0.Final
Priority: Major (was: Optional)
Affects: [Documentation (Ref Guide, User Guide, etc.)]
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Konstantin Mishin
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:30 p.m.
New subject: [JBoss JIRA] Commented: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Martin Kočí commented on RF-10712:
----------------------------------
Hi Nick&others, I took a quick look on events from richfaces and here are my
suggestions:
TreeSelectionChangeListener - has method processSelectionChange, should be
processTreeSelectionChange, this is related to missing "SelectionChange" event,
listener, ...: RF-10439
DataScrollerListener - "DataScroller" vs "DataScroll" - isn't the
core operation characterised with this event "DataScroll" in a iterable
component? like UIData.setFirst(100), UIData.setRows(100)
TreeToggleListener - similar like TreeSelectionChangeListener, has method processToggle
method, but there is the ToggleListener.processToggle already! PanelToggleListener has
correct name of method: PanelToggleListener.processPanelToggle
ValidatorListener - isn't this listener to "validation", not validator? Has
method processValidation. Is this something special between PreValidateEvent and
PostValidateEvent ?
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Konstantin Mishin
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 p.m.
New subject: [JBoss JIRA] Assigned: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski reassigned RF-10712:
-----------------------------------
Assignee: Ilya Shaikovsky (was: Konstantin Mishin)
Ilya,
Please review naming.
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:24 a.m.
New subject: [JBoss JIRA] Commented: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky commented on RF-10712:
--------------------------------------
could agree except dataScroll (not against but just not completelly understand). so just
the question - do we want to do such refactoring after CR?
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:40 a.m.
New subject: [JBoss JIRA] Updated: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10712:
--------------------------------
Affects: [Documentation (Ref Guide, User Guide, etc.), Release Notes] (was:
[Documentation (Ref Guide, User Guide, etc.)])
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 a.m.
New subject: [JBoss JIRA] Updated: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10712:
--------------------------------
Assignee: Alex Kolonitsky (was: Ilya Shaikovsky)
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
New subject: [JBoss JIRA] Commented: (RF-10712) processUpload vs. processFileUpload - naming conventions
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky commented on RF-10712:
--------------------------------------
changes which should be made:
FileUploadListener.processFileUpload(FileUploadEvent)
TreeSelectionChangeListener.processTreeSelectionChange(TreeSelectionChangeEvent)
TreeToggleListener.processTreeToggle(TreeToggleEvent)
ToggleListener ->
CollapsibleSubTableToggleListener.processCollapsibleSubTableToggle(CollapsibleSubTableToggleEvent)
DataScrollListener.processDataScroll(DataScrollEvent)
ValidatorListener -> please check. Seems not used now at all. Then remove it and name
will be reviewed after we will need to add it.
additionally - remove PaggingListener (and event)
processUpload vs. processFileUpload - naming conventions
--------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 a.m.
New subject: [JBoss JIRA] Updated: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10712:
---------------------------------
Summary: Refactoring Listeners classes, methods and Event names according to standard
JSF convention. [WAS processUpload vs. processFileUpload - naming conventions] (was:
processUpload vs. processFileUpload - naming conventions)
Refactoring Listeners classes, methods and Event names according to
standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
New subject: [JBoss JIRA] Commented: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Alex Kolonitsky commented on RF-10712:
--------------------------------------
DataScrollerSource -> DataScrollSource
Expandable interface
Expandable.addToggleListener(ToggleListener listener) ->
Expandable.addCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
Expandable.removeToggleListener(ToggleListener listener) ->
Expandable.removeCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
ToggleListener[] Expandable.getToggleListeners -> CollapsibleSubTableToggleListener[]
Expandable.getCollapsibleSubTableToggleListener
Refactoring Listeners classes, methods and Event names according to
standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
New subject: [JBoss JIRA] Resolved: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Alex Kolonitsky resolved RF-10712.
----------------------------------
Resolution: Done
Refactoring Listeners classes, methods and Event names according to
standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Alex Kolonitsky edited comment on RF-10712 at 3/12/11 9:18 AM:
---------------------------------------------------------------
The following classes were changed:
DataScrollerSource -> DataScrollSource
Expandable interface
Expandable.addToggleListener(ToggleListener listener) ->
Expandable.addCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
Expandable.removeToggleListener(ToggleListener listener) ->
Expandable.removeCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
ToggleListener[] Expandable.getToggleListeners -> CollapsibleSubTableToggleListener[]
Expandable.getCollapsibleSubTableToggleListener
was (Author: Alex.Kolonitsky):
DataScrollerSource -> DataScrollSource
Expandable interface
Expandable.addToggleListener(ToggleListener listener) ->
Expandable.addCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
Expandable.removeToggleListener(ToggleListener listener) ->
Expandable.removeCollapsibleSubTableToggleListener(CollapsibleSubTableToggleListener
listener)
ToggleListener[] Expandable.getToggleListeners -> CollapsibleSubTableToggleListener[]
Expandable.getCollapsibleSubTableToggleListener
Refactoring Listeners classes, methods and Event names according to
standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [JBoss JIRA] Commented: (RF-10712) Refactoring Listeners classes, methods and Event names according to standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
[
https://issues.jboss.org/browse/RF-10712?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10712:
-------------------------------------
Looks like tree attributes were not renamed correctly, see:
http://community.jboss.org/thread/165744?tstart=0
Refactoring Listeners classes, methods and Event names according to
standard JSF convention. [WAS processUpload vs. processFileUpload - naming conventions]
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Key: RF-10712
URL: https://issues.jboss.org/browse/RF-10712
Project: RichFaces
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: compatibility
Affects Versions: 4.0.0.CR1
Environment: richfaces 4.0.X branch
Reporter: Martin Kočí
Assignee: Alex Kolonitsky
Fix For: 4.0.0.Final
method org.richfaces.event.FileUploadListener.processUpload(FileUploadEvent) should be
FileUploadListener.processFileUpload - with the "File" word in the middle.
The unspecified JSF convention is:
* logical name ("FileUpload")
* listener: logical name + "Listener" ("FileUploadListener")
* event: logical name + "Event" ("FileUploadEvent")
* method "process" + logical name ("processFileUpload")
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4961
days inactive
5017
days old
richfaces-issues@lists.jboss.org
12 comments
4 participants
participants (4)
-
Alex Kolonitsky (JIRA) -
Ilya Shaikovsky (JIRA)
-
Martin Kočí (JIRA)
-
Nick Belaevski (JIRA)