create an org.jboss.webbeans.DefinitionException. On Wed, Jun 17, 2009 at 1:11 PM, Dan Allen<dan.j.allen(a)gmail.com> wrote: -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org

On Wed, Jun 17, 2009 at 4:17 PM, Gavin King<gavin.king(a)gmail.com> wrote: Well, yeah, but how is the TCK going to check for this generically? It can't know about all the specific exception types thrown by the implementations? -Dan -- Dan Allen Senior Software Engineer, Red Hat | Author of Seam in Action http://mojavelinux.com http://mojavelinux.com/seaminaction http://in.relation.to/Bloggers/Dan NOTE: While I make a strong effort to keep up with my email on a daily basis, personal or other work matters can sometimes keep me away from my email. If you contact me, but don't hear back for more than a week, it is very likely that I am excessively backlogged or the message was caught in the spam filters. Please don't hesitate to resend a message if you feel that it did not reach my attention.

I think it needs to check TCKBeanManager.hasDefinitionError(). Of course, the container that you are testing would need to impl TCKBeanManager. On Wed, Jun 17, 2009 at 1:25 PM, Dan Allen<dan.j.allen(a)gmail.com> wrote: -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org

Well, I'm not saying that TCKBeanManager already exists :-) I just made it up :-) On Wed, Jun 17, 2009 at 1:30 PM, Dan Allen<dan.j.allen(a)gmail.com> wrote: -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org

On Wed, 2009-06-17 at 13:17 -0700, Gavin King wrote: We cannot use a JBoss specific exception in the TCK tests. But an SPI will be built around this to detect the problem.

On Fri, Jun 19, 2009 at 8:16 AM, Pete Muir <pmuir(a)redhat.com&gt; wrote: I was going off these two statements in 12.4: "If a definition error exists in a deployment, initialization will be aborted by the container." "If a deployment problem exists in a deployment, initialization will be aborted by the container." The way I have the test working is as follows. Deployment of the artifact is attempted. If it fails with an exception, the AbstractTest tries to determine if this was an expected exception (as declared by @ExpectedDeploymentException on the @Artifact). I override that method in AbstractJSR299TestCase to see if the exception thrown can be claimed by the Managers implementation (such that the exception falls into a category, either definition error or deployment error). AbstractTest#isThrowablePresent() -> AbstractJSR299Test#isThrowablePresent() -> Managers#isDefinitionError() or Managers#isDeploymentError() If the exception thrown during deployment maps to the expected exception (via this lookup) then the test case is considered passed. So I get what you are saying, but it appears what I implemented follows exactly that. I'm assuming that the only way to abort initialization is by throwning an exception. Maybe that is where my assumption is flawed. Feel free to revise if you feel it necessary. -Dan -- Dan Allen Senior Software Engineer, Red Hat | Author of Seam in Action http://mojavelinux.com http://mojavelinux.com/seaminaction http://in.relation.to/Bloggers/Dan NOTE: While I make a strong effort to keep up with my email on a daily basis, personal or other work matters can sometimes keep me away from my email. If you contact me, but don't hear back for more than a week, it is very likely that I am excessively backlogged or the message was caught in the spam filters. Please don't hesitate to resend a message if you feel that it did not reach my attention.

On Fri, Jun 19, 2009 at 1:21 PM, Pete Muir <pmuir(a)redhat.com&gt; wrote: That would be fantastic. The current impl I put in place allowed me to more forward writing tests, and I should have no trouble quickly updating the tests accordingly. -Dan -- Dan Allen Senior Software Engineer, Red Hat | Author of Seam in Action http://mojavelinux.com http://mojavelinux.com/seaminaction http://in.relation.to/Bloggers/Dan NOTE: While I make a strong effort to keep up with my email on a daily basis, personal or other work matters can sometimes keep me away from my email. If you contact me, but don't hear back for more than a week, it is very likely that I am excessively backlogged or the message was caught in the spam filters. Please don't hesitate to resend a message if you feel that it did not reach my attention.