March 2013 - cdi-dev - Jboss List Archives

[JBoss JIRA] (CDI-328) SPI for creating producers broken

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-328?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on CDI-328: ------------------------------- Here is the pull https://github.com/jboss/cdi/pull/180 > SPI for creating producers broken > --------------------------------- > > Key: CDI-328 > URL: https://issues.jboss.org/browse/CDI-328 > Project: CDI Specification Issues > Issue Type: Bug > Components: Portable Extensions > Affects Versions: 1.1.PFD > Reporter: Jozef Hartinger > Priority: Blocker > Fix For: 1.1.FD > > > CDI-268 introduces a set of factories to deal with the chicken-egg problem when creating Beans and Producers/InjectionTargets. > Unlike InjectionTargetFactory, the ProducerFactory interface does not address the problem properly. > In order to create a Producer implementation for a producer field/method, the following ingredients are needed: > * an AnnotatedField / AnnotatedMethod > * a declaring bean (bean for the class the producer field/method is declared on - the field/method is invoked on instances of the declaring bean) . Declaring bean does not need to be specified if the field/method is static > * bean for which the producer is created - this is needed in order for Producer.getInjectionPoints.getBean() to return the right thing. The bean is optional an may not be specified if the Producer is created for a non-contextual object > The following (slightly modified) SPI should handle all the requirements: > {noformat} > public interface ProducerFactory<X> { > public <T> Producer<T> createProducer(Bean<T> bean); > } > {noformat} > {noformat} > public interface BeanManager { > public <X> ProducerFactory<X> getProducerFactory(AnnotatedField<? super X> field, Bean<X> declaringBean); > public <X> ProducerFactory<X> getProducerFactory(AnnotatedMethod<? super X> method, Bean<X> declaringBean); > public <T, X> Bean<T> createBean(BeanAttributes<T> attributes, Class<X> beanClass, ProducerFactory<X> producerFactory); > } > {noformat} > Notice the additional *declaringBean* parameter for getProducerFactory() and modified type parameters in createBean() and ProducerFactory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-328) SPI for creating producers broken

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-328?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on CDI-328: ------------------------------- [~arnelim] I thought about this when I did the initial work, and decided I prefer get to create here, but it isn't a strong preference! To me, create suggests that the container *will always* create a new factory when you call the method, whereas get implies that the container may well return a cached version if it wants to. > SPI for creating producers broken > --------------------------------- > > Key: CDI-328 > URL: https://issues.jboss.org/browse/CDI-328 > Project: CDI Specification Issues > Issue Type: Bug > Components: Portable Extensions > Affects Versions: 1.1.PFD > Reporter: Jozef Hartinger > Priority: Blocker > Fix For: 1.1.FD > > > CDI-268 introduces a set of factories to deal with the chicken-egg problem when creating Beans and Producers/InjectionTargets. > Unlike InjectionTargetFactory, the ProducerFactory interface does not address the problem properly. > In order to create a Producer implementation for a producer field/method, the following ingredients are needed: > * an AnnotatedField / AnnotatedMethod > * a declaring bean (bean for the class the producer field/method is declared on - the field/method is invoked on instances of the declaring bean) . Declaring bean does not need to be specified if the field/method is static > * bean for which the producer is created - this is needed in order for Producer.getInjectionPoints.getBean() to return the right thing. The bean is optional an may not be specified if the Producer is created for a non-contextual object > The following (slightly modified) SPI should handle all the requirements: > {noformat} > public interface ProducerFactory<X> { > public <T> Producer<T> createProducer(Bean<T> bean); > } > {noformat} > {noformat} > public interface BeanManager { > public <X> ProducerFactory<X> getProducerFactory(AnnotatedField<? super X> field, Bean<X> declaringBean); > public <X> ProducerFactory<X> getProducerFactory(AnnotatedMethod<? super X> method, Bean<X> declaringBean); > public <T, X> Bean<T> createBean(BeanAttributes<T> attributes, Class<X> beanClass, ProducerFactory<X> producerFactory); > } > {noformat} > Notice the additional *declaringBean* parameter for getProducerFactory() and modified type parameters in createBean() and ProducerFactory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-327) AfterTypeDiscovery.addAnnotatedType() should require an id

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-327?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on CDI-327: ------------------------------- Please review https://github.com/jboss/cdi/pull/179 > AfterTypeDiscovery.addAnnotatedType() should require an id > ---------------------------------------------------------- > > Key: CDI-327 > URL: https://issues.jboss.org/browse/CDI-327 > Project: CDI Specification Issues > Issue Type: Bug > Components: Portable Extensions > Affects Versions: 1.1.PFD > Reporter: Jozef Hartinger > Assignee: Jozef Hartinger > Priority: Critical > Fix For: 1.1.FD > > > Instead of > public void addAnnotatedType(AnnotatedType<?> type); > the method signature should be: > public void addAnnotatedType(AnnotatedType<?> type, String id); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-324) Update InjectionPoint getBean() and isTransient() methods description to reflect Event instance

by Pete Muir (JIRA)

[ https://issues.jboss.org/browse/CDI-324?page=com.atlassian.jira.plugin.sy... ] Pete Muir resolved CDI-324. --------------------------- Assignee: Pete Muir Resolution: Rejected This is covered by class level javadoc as [~mkouba] says. > Update InjectionPoint getBean() and isTransient() methods description to reflect Event instance > ----------------------------------------------------------------------------------------------- > > Key: CDI-324 > URL: https://issues.jboss.org/browse/CDI-324 > Project: CDI Specification Issues > Issue Type: Clarification > Affects Versions: 1.1.PFD > Reporter: Martin Kouba > Assignee: Pete Muir > Fix For: 1.1.FD > > > Also update {{javax.enterprise.inject.spi.InjectionPoint}} javadoc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-328) SPI for creating producers broken

by Arne Limburg (JIRA)

[ https://issues.jboss.org/browse/CDI-328?page=com.atlassian.jira.plugin.sy... ] Arne Limburg commented on CDI-328: ---------------------------------- Also shouldn't getProducerFactory(...) renamed to createProducerFactory(...). You most likely will get a new one for every call... Same would apply to getInjectionTargetFactory(...) btw. > SPI for creating producers broken > --------------------------------- > > Key: CDI-328 > URL: https://issues.jboss.org/browse/CDI-328 > Project: CDI Specification Issues > Issue Type: Bug > Components: Portable Extensions > Affects Versions: 1.1.PFD > Reporter: Jozef Hartinger > Priority: Blocker > Fix For: 1.1.FD > > > CDI-268 introduces a set of factories to deal with the chicken-egg problem when creating Beans and Producers/InjectionTargets. > Unlike InjectionTargetFactory, the ProducerFactory interface does not address the problem properly. > In order to create a Producer implementation for a producer field/method, the following ingredients are needed: > * an AnnotatedField / AnnotatedMethod > * a declaring bean (bean for the class the producer field/method is declared on - the field/method is invoked on instances of the declaring bean) . Declaring bean does not need to be specified if the field/method is static > * bean for which the producer is created - this is needed in order for Producer.getInjectionPoints.getBean() to return the right thing. The bean is optional an may not be specified if the Producer is created for a non-contextual object > The following (slightly modified) SPI should handle all the requirements: > {noformat} > public interface ProducerFactory<X> { > public <T> Producer<T> createProducer(Bean<T> bean); > } > {noformat} > {noformat} > public interface BeanManager { > public <X> ProducerFactory<X> getProducerFactory(AnnotatedField<? super X> field, Bean<X> declaringBean); > public <X> ProducerFactory<X> getProducerFactory(AnnotatedMethod<? super X> method, Bean<X> declaringBean); > public <T, X> Bean<T> createBean(BeanAttributes<T> attributes, Class<X> beanClass, ProducerFactory<X> producerFactory); > } > {noformat} > Notice the additional *declaringBean* parameter for getProducerFactory() and modified type parameters in createBean() and ProducerFactory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev March 2013