Re: [cdi-dev] Interceptor bindings from interceptor when using 2.0 interception factory

Hi, On Mon, Aug 28, 2017 at 9:41 AM, Martin Kouba <mkouba(a)redhat.com&gt; wrote: Looking in the code that seems to do the same thing, at least in Weld 3.0.1. Going via getContextData() is much easier though for code that has to support both Weld and OWB. I read the issue, thanks for the pointer. I do wonder if the entry in the context data isn't the easiest option regardless. That might only require an update in the CDI spec. Essentially, just standardise the key being used? Currently the interceptor factory is an absolutely fantastic feature, but its usefulness is greatly diminished by the fact that no interceptor at this moment can (reliably) retrieve the interceptor bindings for all CDI implementations. The spec even uses dynamically adding @Transactional as an example; * <pre> * &#64;Produces * &#64;RequestScoped * public MyClass produceMyClass(InterceptionFactory<MyClass> factory) { * factory.configure().add(new AnnotationLiteral<Transactional>() { * }); * return factory.createInterceptedInstance(new MyClass()); * } But all the current interceptor implementations backing @Transactional do something like: public Object proceed(InvocationContext ctx) throws Exception { Transactional transactionalAnnotation = ctx.getMethod().getAnnotation(Transactional.class); So that clearly won't work. The spec text for InterceptionFactory also doesn't mention this caveat at all. So I wonder, what was the intended approach for InterceptionFactory and intercepter bindings with attributes? Or was InterceptionFactory solely intended for intercepter bindings without (non-binding) attributes? Kind regards, Arjan Tijms