Re: [cdi-dev] Should javax.enterprise.inject.Produces be inherited?

Hi John, Please note there is no such inheritance of scope for producer method in this case in the Weld. I added test https://github.com/weld/core/commit/77f6916b55882a81d5fb33313d2e58806605bb17 Thanks Tom ----- Original Message ----- From: "John Ament" <john.ament(a)spartasystems.com&gt; To: "Emily Jiang" <EMIJIANG(a)uk.ibm.com&gt; Cc: "cdi-dev" <cdi-dev(a)lists.jboss.org&gt; Sent: Tuesday, September 13, 2016 12:33:33 PM Subject: Re: [cdi-dev] Should javax.enterprise.inject.Produces be inherited? Emily, Just want to make sure I follow. Are you saying this because right now it is required that you add @Produces to the overridden method? I don't realistically see a scenario where you would override the method and not add produces. This method is intended to be called by the container. John From: Emily Jiang <EMIJIANG(a)uk.ibm.com&gt; Sent: Tuesday, September 13, 2016 4:37 AM To: John Ament Cc: Matej Novotny; Mark Struberg; cdi-dev Subject: Re: [cdi-dev] Should javax.enterprise.inject.Produces be inherited? First of all, the subject line suggests the produces should be inherited under all conditions. Anyway, after your explanation, I think this suggestion contradicts with spec and breaks backward compatibility. In the cdi 1.2/cdi 2.0 spec, The only way one bean can completely override a second bean at all injection points is if it implements all the bean types and declares all the qualifiers of the second bean. However, if the second bean declares a producer method or observer method, then even this is not enough to ensure that the second bean is never called! To help prevent developer error, the first bean may: * directly extend the bean class of the second bean, or * directly override the producer method, in the case that the second bean is a producer method, and then explicitly declare that it specializes the second bean. After this suggestion, the above sentence is not true any more. Many thanks, Emily =========================== Emily Jiang WebSphere Application Server, CDI Development Lead MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN Phone: +44 (0)1962 816278 Internal: 246278 Email: emijiang(a)uk.ibm.com Lotus Notes: Emily Jiang/UK/IBM@IBMGB From: John Ament <john.ament(a)spartasystems.com&gt; To: Matej Novotny <manovotn(a)redhat.com&gt;, Mark Struberg <struberg(a)yahoo.de&gt; Cc: Emily Jiang/UK/IBM@IBMGB, cdi-dev <cdi-dev(a)lists.jboss.org&gt; Date: 12/09/2016 13:31 Subject: Re: [cdi-dev] Should javax.enterprise.inject.Produces be inherited? Sent by: cdi-dev-bounces(a)lists.jboss.org @Matej - Yes, that would be consistent with what I was seeing as well. @Mark - Are you thinking about decorators and not alternatives? See also [1] Really the goal here is to substitute the bean, but not just the provided bean the producer method that it exposes. It seems to work as I would expect it in weld (as mentioned), when I add @Produces to the method, it overrides the base class's producer method. No ambiguous resolutions, it just works properly. Realistically, this is all an experiment to see if I can provide spring boot like default configurations (beans, config values, etc) in a framework, and override them as an application developer. [1]: http://docs.jboss.org/cdi/spec/2.0.EDR2/cdi-spec.html#alternatives From: Matej Novotny <manovotn(a)redhat.com&gt; Sent: Monday, September 12, 2016 3:28 AM To: Mark Struberg Cc: John Ament; Emily Jiang; cdi-dev Subject: Re: [cdi-dev] Should javax.enterprise.inject.Produces be inherited? Hi all, I did some testing (with Weld) and it seems the scope IS inherited when you use @Alternative. However it IS NOT inherited when you use @Specialized. Not yet sure if this is intended or anyhow spec-defined, just stating facts. Matej ----- Original Message ----- cdi-dev Info Page - JBoss Developer lists.jboss.org List to discuss the development of CDI (the specification) To see the collection of prior postings to the list, visit the cdi-dev Archives. NOTICE: This e-mail message and any attachments may contain confidential, proprietary, and/or privileged information which should be treated accordingly. If you are not the intended recipient, please notify the sender immediately by return e-mail, delete this message, and destroy all physical and electronic copies. Thank you. _______________________________________________ cdi-dev mailing list cdi-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/cdi-dev Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 ( http://www.apache.org/licenses/LICENSE-2.0.html ). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU NOTICE: This e-mail message and any attachments may contain confidential, proprietary, and/or privileged information which should be treated accordingly. If you are not the intended recipient, please notify the sender immediately by return e-mail, delete this message, and destroy all physical and electronic copies. Thank you. _______________________________________________ cdi-dev mailing list cdi-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/cdi-dev Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information. -- Tomas Remes