12:29 p.m.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Reporter: Mark Struberg
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
New subject: [JBoss JIRA] Updated: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-132:
--------------------------
Fix Version/s: 1.1 (Proposed)
Priority: Minor (was: Major)
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Reporter: Mark Struberg
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
New subject: [JBoss JIRA] Updated: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-132:
--------------------------
Component/s: Portable Extensions
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 p.m.
New subject: [JBoss JIRA] Assigned: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir reassigned CDI-132:
-----------------------------
Assignee: Pete Muir
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 p.m.
New subject: [JBoss JIRA] Commented: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
https://github.com/jboss/cdi/pull/31
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:33 a.m.
New subject: [JBoss JIRA] Updated: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-132:
--------------------------
Fix Version/s: 1.1 (Confirmed)
(was: 1.1 (Proposed))
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Confirmed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
New subject: [JBoss JIRA] Closed: (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir closed CDI-132.
-------------------------
Resolution: Done
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Confirmed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Martin Kouba reopened CDI-132:
------------------------------
I think that the following clarification texts [1][2] belong to Section "11.5.6.
ProcessAnnotatedType event" instead of "11.4. Alternative metadata
sources".
[1] "In general, the behavior is as defined by the Java Language Specification, and
only deviations from the Java Lanaguage Specification are noted."
[2] "If the Annotated represents a type, then the annotations returned should include
all annotations on the type and it's super types regardless of whether the annotation
is marked @Inherited."
IMHO Section "11.4. Alternative metadata sources" should only state that
portable extensions may override any annotations via SPI classes.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Martin Kouba commented on CDI-132:
----------------------------------
I realized that the text is also related to "11.3.18. Obtaining an AnnotatedType for
a class". Therefore it's quite logical to place it in "11.4. Alternative
metadata sources". However I believe it needs rewording. Maybe something like
"If the Annotated constructed by container as defined in Chapters 11.3.18. Obtaining
an AnnotatedType for a class and 11.5.6. ProcessAnnotatedType event ...".
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:05 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger commented on CDI-132:
-------------------------------------
The spec says:
{quote}If the Annotated represents a type, then the annotations returned should include
all annotations on the type and it's super types regardless of whether the annotation
is marked @Inherited{quote}
However, it is unclear what's returned by getAnnotation() if a given annotated type
has more than one instance of a given annotation type (this happens if a non-inherited
annotation is declared on two or more classes in the class hierarchy).
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:20 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger commented on CDI-132:
-------------------------------------
This is IMHO completely wrong. Having two classes:
{code:JAVA}
@Named
public class Foo {
}
public class Bar extends Foo {
}
{code}
we end up with two beans:
* Foo named "foo"
* Bar without name
Now suppose we add an extension that does not manipulate bean names at all. For instance:
{code:JAVA}
public class FooExtension implements Extension {
public void wrap(@Observer ProcessAnnotatedType<Bar> event) {
final AnnotatedType<Bar> bar = event.getAnnotatedType(); //
bar.getAnnotations() contains Named
event.setAnnotatedType(new ForwardingAnnotatedType(bar)); // just wrap, no change
}
}
{code}
The container examines the annotated type provided by the extension -->
getAnnotations() now contains Named. As a result, we end up with:
* Foo named "foo"
* Bar named "bar"
This is a side-effect of an extension that *does not actually change anything*.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:42 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
I was wrong, it can only be (3).
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 p.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-132:
-----------------------------------
things get more complicated.
I think the current AnnotatedType maintains no 'relation' to it's parent
class. Instead it contains the 'effective' model only. But this is imo not enough.
It also doesn't say anything about modifiers public/protected/private.
What should the AnnotatedType of the following class provide?:
@ApplicationScoped
public class MyBaseSvc {
private @Inject EntityManager;
...
}
@ApplicationScoped
public class DongService extends MyBaseSvc {
...
}
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR1
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:51 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-132:
-----------------------------------
The pull request is mostly fine, but I still miss some 'non-static' in the text:
- <para><literal>getMethods()</literal> returns all the methods
declared
- on the type and those declared on any supertypes.</para>
+ <para><literal>getMethods()</literal> returns all the
non-static methods declared
+ on the type and those declared on any supertypes.</para>
Or do we have cdi features on static methods/fields? Or do we plan to support this
somewhen? If so if the access to the underlying reflection Method/Field fine for us? An
Extension would need to checked this for all methods/fields, isn't?
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-132:
-----------------------------------
yikes, disposal methods can be static :/
So all is fine and we also need static methods/fields in the AnnotatedType
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
Mark, to which pull request do you refer?
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:56 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-132:
--------------------------
Fix Version/s: 1.1 (Proposed)
(was: 1.1.EDR)
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-132:
--------------------------
Fix Version/s: 1.1.PRD
(was: 1.1 (Proposed))
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
Please review the pull request at https://github.com/jboss/cdi/pull/121
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-132.
---------------------------
Resolution: Done
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:03 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger reopened CDI-132:
---------------------------------
Reopening since the problem of which annotations should be returned by
AnnotatedType.getAnnotations() has not been dealt with.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:05 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger updated CDI-132:
--------------------------------
Fix Version/s: 1.1 (Proposed)
(was: 1.1.PRD)
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:51 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
Currently the spec requires that only annotations either declared on the type, or declared
on a super-type annotated with @Inherited are returned by getAnnotations() which I think
is correct.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1 (Proposed)
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:55 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-132:
-------------------------------
Oops, no it didn't. Resolved.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:55 a.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-132.
---------------------------
Fix Version/s: 1.1.PRD
(was: 1.1 (Proposed))
Resolution: Done
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:19 p.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger reopened CDI-132:
---------------------------------
Thinking about the issue more, there is still a scenario where
AnnotatedType.getAnnotations() does not return enough information.
{code:JAVA}
@Dependent
public class Foo {
}
@RequestScoped
public class Bar extends Foo {
}
public class FooExtension implements Extension {
public void wrap(@Observer ProcessAnnotatedType<Bar> event) {
final AnnotatedType<Bar> bar = event.getAnnotatedType();
event.setAnnotatedType(new ForwardingAnnotatedType(bar));
}
}
{code}
If there was no Extension, the Bar bean would be recognized as @RequestScoped. However,
the extension sees both @Dependent and @RequestScoped and so does the CDI implementation
once the AnnotatedType is wrapped.
We could avoid that if we say that AnnotatedType.getAnnotations() returns all the
annotations on the type and all the annotations from supertypes that are inherited taking
scope inheritance (Section 4.1) into account.
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] (CDI-132) Clarify which initial info AnnotatedType should contain
[
https://issues.jboss.org/browse/CDI-132?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-132.
---------------------------
Resolution: Done
Clarify which initial info AnnotatedType should contain
-------------------------------------------------------
Key: CDI-132
URL: https://issues.jboss.org/browse/CDI-132
Project: CDI Specification Issues
Issue Type: Clarification
Components: Portable Extensions
Reporter: Mark Struberg
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
The spec is not exactly clear about the initial content of AnnotatedType.
When initially building the AnnotatedType (e.g. before handing it over to the Extensions)
we need to pre-fill them with the info from the annotations from the classes.
Should this AnnotatedType:
1.) contain no annotations from superclasses?
2.) contain all annotations from superclasses?
3.) contain @Inherited annotations from superclasses?
I think the other questions already got cleared up in CDI-70:
Should AnnotatedType contain derived public? protected? private? methods/fields from a
superclass?
Imo it should contain all information which would be available by manually parsing any
annotations. In other words: it should be possible to completely modify or emulate
annotations of a parsed type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4440
days inactive
4960
days old
26 comments
8 participants
participants (8)
-
Jozef Hartinger (Commented) (JIRA) -
Jozef Hartinger (JIRA)
-
Mark Struberg (Commented) (JIRA)
-
Mark Struberg (JIRA)
-
Martin Kouba (Commented) (JIRA)
-
Martin Kouba (Reopened) (JIRA)
-
Pete Muir (Commented) (JIRA)
-
Pete Muir (JIRA)