[hibernate/hibernate-search] 880cc5: HSEARCH-4001 Clarify the javadoc of ReindexOnUpdate
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: 880cc5b66b941adbba10987ada11c27b01b73626
https://github.com/hibernate/hibernate-search/commit/880cc5b66b941adbba10...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/ReindexOnUpdate.java
Log Message:
-----------
HSEARCH-4001 Clarify the javadoc of ReindexOnUpdate
Commit: 7a423134203390297cef394f266c06a134783031
https://github.com/hibernate/hibernate-search/commit/7a423134203390297cef...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverBuildingHelper.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorDisjointValueNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorPropertyNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorTypeNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorValueNode.java
Log Message:
-----------
HSEARCH-4001 Avoid "get" prefixes in methods related to dependency collectors
Commit: d90e96718a1b3fa9c02d94e4dc0978bcac6364d4
https://github.com/hibernate/hibernate-search/commit/d90e96718a1b3fa9c02d...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/ReindexOnUpdate.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverBuildingHelper.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorDisjointValueNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorPropertyNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorTypeNode.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorValueNode.java
Log Message:
-----------
HSEARCH-4001 Introduce ReindexOnUpdate.SHALLOW to only reindex on changes within the same entity
Commit: 7eb73f44492dfd5ef10853e715edb8ced061bcc5
https://github.com/hibernate/hibernate-search/commit/7eb73f44492dfd5ef108...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBasicIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AbstractAutomaticIndexingAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AssociationModelPrimitives.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AutomaticIndexingSingleAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AbstractAutomaticIndexingMultiAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingListAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingMapKeysAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingMapValuesAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingSortedMapValuesAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingSortedSetAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/MultiAssociationModelPrimitives.java
Log Message:
-----------
HSEARCH-4001 Test @IndexingDependency(reindexOnUpdate = ReindexOnUpdate.SHALLOW)
Commit: 246319563245dbd5063d57df1ac62b660c4d1afa
https://github.com/hibernate/hibernate-search/commit/246319563245dbd5063d...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/Product.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/update/ContainedInReindexPropagationTest.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/update/Dad.java
Log Message:
-----------
HSEARCH-4001 Restore relevant tests in the migration helper
Commit: aca7f54eab63416289d2d15531c5fe2c33461e92
https://github.com/hibernate/hibernate-search/commit/aca7f54eab63416289d2...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/batchindexing/Book.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/batchindexing/IndexedEmbeddedProxyRootEntity.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/batchindexing/LegacyCarPlant.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/Address.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/Country.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/Product.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/path/validation/DepthExceedsPathTestCase.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/path/validation/DepthMatchesPathDepthCase.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/path/validation/ReferencesIndexedEmbeddedA.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/update/UpdateIndexedEmbeddedCollectionTest.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/engine/indexapi/Book.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/query/Book.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/query/Music.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/query/facet/Book.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/session/Email.java
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/session/Entite.java
Log Message:
-----------
HSEARCH-4001 Use ReindexOnUpdate.SHALLOW instead of ReindexOnUpdate.NO in migration helper tests where relevant
That's closer to how Search 5 used to behave.
Commit: cf815bd2d2aa20c5ff2be576abab77a1adb5e7fc
https://github.com/hibernate/hibernate-search/commit/cf815bd2d2aa20c5ff2b...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AbstractAutomaticIndexingAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AssociationModelPrimitives.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AutomaticIndexingSingleAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AbstractAutomaticIndexingMultiAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingListAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingMapKeysAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingMapValuesAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingSortedMapValuesAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/AutomaticIndexingSortedSetAssociationIT.java
M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/multi/MultiAssociationModelPrimitives.java
Log Message:
-----------
HSEARCH-4001 Remove the inverse side of associations relying on ReindexOnUpdate.NO/SHALLOW in tests
1. It's not necessary from the point of view of Hibernate Search.
2. Most of the time, we'll use ReindexOnUpdate.NO/SHALLOW precisely
because we don't have an inverse side for those associations. So
that's a cheap way to check that Hibernate Search accepts
associations without an inverse side when we use
ReindexOnUpdate.NO/SHALLOW.
Commit: 084ae2b4c35187c9b1316b6f321b46cce13a3fe2
https://github.com/hibernate/hibernate-search/commit/084ae2b4c35187c9b131...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DependencyIT.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
Log Message:
-----------
HSEARCH-4001 Recommend ReindexOnUpdate.SHALLOW rather than ReindexOnUpdate.NO when the inverse side of an association is missing
Commit: 0558289ed303f4157747a738d6efa301553667bb
https://github.com/hibernate/hibernate-search/commit/0558289ed303f4157747...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/derivedfrom/Book.java
M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/Book.java
Log Message:
-----------
HSEARCH-4001 Add some previously missing comments to explain that getters/setters are ommitted in documentation examples
Commit: bb500fd954c9c039e32b9549bc1b18bcd28b86ab
https://github.com/hibernate/hibernate-search/commit/bb500fd954c9c039e32b...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M documentation/src/main/asciidoc/reference/mapper-orm-mapping-reindexing.asciidoc
R documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/Book.java
R documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/BookCategory.java
R documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/ReindexOnUpdateIT.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/correct/ReindexOnUpdateNoIT.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/correct/Sensor.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/correct/SensorStatus.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/incorrect/ReindexOnUpdateNoIncorrectIT.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/incorrect/Sensor.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/no/incorrect/SensorStatus.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/correct/Book.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/correct/BookCategory.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/correct/ReindexOnUpdateShallowIT.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/incorrect/Book.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/incorrect/BookCategory.java
A documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/reindexonupdate/shallow/incorrect/ReindexOnUpdateShallowIncorrectIT.java
Log Message:
-----------
HSEARCH-4001 Document ReindexOnUpdate.SHALLOW/NO
Compare: https://github.com/hibernate/hibernate-search/compare/32818ebb9945...bb50...
4 years, 5 months
[hibernate/hibernate-search] 14f201: HSEARCH-3999 Fix migration helper test not using t...
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: 14f201c9e42a1c4ab28ee590486497fbd8dd6492
https://github.com/hibernate/hibernate-search/commit/14f201c9e42a1c4ab28e...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
Log Message:
-----------
HSEARCH-3999 Fix migration helper test not using the right query type for an embedded ID
Commit: 55db0bf242f3f51e90f52d46bcdaab30e5968a20
https://github.com/hibernate/hibernate-search/commit/55db0bf242f3f51e90f5...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoContainedTypeIndexingPlan.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
Log Message:
-----------
HSEARCH-3999 Do not perform reindexing resolution on deleted entities
In most cases, it doesn't work anyway:
* If the deleted entity is not contained in any other entity, we don't care.
* If the deleted entity A is contained in another entity B,
we expect B to have an association pointing to the deleted entity.
* If the association was updated in B, B will be reindexed anyway.
* If that association was not updated in B:
* If the association is lazy in A,
we won't be able to get access to B through the association anyway
(LazyInitializationException).
* If the association is eager in A,
we may be able to get access to B through the association, and to
mark it as "to be reindexed", but:
* If B's side of the association was already loaded before the
deletion (eagerly or through lazy initialization),
reindexing B will lead to an out-of-date document that still
includes A.
* If B's side side of the association is still uninitialized,
lazy initialization *may* yield a collection that doesn't
include A and only then reindexing *may* lead to a correct
result.
Commit: 367057cf89822ed19893e181e330309b4c2ccb5a
https://github.com/hibernate/hibernate-search/commit/367057cf89822ed19893...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AutomaticIndexingAssociationDeletionIT.java
Log Message:
-----------
HSEARCH-3999 Test deletion of contained entities whose elementCollection is indexed-embedded
Commit: cb512f124d209096e8e7fe7a213181212a530fe4
https://github.com/hibernate/hibernate-search/commit/cb512f124d209096e8e7...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
Log Message:
-----------
HSEARCH-3999 Re-enable relevant tests in the migration helper
Commit: 957d194006d243271577f72aa7748cf84fcfbe7f
https://github.com/hibernate/hibernate-search/commit/957d194006d243271577...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/AbstractPojoTypeIndexingPlan.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoContainedTypeIndexingPlan.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexingPlanImpl.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkContainedTypeContext.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkIndexedTypeContext.java
A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkTypeContext.java
Log Message:
-----------
HSEARCH-3999 Share more code between PojoIndexedTypeIndexingPlan and PojoContainedTypeIndexingPlan
Automatic indexing is quite hard to test, because there are lots of
possible combinations. We already have lots of tests, but I think we
missed some code paths because we mostly test indexed types, and more
rarely contained types.
As I don't think it would be reasonable to duplicate existing tests to
also cover contained types, this is the alternative: by sharing more
code between contained types and indexed types, we ensure that if it's
tested for one, it's likely to work for the other, too.
Commit: c19681144bcd475e7402bcd73539f4268f52ae25
https://github.com/hibernate/hibernate-search/commit/c19681144bcd475e7402...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/AbstractPojoTypeIndexingPlan.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
Log Message:
-----------
HSEARCH-3999 Sonar: Methods and field names should not be the same or differ only by capitalization
Compare: https://github.com/hibernate/hibernate-search/compare/2ad9de66bbac...c196...
4 years, 5 months