Branch: refs/heads/master
Home:
https://github.com/hibernate/hibernate-search
Commit: 14f201c9e42a1c4ab28ee590486497fbd8dd6492
https://github.com/hibernate/hibernate-search/commit/14f201c9e42a1c4ab28e...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M
integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
Log Message:
-----------
HSEARCH-3999 Fix migration helper test not using the right query type for an embedded
ID
Commit: 55db0bf242f3f51e90f52d46bcdaab30e5968a20
https://github.com/hibernate/hibernate-search/commit/55db0bf242f3f51e90f5...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoContainedTypeIndexingPlan.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
Log Message:
-----------
HSEARCH-3999 Do not perform reindexing resolution on deleted entities
In most cases, it doesn't work anyway:
* If the deleted entity is not contained in any other entity, we don't care.
* If the deleted entity A is contained in another entity B,
we expect B to have an association pointing to the deleted entity.
* If the association was updated in B, B will be reindexed anyway.
* If that association was not updated in B:
* If the association is lazy in A,
we won't be able to get access to B through the association anyway
(LazyInitializationException).
* If the association is eager in A,
we may be able to get access to B through the association, and to
mark it as "to be reindexed", but:
* If B's side of the association was already loaded before the
deletion (eagerly or through lazy initialization),
reindexing B will lead to an out-of-date document that still
includes A.
* If B's side side of the association is still uninitialized,
lazy initialization *may* yield a collection that doesn't
include A and only then reindexing *may* lead to a correct
result.
Commit: 367057cf89822ed19893e181e330309b4c2ccb5a
https://github.com/hibernate/hibernate-search/commit/367057cf89822ed19893...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
A
integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/association/AutomaticIndexingAssociationDeletionIT.java
Log Message:
-----------
HSEARCH-3999 Test deletion of contained entities whose elementCollection is
indexed-embedded
Commit: cb512f124d209096e8e7fe7a213181212a530fe4
https://github.com/hibernate/hibernate-search/commit/cb512f124d209096e8e7...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M
integrationtest/v5migrationhelper/orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
Log Message:
-----------
HSEARCH-3999 Re-enable relevant tests in the migration helper
Commit: 957d194006d243271577f72aa7748cf84fcfbe7f
https://github.com/hibernate/hibernate-search/commit/957d194006d243271577...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/AbstractPojoTypeIndexingPlan.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoContainedTypeIndexingPlan.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexingPlanImpl.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkContainedTypeContext.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkIndexedTypeContext.java
A
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkTypeContext.java
Log Message:
-----------
HSEARCH-3999 Share more code between PojoIndexedTypeIndexingPlan and
PojoContainedTypeIndexingPlan
Automatic indexing is quite hard to test, because there are lots of
possible combinations. We already have lots of tests, but I think we
missed some code paths because we mostly test indexed types, and more
rarely contained types.
As I don't think it would be reasonable to duplicate existing tests to
also cover contained types, this is the alternative: by sharing more
code between contained types and indexed types, we ensure that if it's
tested for one, it's likely to work for the other, too.
Commit: c19681144bcd475e7402bcd73539f4268f52ae25
https://github.com/hibernate/hibernate-search/commit/c19681144bcd475e7402...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-09-24 (Thu, 24 Sep 2020)
Changed paths:
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/AbstractPojoTypeIndexingPlan.java
M
mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
Log Message:
-----------
HSEARCH-3999 Sonar: Methods and field names should not be the same or differ only by
capitalization
Compare:
https://github.com/hibernate/hibernate-search/compare/2ad9de66bbac...c196...