[hibernate-commits] [hibernate/hibernate-orm] f70976: HHH-16603, HHH-9763 fix some issues with interpret...
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-orm
Commit: f709763dab7e45006cd09eb931a4e1b482bc5401
https://github.com/hibernate/hibernate-orm/commit/f709763dab7e45006cd09eb...
Author: Gavin <gavin(a)hibernate.org>
Date: 2023-05-15 (Mon, 15 May 2023)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
M
hibernate-core/src/main/java/org/hibernate/cache/internal/QueryResultsCacheImpl.java
Log Message:
-----------
HHH-16603, HHH-9763 fix some issues with interpreting @Cache/@Cacheable annotations
1. throw instead of logging a WARN if @Cache is on a subclass.
I just lost 1/2 an hour of my life due to this being a WARN.
Logging WARNs is a terrible way to report user error!
2. Fix interpretation of SharedCacheMode.UNSPECIFIED
Commit: 7f361157e4b4e3572af8f97d9dd30a1ca04d1305
https://github.com/hibernate/hibernate-orm/commit/7f361157e4b4e3572af8f97...
Author: Gavin <gavin(a)hibernate.org>
Date: 2023-05-15 (Mon, 15 May 2023)
Changed paths:
M
hibernate-core/src/test/java/org/hibernate/orm/test/cache/NonRootEntityWithCacheAnnotationTest.java
M
hibernate-core/src/test/java/org/hibernate/orm/test/cfg/cache/DefaultCacheConcurrencyPropertyTest.java
M
hibernate-core/src/test/java/org/hibernate/orm/test/jpa/cacheable/annotation/ConfigurationTest.java
M
hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/ExplicitJavaTypeDescriptorTest.java
Log Message:
-----------
HHH-16603, HHH-9763 fix some tests:
- test that @Cache on a subclass throws instead of WARNs
- remove @FailureExpected because HHH-9763 is now fixed
- correct test with wrong expectation for SharedCacheMode.UNSPECIFIED
- fix test that did not realize ImmmutableMutabilityPlan requires Serializable
Compare: https://github.com/hibernate/hibernate-orm/compare/43fd8a7ced6b...7f36115...