Hibernate SVN: r17114 - beanvalidation/trunk/validation-api/src/main/java/javax/validation.
by hibernate-commits＠lists.jboss.org
Author: epbernard
Date: 2009-07-16 14:00:21 -0400 (Thu, 16 Jul 2009)
New Revision: 17114
Modified:
beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java
Log:
cleaner JavaDoc
Modified: beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java
===================================================================
--- beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java 2009-07-16 17:58:25 UTC (rev 17113)
+++ beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java 2009-07-16 18:00:21 UTC (rev 17114)
@@ -41,8 +41,8 @@
* (using the path specification defined by Bean Validator).
* @param elementType either <code>FIELD</code> or <code>METHOD</code>.
*
- * @return <code>true</code> if Bean Validation is allowed to reach the property state,
- * <code>false</code> otherwise.
+ * @return <code>true</code> if the Bean Validation provider is allowed to
+ * reach the property state, <code>false</code> otherwise.
*/
boolean isReachable(Object traversableObject,
Path.Node traversableProperty,
@@ -66,8 +66,8 @@
* (using the path specification defined by Bean Validator).
* @param elementType either <code>FIELD</code> or <code>METHOD</code>.
*
- * @return <code>true</code> if Bean Validation is allowed to cascade validation,
- * <code>false</code> otherwise.
+ * @return <code>true</code> if the Bean Validation provider is allowed to
+ * cascade validation, <code>false</code> otherwise.
*/
boolean isCascadable(Object traversableObject,
Path.Node traversableProperty,
14 years, 10 months
Hibernate SVN: r17113 - beanvalidation/trunk/validation-api/src/main/java/javax/validation.
by hibernate-commits＠lists.jboss.org
Author: epbernard
Date: 2009-07-16 13:58:25 -0400 (Thu, 16 Jul 2009)
New Revision: 17113
Modified:
beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java
Log:
cleaner JavaDoc
Modified: beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java
===================================================================
--- beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java 2009-07-16 17:42:42 UTC (rev 17112)
+++ beanvalidation/trunk/validation-api/src/main/java/javax/validation/TraversableResolver.java 2009-07-16 17:58:25 UTC (rev 17113)
@@ -22,7 +22,7 @@
/**
* Contract determining if a property can be accessed by the Bean Validation provider
- * This contract is called for each property either validated or cascaded.
+ * This contract is called for each property that is being either validated or cascaded.
*
* A traversable resolver implementation must be thread-safe.
*
@@ -30,7 +30,7 @@
*/
public interface TraversableResolver {
/**
- * Determine if Bean Validation is allowed to reach the property state
+ * Determine if the Bean Validation provider is allowed to reach the property state
*
* @param traversableObject object hosting <code>traversableProperty</code> or null
* if validateValue is called
@@ -51,7 +51,7 @@
ElementType elementType);
/**
- * Determine if Bean Validation is allowed to cascade validation on
+ * Determine if the Bean Validation provider is allowed to cascade validation on
* the bean instance returned by the property value
* marked as <code>@Valid</code>.
* Note that this method is called only if isReachable returns true for the same set of
14 years, 10 months
Hibernate SVN: r17112 - beanvalidation/trunk/validation-api/src/main/java/javax/validation.
by hibernate-commits＠lists.jboss.org
Author: epbernard
Date: 2009-07-16 13:42:42 -0400 (Thu, 16 Jul 2009)
New Revision: 17112
Modified:
beanvalidation/trunk/validation-api/src/main/java/javax/validation/ConstraintValidator.java
Log:
cleaner JavaDoc
Modified: beanvalidation/trunk/validation-api/src/main/java/javax/validation/ConstraintValidator.java
===================================================================
--- beanvalidation/trunk/validation-api/src/main/java/javax/validation/ConstraintValidator.java 2009-07-16 16:25:47 UTC (rev 17111)
+++ beanvalidation/trunk/validation-api/src/main/java/javax/validation/ConstraintValidator.java 2009-07-16 17:42:42 UTC (rev 17112)
@@ -45,6 +45,9 @@
* Implement the validation logic.
* <code>value</code> state must not be altered.
*
+ * This method can be accessed concurrently, thread-safety must be ensured
+ * by the implementation.
+ *
* @param value object to validate
* @param constraintValidatorContext context in which the constraint is evaluated
*
14 years, 10 months
Hibernate SVN: r17111 - in beanvalidation/trunk/validation-tck/src/main: java/org/hibernate/jsr303/tck/tests/validation/graphnavigation and 1 other directories.
by hibernate-commits＠lists.jboss.org
Author: hardy.ferentschik
Date: 2009-07-16 12:25:47 -0400 (Thu, 16 Jul 2009)
New Revision: 17111
Modified:
beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/ValidateTest.java
beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationTest.java
beanvalidation/trunk/validation-tck/src/main/resources/tck-audit.xml
Log:
basic validation tests
Modified: beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/ValidateTest.java
===================================================================
--- beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/ValidateTest.java 2009-07-16 15:51:23 UTC (rev 17110)
+++ beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/ValidateTest.java 2009-07-16 16:25:47 UTC (rev 17111)
@@ -41,6 +41,7 @@
import org.testng.annotations.Test;
import org.hibernate.jsr303.tck.util.TestUtil;
+import static org.hibernate.jsr303.tck.util.TestUtil.assertCorrectNumberOfViolations;
import static org.hibernate.jsr303.tck.util.TestUtil.assertCorrectPropertyPaths;
/**
@@ -320,4 +321,45 @@
"The declared constraint does not explicitly define a group, hence Default is expected"
);
}
+
+ @Test
+ @SpecAssertion(section = "3.5", id = "b")
+ public void testOnlyFirstGroupInSequenceGetEvaluated() {
+ Validator validator = TestUtil.getDefaultValidator();
+ Car car = new Car( "USd-298" );
+
+ Set<ConstraintViolation<Car>> violations = validator.validateProperty(
+ car, "licensePlateNumber", First.class, Second.class
+ );
+ assertCorrectNumberOfViolations( violations, 1 );
+
+ car.setLicensePlateNumber( "USD-298" );
+ violations = validator.validateProperty(
+ car, "licensePlateNumber", First.class, Second.class
+ );
+ assertCorrectNumberOfViolations( violations, 0 );
+ }
+
+ class Car {
+ @Pattern(regexp = "[A-Z][A-Z][A-Z]-[0-9][0-9][0-9]", groups = { First.class, Second.class })
+ private String licensePlateNumber;
+
+ Car(String licensePlateNumber) {
+ this.licensePlateNumber = licensePlateNumber;
+ }
+
+ public String getLicensePlateNumber() {
+ return licensePlateNumber;
+ }
+
+ public void setLicensePlateNumber(String licensePlateNumber) {
+ this.licensePlateNumber = licensePlateNumber;
+ }
+ }
+
+ interface First {
+ }
+
+ interface Second {
+ }
}
\ No newline at end of file
Modified: beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationTest.java
===================================================================
--- beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationTest.java 2009-07-16 15:51:23 UTC (rev 17110)
+++ beanvalidation/trunk/validation-tck/src/main/java/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationTest.java 2009-07-16 16:25:47 UTC (rev 17111)
@@ -227,7 +227,16 @@
p.setChild( new Child() );
Validator validator = TestUtil.getDefaultValidator();
Set<ConstraintViolation<Parent>> errors = validator.validate( p, Parent.ProperOrder.class );
- assertEquals( 1, errors.size() );
+ assertCorrectNumberOfViolations( errors, 1 );
assertCorrectPropertyPaths( errors, "child.name" );
}
+
+ @Test
+ @SpecAssertion(section = "3.5.1", id = "c")
+ public void testNullReferencesGetIgnored() {
+ Parent p = new Parent();
+ Validator validator = TestUtil.getDefaultValidator();
+ Set<ConstraintViolation<Parent>> errors = validator.validateProperty( p, "child" );
+ assertCorrectNumberOfViolations( errors, 0 );
+ }
}
\ No newline at end of file
Modified: beanvalidation/trunk/validation-tck/src/main/resources/tck-audit.xml
===================================================================
--- beanvalidation/trunk/validation-tck/src/main/resources/tck-audit.xml 2009-07-16 15:51:23 UTC (rev 17110)
+++ beanvalidation/trunk/validation-tck/src/main/resources/tck-audit.xml 2009-07-16 16:25:47 UTC (rev 17111)
@@ -565,7 +565,7 @@
<assertion id="b">
<text>If no group is passed, the Default group is assumed</text>
</assertion>
- <assertion id="c">
+ <assertion id="c" testable="false">
<text>When more than one group is evaluated and passed to the various validate methods,
order is not constrained</text>
</assertion>
14 years, 10 months