[hibernate/hibernate-search] d8e528: HSEARCH-3712 Separate the API from the SPI for fie...
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: d8e52841e7e8cbff4f2c1d1db454c8ab252ce62d
https://github.com/hibernate/hibernate-search/commit/d8e52841e7e8cbff4f2c...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-10-30 (Wed, 30 Oct 2019)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchRangeAggregation.java
M backend/elasticsearch/…
[View More]src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchTermsAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchRangePredicateBuilder.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchFieldProjection.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchFieldProjectionBuilder.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/ElasticsearchFieldSortBuilder.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchBooleanFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchGeoPointFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchStandardFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchTextFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/AbstractElasticsearchIndexFieldTypeConverterStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/AbstractElasticsearchScalarFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchBooleanIndexFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchGeoPointIndexFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchNativeIndexFieldTypeOptionsStepImpl.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchStringIndexFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchStandardFieldPredicateBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchStandardMatchPredicateBuilder.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchTextFieldPredicateBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchTextMatchPredicateBuilder.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/ElasticsearchGeoPointFieldProjectionBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/ElasticsearchStandardFieldProjectionBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchStandardFieldSortBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneStandardMatchPredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneStandardRangePredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneFieldProjection.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneFieldProjectionBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneFacetsBasedTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneStandardFieldAggregationBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneBooleanFieldAggregationBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneGeoPointFieldAggregationBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericFieldAggregationBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneTextFieldAggregationBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneTextTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/AbstractLuceneNumericIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/AbstractLuceneStandardIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneBooleanIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneGeoPointIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneNativeIndexFieldTypeFinalStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneStringIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/AbstractLuceneFieldPredicateBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/AbstractLuceneStandardFieldPredicateBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneGeoPointFieldPredicateBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneNumericFieldPredicateBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneNumericMatchPredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneNumericRangePredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextFieldPredicateBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextMatchPredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextRangePredicateBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/LuceneGeoPointFieldProjectionBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/LuceneStandardFieldProjectionBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractLuceneStandardFieldSortBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractLuceneStandardFieldSortBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneNumericFieldSortBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneNumericFieldSortBuilderFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneTextFieldSortBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneTextFieldSortBuilderFactory.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/FromDocumentFieldValueConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/ToDocumentFieldValueConverter.java
A engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/DslConverter.java
A engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/ProjectionConverter.java
M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldDefaultBridgeIT.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/converter/impl/StubFieldConverter.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/dsl/impl/AbstractStubStandardIndexFieldTypeOptionsStep.java
Log Message:
-----------
HSEARCH-3712 Separate the API from the SPI for field value conversion
Commit: c1f7a09719ddca6e133c9b3f82323a1b6f0dd75f
https://github.com/hibernate/hibernate-search/commit/c1f7a09719ddca6e133c...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-10-30 (Wed, 30 Oct 2019)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/AbstractElasticsearchIndexFieldTypeConverterStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/AbstractLuceneStandardIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneNativeIndexFieldTypeFinalStep.java
M documentation/src/main/asciidoc/mapper-orm-bridge.asciidoc
M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/bridge/types/dsl/dslconverter/ISBNBinder.java
M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/bridge/types/dsl/projectionconverter/ISBNBinder.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/FromDocumentFieldValueConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/ToDocumentFieldValueConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/DslConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/PassThroughFromDocumentFieldValueConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/PassThroughToDocumentFieldValueConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/ProjectionConverter.java
M engine/src/main/java/org/hibernate/search/engine/backend/types/dsl/IndexFieldTypeConverterStep.java
M engine/src/main/java/org/hibernate/search/engine/search/common/ValueConvert.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/RangeAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/TermsAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/ExistsSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/PhraseSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/RangeSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/SimpleQueryStringSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/WildcardSearchPredicateIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/ValueWrapper.java
M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldDefaultBridgeIT.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/ValueBindingContext.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PojoValueBridgeFromDocumentFieldValueConverter.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PojoValueBridgeToDocumentFieldValueConverter.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/ValueBindingContextImpl.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/dsl/impl/AbstractStubStandardIndexFieldTypeOptionsStep.java
Log Message:
-----------
HSEARCH-3712 Pass a Class when defining a DSL or projection converter instead of implementing type checks in the converter
Commit: 3c40b6d5b17152ed74a8090b31e42e61f20ff0d4
https://github.com/hibernate/hibernate-search/commit/3c40b6d5b17152ed74a8...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-10-30 (Wed, 30 Oct 2019)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/AbstractElasticsearchScalarFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchGeoPointIndexFieldTypeOptionsStep.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchNativeIndexFieldTypeOptionsStepImpl.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchStringIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/AbstractLuceneNumericIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneGeoPointIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneStringIndexFieldTypeOptionsStep.java
Log Message:
-----------
HSEARCH-3712 Improve formatting of DSL/projection converter creation
Compare: https://github.com/hibernate/hibernate-search/compare/f738f716d224...3c40...
[View Less]
5 years, 4 months
[hibernate/hibernate-search] f738f7: HSEARCH-3748 Remove the bridge-based programmatic ...
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: f738f716d2246f28175fd348ab80dd41ebc05a4c
https://github.com/hibernate/hibernate-search/commit/f738f716d2246f28175f...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-10-30 (Wed, 30 Oct 2019)
Changed paths:
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/impl/BeanBinder.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/…
[View More]pojo/mapping/definition/programmatic/PropertyMappingStep.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/TypeMappingStep.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/DelegatingPropertyMappingStep.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingStep.java
M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java
Log Message:
-----------
HSEARCH-3748 Remove the bridge-based programmatic mapping APIs for TypeBridge, PropertyBridge and RoutingKeyBridge
I.e. the APIs where we don't specify a binder, but a bridge directly.
These APIs are not documented, not tested, but more importantly they
are pointless: defining a brige this way simply cannot work, because
there would be no binder to define the dependencies of the bridge,
so Hibernate Search would simply throw an exception on bootstrap
because of the unknown dependencies.
Even more critical, for the TypeBridge and PropertyBridge, applying a
bridge without a binder would mean that the bridge does not have any
index field reference to work with, so it effectively cannot write to
the index.
[View Less]
5 years, 4 months