[hibernate/hibernate-orm] cca376: fix typing issues related to QueryParameterBindings
by Gavin King
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-orm
Commit: cca376efc4501c5348cce2221affe5642f2e4cb2
https://github.com/hibernate/hibernate-orm/commit/cca376efc4501c5348cce22...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/internal/FilterImpl.java
M hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureParamBindings.java
M hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureParameterMetadataImpl.java
M hibernate-core/src/main/java/org/hibernate/query/ParameterMetadata.java
M hibernate-core/src/main/java/org/hibernate/query/QueryParameter.java
M hibernate-core/src/main/java/org/hibernate/query/internal/ParameterMetadataImpl.java
M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingImpl.java
M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
M hibernate-core/src/main/java/org/hibernate/query/spi/ParameterMetadataImplementor.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmSelectionQueryImpl.java
Log Message:
-----------
fix typing issues related to QueryParameterBindings
+ more code cleanups
Commit: aacc0e29176ae44e995450fc7a9f374daaac3814
https://github.com/hibernate/hibernate-orm/commit/aacc0e29176ae44e995450f...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/DiscriminatorSqmPath.java
M hibernate-core/src/main/java/org/hibernate/procedure/internal/FunctionReturnImpl.java
M hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureParameterImpl.java
M hibernate-core/src/main/java/org/hibernate/query/hql/internal/FullyQualifiedReflectivePathTerminal.java
M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterNamedImpl.java
M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQueryParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/function/SelfRenderingSqmAggregateFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/function/SelfRenderingSqmOrderedSetAggregateFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/function/SelfRenderingSqmWindowFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/DomainParameterXref.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/AbstractSqmRestrictedDmlStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/SqmVisitableNode.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/cte/SqmCteStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/delete/SqmDeleteStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/AbstractSqmFrom.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/AbstractSqmSimplePath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmElementAggregateFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmFkExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmFunctionPath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmIndexAggregateFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmIndexedCollectionAccessPath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmMapEntryReference.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedBagJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedCrossJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedEmbeddedValuedSimplePath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedEntityJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedEntityValuedSimplePath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedListJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedMapJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedPluralPartJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedRoot.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedSetJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedSimplePath.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedSingularJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/AsWrapperSqmExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/JpaCriteriaParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmAliasedNodeRef.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmAny.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmAnyDiscriminatorValue.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmBinaryArithmetic.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmByUnit.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCaseSearched.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCaseSimple.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCastTarget.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCoalesce.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCollation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmCollectionSize.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmDistinct.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmDurationUnit.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmEnumLiteral.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmEvery.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmExtractUnit.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmFieldLiteral.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmFormat.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmHqlNumericLiteral.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJpaCriteriaParameterWrapper.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonExistsExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonNullBehavior.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonObjectAggUniqueKeysBehavior.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonQueryExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonTableFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJsonValueExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmLiteral.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmLiteralEmbeddableType.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmLiteralEntityType.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmLiteralNull.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmModifiedSubQueryExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmNamedExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmNamedParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmOver.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmOverflow.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmParameterizedEntityType.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmPositionalParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmSelfRenderingExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmSetReturningFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmStar.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmSummarization.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmToDuration.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmTrimSpecification.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmTuple.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmUnaryOperation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmWindow.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmXmlAttributesExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmXmlElementExpression.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmXmlTableFunction.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/ValueBindJpaCriteriaParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/AbstractSqmInsertStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmConflictClause.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmInsertSelectStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmInsertValuesStatement.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmBetweenPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmBooleanExpressionPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmComparisonPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmEmptinessPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmExistsPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmGroupedPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmInListPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmInSubQueryPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmJunctionPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmLikePredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmMemberOfPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmNegatedPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmNullnessPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmTruthnessPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/AbstractSqmSelectQuery.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmDynamicInstantiation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmDynamicInstantiationArgument.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmJpaCompoundSelection.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmQueryGroup.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmQueryPart.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmQuerySpec.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmSelection.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmSubQuery.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java
M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcCallFunctionReturnImpl.java
Log Message:
-----------
cleanups around QueryParameterImplementor
and rename a parameter across the whole SQL hierarchy (!)
Compare: https://github.com/hibernate/hibernate-orm/compare/b8076d7a2dbb...aacc0e2...
To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications
1 hour, 3 minutes
[hibernate/hibernate-orm] 608800: move JoinedSubclassEntityPersister.reverse() metho...
by Gavin King
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-orm
Commit: 6088005857b40cb357a084ca77fa34d1806b7df2
https://github.com/hibernate/hibernate-orm/commit/6088005857b40cb357a084c...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/internal/util/collections/ArrayHelper.java
M hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java
Log Message:
-----------
move JoinedSubclassEntityPersister.reverse() methods to ArrayHelper
Commit: a9da3457fa77059e1c1e63cb316da922a133a09c
https://github.com/hibernate/hibernate-orm/commit/a9da3457fa77059e1c1e63c...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/DuplicateMappingException.java
M hibernate-core/src/main/java/org/hibernate/action/internal/AbstractEntityInsertAction.java
M hibernate-core/src/main/java/org/hibernate/binder/internal/BatchSizeBinder.java
M hibernate-core/src/main/java/org/hibernate/binder/internal/CommentBinder.java
M hibernate-core/src/main/java/org/hibernate/binder/internal/DiscriminatorOptionsBinder.java
M hibernate-core/src/main/java/org/hibernate/boot/MetadataSources.java
M hibernate-core/src/main/java/org/hibernate/boot/cfgxml/spi/LoadedConfig.java
M hibernate-core/src/main/java/org/hibernate/boot/jaxb/Origin.java
M hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmXmlTransformer.java
M hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/stax/JpaOrmXmlEventReader.java
M hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/stax/LocalXmlResourceResolver.java
M hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/stax/XMLStreamConstantsUtils.java
M hibernate-core/src/main/java/org/hibernate/boot/model/IdentifierGeneratorDefinition.java
M hibernate-core/src/main/java/org/hibernate/boot/model/internal/AggregateComponentSecondPass.java
M hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedJoinColumns.java
M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
M hibernate-core/src/main/java/org/hibernate/boot/model/internal/GeneratorAnnotationHelper.java
M hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/InferredBasicValueResolver.java
M hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/ManagedResourcesImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/OverriddenMappingDefaults.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/AbstractEntitySourceImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/AbstractPluralAttributeSourceImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/AbstractSingularAttributeSourceEmbeddedImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/AuxiliaryDatabaseObjectBinder.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/EntityHierarchyBuilder.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/EntityHierarchySourceImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/FetchCharacteristicsPluralAttributeImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/FormulaImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/HbmMetadataSourceProcessorImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/JoinedSubclassEntitySourceImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/RelationalObjectBinder.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/RelationalValueSourceHelper.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/SingularAttributeSourceBasicImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/SingularAttributeSourceOneToOneImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/SingularIdentifierAttributeSourceImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/models/annotations/internal/FilterDefAnnotation.java
M hibernate-core/src/main/java/org/hibernate/boot/models/annotations/internal/UuidGeneratorAnnotation.java
M hibernate-core/src/main/java/org/hibernate/boot/models/xml/internal/db/JoinColumnProcessing.java
M hibernate-core/src/main/java/org/hibernate/boot/registry/internal/BootstrapServiceRegistryImpl.java
M hibernate-core/src/main/java/org/hibernate/boot/registry/selector/internal/StrategySelectorImpl.java
M hibernate-core/src/main/java/org/hibernate/bytecode/enhance/spi/interceptor/EnhancementHelper.java
M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BytecodeProviderImpl.java
M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/PassThroughInterceptor.java
M hibernate-core/src/main/java/org/hibernate/cache/cfg/internal/DomainDataRegionConfigImpl.java
M hibernate-core/src/main/java/org/hibernate/cache/internal/CacheKeyImplementation.java
M hibernate-core/src/main/java/org/hibernate/cache/internal/NaturalIdCacheKey.java
M hibernate-core/src/main/java/org/hibernate/cache/spi/entry/StructuredCacheEntry.java
M hibernate-core/src/main/java/org/hibernate/dialect/AbstractPostgreSQLStructJdbcType.java
M hibernate-core/src/main/java/org/hibernate/dialect/DmlTargetColumnQualifierSupport.java
M hibernate-core/src/main/java/org/hibernate/dialect/GroupByConstantRenderingStrategy.java
M hibernate-core/src/main/java/org/hibernate/dialect/GroupBySummarizationRenderingStrategy.java
M hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java
M hibernate-core/src/main/java/org/hibernate/dialect/MariaDBSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/MySQLSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/NullOrdering.java
M hibernate-core/src/main/java/org/hibernate/dialect/OracleArrayJdbcType.java
M hibernate-core/src/main/java/org/hibernate/dialect/OracleBaseStructJdbcType.java
M hibernate-core/src/main/java/org/hibernate/dialect/OracleSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLArrayJdbcType.java
M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLIntervalSecondJdbcType.java
M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/RowLockStrategy.java
M hibernate-core/src/main/java/org/hibernate/dialect/SQLServerSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/SelectItemReferenceStrategy.java
M hibernate-core/src/main/java/org/hibernate/dialect/TiDBSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/dialect/aggregate/OracleAggregateSupport.java
M hibernate-core/src/main/java/org/hibernate/dialect/aggregate/SQLServerAggregateSupport.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/InsertSubstringOverlayEmulation.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/SQLServerEveryAnyEmulation.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/SqlColumn.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/array/ArrayHelper.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArrayConstructorFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArrayConstructorFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArrayTrimEmulation.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/DB2JsonTableFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/H2JsonValueFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/JsonObjectArgumentsValidator.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/JsonPathHelper.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/PostgreSQLJsonReplaceFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonArrayAppendFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonExistsFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonInsertFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonQueryFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonReplaceFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonTableFunction.java
M hibernate-core/src/main/java/org/hibernate/dialect/temptable/TemporaryTable.java
M hibernate-core/src/main/java/org/hibernate/dialect/temptable/TemporaryTableHelper.java
M hibernate-core/src/main/java/org/hibernate/dialect/temptable/TemporaryTableKind.java
M hibernate-core/src/main/java/org/hibernate/engine/internal/Cascade.java
M hibernate-core/src/main/java/org/hibernate/engine/internal/EntityEntryContext.java
M hibernate-core/src/main/java/org/hibernate/engine/internal/ForeignKeys.java
M hibernate-core/src/main/java/org/hibernate/engine/internal/ManagedTypeHelper.java
M hibernate-core/src/main/java/org/hibernate/engine/internal/Nullability.java
M hibernate-core/src/main/java/org/hibernate/engine/jdbc/env/internal/JdbcEnvironmentImpl.java
M hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/FormatStyle.java
M hibernate-core/src/main/java/org/hibernate/engine/jndi/internal/JndiServiceImpl.java
M hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereExtendedJtaPlatform.java
M hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereJtaPlatform.java
M hibernate-core/src/main/java/org/hibernate/event/spi/AutoFlushEvent.java
M hibernate-core/src/main/java/org/hibernate/event/spi/DeleteEvent.java
M hibernate-core/src/main/java/org/hibernate/event/spi/PostInsertEvent.java
M hibernate-core/src/main/java/org/hibernate/event/spi/PostUpdateEvent.java
M hibernate-core/src/main/java/org/hibernate/event/spi/PostUpsertEvent.java
M hibernate-core/src/main/java/org/hibernate/event/spi/PreDeleteEvent.java
M hibernate-core/src/main/java/org/hibernate/generator/EventType.java
M hibernate-core/src/main/java/org/hibernate/id/SequenceMismatchStrategy.java
M hibernate-core/src/main/java/org/hibernate/id/uuid/CustomVersionOneStrategy.java
M hibernate-core/src/main/java/org/hibernate/internal/util/ExceptionHelper.java
M hibernate-core/src/main/java/org/hibernate/internal/util/GenericsHelper.java
M hibernate-core/src/main/java/org/hibernate/internal/util/ImmutableBitSet.java
M hibernate-core/src/main/java/org/hibernate/internal/util/NullnessUtil.java
M hibernate-core/src/main/java/org/hibernate/internal/util/collections/BoundedConcurrentHashMap.java
M hibernate-core/src/main/java/org/hibernate/internal/util/collections/ConcurrentReferenceHashMap.java
M hibernate-core/src/main/java/org/hibernate/internal/util/collections/ReadOnlyMap.java
M hibernate-core/src/main/java/org/hibernate/jpa/event/internal/CallbackRegistryImpl.java
M hibernate-core/src/main/java/org/hibernate/loader/ast/internal/LoaderSelectBuilder.java
M hibernate-core/src/main/java/org/hibernate/loader/ast/internal/MultiKeyLoadHelper.java
M hibernate-core/src/main/java/org/hibernate/mapping/MappedSuperclass.java
M hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java
M hibernate-core/src/main/java/org/hibernate/metamodel/CollectionClassification.java
M hibernate-core/src/main/java/org/hibernate/metamodel/internal/AbstractCompositeIdentifierMapping.java
M hibernate-core/src/main/java/org/hibernate/metamodel/internal/EmbeddableRepresentationStrategyPojo.java
M hibernate-core/src/main/java/org/hibernate/metamodel/internal/EntityRepresentationStrategyPojoStandard.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/EmbeddableMappingType.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/MappingModelHelper.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractDomainPath.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEmbeddableMapping.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddedForeignKeyDescriptor.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/IdClassEmbeddable.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/InverseNonAggregatedIdentifierMapping.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ManyToManyCollectionPart.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationHelper.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/NonAggregatedIdentifierMappingImpl.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/OneToManyCollectionPart.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SelectableMappingImpl.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SimpleForeignKeyDescriptor.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ToOneAttributeMapping.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/ColumnReference.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/ParseTreeVisitor.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/PathConsumer.java
M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/PluralAttributePath.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/AbstractAttribute.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/EmbeddedSqmPathSource.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/MapMember.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/SingularAttributeImpl.java
M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
M hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPropertyMapping.java
M hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java
M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/AttributeAnalysis.java
M hibernate-core/src/main/java/org/hibernate/proxy/HibernateProxy.java
M hibernate-core/src/main/java/org/hibernate/query/common/FetchClauseType.java
M hibernate-core/src/main/java/org/hibernate/query/hql/internal/SqmPathRegistryImpl.java
M hibernate-core/src/main/java/org/hibernate/query/hql/internal/SqmTreeCreationHelper.java
M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
M hibernate-core/src/main/java/org/hibernate/query/internal/ScrollableResultsIterator.java
M hibernate-core/src/main/java/org/hibernate/query/results/internal/Builders.java
M hibernate-core/src/main/java/org/hibernate/query/results/internal/dynamic/DynamicFetchBuilderStandard.java
M hibernate-core/src/main/java/org/hibernate/query/spi/Limit.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/function/FunctionRenderer.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/function/MultipatternSqmFunctionDescriptor.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/KeyBasedPagination.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmMappingModelHelper.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmSelectionQueryImpl.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/spi/SqmCreationHelper.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/AggregateColumnAssignmentHandler.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/FromClauseIndex.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/AnyDiscriminatorPathInterpretation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/BasicValuedPathInterpretation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/EntityValuedPathInterpretation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/SqlAstQueryPartProcessingStateImpl.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/SqmParameterInterpretation.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmPluralPartJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/domain/SqmTreatedPluralPartJoin.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/AbstractSqmParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmExpressionHelper.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmFieldLiteral.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmParameter.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/from/SqmRoot.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/predicate/SqmJunctionPredicate.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmQueryGroup.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmQuerySpec.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmSortSpecification.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmSubQuery.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleEntityValuedModelPart.java
M hibernate-core/src/main/java/org/hibernate/resource/jdbc/internal/AbstractLogicalConnectionImplementor.java
M hibernate-core/src/main/java/org/hibernate/resource/transaction/backend/jta/internal/DdlTransactionIsolatorJtaImpl.java
M hibernate-core/src/main/java/org/hibernate/result/internal/OutputsImpl.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/SqlTreePrinter.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/internal/TableGroupHelper.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstWalker.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AggregateFunctionChecker.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstTreeHelper.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/cte/CteMaterialization.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/cte/CteSearchClauseKind.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/cte/CteTable.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/expression/ExtractUnit.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/expression/TrimSpecification.java
M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/from/LazyTableGroup.java
M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/StandardJdbcMutationExecutor.java
M hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java
M hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcOperationQuerySelect.java
M hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcParametersList.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/DomainResultCreationState.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/Initializer.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/internal/EmbeddableForeignKeyResultImpl.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/internal/NonAggregatedIdentifierMappingInitializer.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityDelayedFetchInitializer.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/tuple/TupleResult.java
M hibernate-core/src/main/java/org/hibernate/tool/schema/extract/internal/SequenceInformationExtractorTiDBDatabaseImpl.java
M hibernate-core/src/main/java/org/hibernate/tool/schema/extract/spi/NameSpaceTablesInformation.java
M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/ScriptTargetOutputToStdout.java
M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/script/SqlScriptVisitor.java
M hibernate-core/src/main/java/org/hibernate/type/AnyType.java
M hibernate-core/src/main/java/org/hibernate/type/TypeHelper.java
M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/CollectionJavaType.java
M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/JavaTypeRegistry.java
M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/ArrayJdbcType.java
M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/spi/JdbcTypeRegistry.java
M hibernate-core/src/main/java/org/hibernate/type/format/jaxb/JaxbXmlFormatMapper.java
M hibernate-core/src/main/java/org/hibernate/type/internal/ParameterizedTypeImpl.java
Log Message:
-----------
Some cleanups done automatically by IntelliJ with some revision by me
Commit: b8076d7a2dbb0207db3505fd6c1e3e76932db624
https://github.com/hibernate/hibernate-orm/commit/b8076d7a2dbb0207db3505f...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureParamBindings.java
M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractCommonQueryContract.java
M hibernate-core/src/main/java/org/hibernate/query/spi/QueryParameterBindings.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmSelectionQueryImpl.java
Log Message:
-----------
some cleanups around QueryParameterBindings
Compare: https://github.com/hibernate/hibernate-orm/compare/18291d8da977...b8076d7...
To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications
2 hours, 23 minutes
[hibernate/hibernate-orm] 18291d: escalate some annotation deprecations to forRemova...
by Gavin King
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-orm
Commit: 18291d8da9774ea8275e6012469de0ec6f03a695
https://github.com/hibernate/hibernate-orm/commit/18291d8da9774ea8275e601...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-04 (Sat, 04 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/annotations/AttributeAccessor.java
M hibernate-core/src/main/java/org/hibernate/annotations/Cascade.java
M hibernate-core/src/main/java/org/hibernate/annotations/CascadeType.java
M hibernate-core/src/main/java/org/hibernate/annotations/Checks.java
M hibernate-core/src/main/java/org/hibernate/annotations/FlushModeType.java
M hibernate-core/src/main/java/org/hibernate/annotations/GenericGenerator.java
M hibernate-core/src/main/java/org/hibernate/annotations/GenericGenerators.java
M hibernate-core/src/main/java/org/hibernate/annotations/NamedNativeQuery.java
M hibernate-core/src/main/java/org/hibernate/annotations/NamedQuery.java
M hibernate-core/src/main/java/org/hibernate/annotations/ResultCheckStyle.java
M hibernate-core/src/main/java/org/hibernate/annotations/SQLDelete.java
M hibernate-core/src/main/java/org/hibernate/annotations/SQLDeleteAll.java
M hibernate-core/src/main/java/org/hibernate/annotations/SQLInsert.java
M hibernate-core/src/main/java/org/hibernate/annotations/SQLUpdate.java
Log Message:
-----------
escalate some annotation deprecations to forRemoval=true
especially the enums which names collide with JPA
To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications
2 hours, 23 minutes
[hibernate/hibernate-orm] 903ce6: mention org.hibernate.graph in migration guide
by Gavin King
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-orm
Commit: 903ce6648fdff53c5a002f51b8a0218003f37f47
https://github.com/hibernate/hibernate-orm/commit/903ce6648fdff53c5a002f5...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M migration-guide.adoc
Log Message:
-----------
mention org.hibernate.graph in migration guide
Commit: 4b106b65591578e1d2d748aa58c17133160af09a
https://github.com/hibernate/hibernate-orm/commit/4b106b65591578e1d2d748a...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/cfg/PersistenceSettings.java
M migration-guide.adoc
Log Message:
-----------
add missing @since
Commit: ced58cc99846262eda789f8861d14e4babcee6f7
https://github.com/hibernate/hibernate-orm/commit/ced58cc99846262eda789f8...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/graph/AttributeNode.java
M hibernate-core/src/main/java/org/hibernate/graph/Graph.java
Log Message:
-----------
add some @since annotations and a lil' bit more Javadoc
Commit: cfe4346ef80cea5ce8df6cd92c356b69ac2b0a1c
https://github.com/hibernate/hibernate-orm/commit/cfe4346ef80cea5ce8df6cd...
Author: Gavin King <gavin(a)hibernate.org>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/graph/AttributeNode.java
M hibernate-core/src/main/java/org/hibernate/graph/Graph.java
R hibernate-core/src/main/java/org/hibernate/graph/internal/AbstractGraph.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/AttributeNodeImpl.java
A hibernate-core/src/main/java/org/hibernate/graph/internal/GraphImpl.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/RootGraphImpl.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/SubGraphImpl.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/parse/GraphParser.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/parse/PathQualifierType.java
M hibernate-core/src/main/java/org/hibernate/graph/internal/parse/SubGraphGenerator.java
M hibernate-core/src/main/java/org/hibernate/graph/spi/AttributeNodeImplementor.java
M hibernate-core/src/main/java/org/hibernate/graph/spi/GraphImplementor.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/MapPersistentAttribute.java
M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/AppliedGraphs.java
M hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityDelayedFetchInitializer.java
M hibernate-core/src/main/java/org/hibernate/sql/results/internal/StandardEntityGraphTraversalStateImpl.java
M hibernate-core/src/test/java/org/hibernate/orm/test/entitygraph/parser/EntityGraphParserTest.java
Log Message:
-----------
Graphpocalypse: actually let's just deprecate the makeXxxxSubGraph() operations...
... and delete the new ones I added.
The reasoning here is that they just aren't properly typesafe,
as you can see by the hoops I had to go through to actually
implement them. And since the whole package is marked
@Incubating, we're not committed to them.
This lets me make the implementation even more typesafe and
detect more user errors and bugs.
Compare: https://github.com/hibernate/hibernate-orm/compare/3e36bc4f6d69...cfe4346...
To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications
13 hours, 46 minutes
[hibernate/hibernate-search] 1bdba9: HSEARCH-5297 Switch to narayana-spring-boot instea...
by Marko Bekhta
Branch: refs/heads/main
Home: https://github.com/hibernate/hibernate-search
Commit: 1bdba9e498dd90d9834e31e50e7cd741715b2ef9
https://github.com/hibernate/hibernate-search/commit/1bdba9e498dd90d9834e...
Author: marko-bekhta <marko.prykladna(a)gmail.com>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M build/parents/build/pom.xml
M integrationtest/mapper/orm-spring/pom.xml
M integrationtest/mapper/orm-spring/src/test/java/org/hibernate/search/integrationtest/spring/jta/timeout/RaisedTimeoutJtaAndSpringOutboxIT.java
M integrationtest/mapper/orm-spring/src/test/java/org/hibernate/search/integrationtest/spring/jta/timeout/TransactionTimeoutJtaAndSpringOutboxIT.java
M integrationtest/mapper/orm-spring/src/test/java/org/hibernate/search/integrationtest/spring/testsupport/AbstractMapperOrmSpringIT.java
M integrationtest/mapper/orm-spring/src/test/java/org/hibernate/search/integrationtest/spring/transaction/TransactionIT.java
M integrationtest/mapper/orm-spring/src/test/resources/application-jta.yaml
M integrationtest/mapper/orm-spring/src/test/resources/application-transaction-timeout.yaml
M integrationtest/mapper/orm-spring/src/test/resources/application.yaml
M pom.xml
Log Message:
-----------
HSEARCH-5297 Switch to narayana-spring-boot instead of atomikos
To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-search/settings/notifications
17 hours, 4 minutes