[hibernate-commits] [hibernate/hibernate-orm] 83cdeb: HHH-18169 big cleanup of lock/refresh in SessionIm...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 83cdeb81b66e1e3ea86feb1f8610d6a878c410c4 https://github.com/hibernate/hibernate-orm/commit/83cdeb81b66e1e3ea86feb1... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/internal/AbstractSharedSessionContract.java M hibernate-core/src/main/java/org/hibernate/internal/FastSessionServices.java A hibernate-core/src/main/java/org/hibernate/internal/LockOptionsHelper.java M hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java M hibernate-core/src/main/java/org/hibernate/jpa/internal/util/ConfigurationHelper.java R hibernate-core/src/main/java/org/hibernate/jpa/internal/util/LockOptionsHelper.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/transaction/FlushAndTransactionTest.java Log Message: ----------- HHH-18169 big cleanup of lock/refresh in SessionImpl and collaborators this was a big mess with no consistency between different overloads of the same-named method of Session, not to mention different methods Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: f805bcec639f99642a7f0d63ee8fb35c989369e0 https://github.com/hibernate/hibernate-orm/commit/f805bcec639f99642a7f0d6... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/model/internal/PropertyContainer.java M hibernate-core/src/main/java/org/hibernate/boot/registry/classloading/internal/ClassLoaderServiceImpl.java M hibernate-core/src/main/java/org/hibernate/boot/registry/classloading/spi/ClassLoaderService.java M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/ByteBuddyState.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/dialect/spi/BasicSQLExceptionConverter.java M hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java M hibernate-core/src/main/java/org/hibernate/engine/spi/CollectionEntry.java M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultLockEventListener.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/DeprecationLogger.java M hibernate-core/src/main/java/org/hibernate/internal/util/ConfigHelper.java M hibernate-core/src/main/java/org/hibernate/internal/util/LockModeConverter.java M hibernate-core/src/main/java/org/hibernate/proxy/pojo/bytebuddy/ByteBuddyProxyFactory.java M hibernate-core/src/main/java/org/hibernate/proxy/pojo/bytebuddy/ByteBuddyProxyHelper.java M hibernate-core/src/main/java/org/hibernate/query/hql/HqlLogging.java M hibernate-core/src/test/java/org/hibernate/orm/test/id/IdentityIdEntityTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/callbacks/PrivateConstructorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/property/GetAndIsVariantGetterTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/service/ClassLoaderServiceImplTest.java Log Message: ----------- cleanups, especially to useless uses of JBoss logging don't use loggers to generate exception messages our convention for exception messages is NOT that they begin with HHH-XXXX it's completely useless to have, like, five of them which do Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: dd16ed61f09f94ed5e53d661a372b16280a1ee32 https://github.com/hibernate/hibernate-orm/commit/dd16ed61f09f94ed5e53d66... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/cascade2/CascadeTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/lock/JPALockTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/lock/LockTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/lock/RepeatableReadTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/model/AbstractJPATest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/naturalid/ImmutableNaturalIdTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/removed/RemovedEntityTest.java M hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/SessionFactoryExtension.java Log Message: ----------- fix and clean up AbstractJPATest clean up LockTest a little Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: d7aa5f7a78616c9ed7b3340acc913a67d2d61f5a https://github.com/hibernate/hibernate-orm/commit/d7aa5f7a78616c9ed7b3340... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/TransactionImpl.java M hibernate-core/src/main/java/org/hibernate/internal/ExceptionConverterImpl.java M hibernate-core/src/main/java/org/hibernate/internal/HEMLogging.java Log Message: ----------- clean up ExceptionConverterImpl Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: f95182e736f2bb1ef3cf4d02e8615a513b48a59c https://github.com/hibernate/hibernate-orm/commit/f95182e736f2bb1ef3cf4d0... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultDeleteEventListener.java M hibernate-core/src/main/java/org/hibernate/jpa/boot/internal/EntityManagerFactoryBuilderImpl.java M hibernate-core/src/test/java/org/hibernate/orm/test/pc/FilterTest.java Log Message: ----------- more consistent error message between JPA and plain Hibernate Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: 335f7bea9ce6eee93c98b0936604ffa0fe7f1d1d https://github.com/hibernate/hibernate-orm/commit/335f7bea9ce6eee93c98b09... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/event/spi/LoadEvent.java M hibernate-core/src/main/java/org/hibernate/event/spi/LockEvent.java M hibernate-core/src/main/java/org/hibernate/event/spi/RefreshEvent.java M hibernate-core/src/main/java/org/hibernate/internal/LockOptionsHelper.java M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java M hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/internal/DeferredResultSetAccess.java Log Message: ----------- avoid use of deprecated methods Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Commit: 5c89079f2e61d82f623b48da4623af022bc5daa8 https://github.com/hibernate/hibernate-orm/commit/5c89079f2e61d82f623b48d... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2024-09-01 (Sun, 01 Sep 2024) Changed paths: M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultLoadEventListener.java M hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java M hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java Log Message: ----------- consistently pass along session-level lock options previously, these were respected by a random subset of session methods Signed-off-by: Gavin King <gavin(a)hibernate.org&gt; Compare: https://github.com/hibernate/hibernate-orm/compare/f45e3db4b0e4...5c89079... To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications